Skip to content

Commit f089ce0

Browse files
Upgraded sbt to 1.6, scala.js to 1.8 and webpack to 5 (#5)
1 parent 1bf965e commit f089ce0

File tree

13 files changed

+85
-30
lines changed

13 files changed

+85
-30
lines changed

.github/workflows/ci.yml

Lines changed: 20 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ name: CI
22

33
on:
44
push:
5+
paths-ignore:
6+
- '*.md'
57
branches: [ master ]
68
tags:
79
- '*'
@@ -13,41 +15,41 @@ jobs:
1315
runs-on: ubuntu-latest
1416
steps:
1517

16-
- name: Git checkout
17-
uses: actions/checkout@v2
18+
- name: Git checkout (merge)
19+
uses: actions/checkout@v3
20+
if: github.event_name != 'pull_request'
1821
with:
1922
fetch-depth: 0
2023

24+
- name: Git checkout (PR)
25+
uses: actions/checkout@v3
26+
if: github.event_name == 'pull_request'
27+
with:
28+
fetch-depth: 0
29+
# see: https://frontside.com/blog/2020-05-26-github-actions-pull_request/#how-does-pull_request-affect-actionscheckout
30+
ref: ${{ github.event.pull_request.head.sha }}
31+
2132
- name: Setup Node.js
22-
uses: actions/setup-node@v2
33+
uses: actions/setup-node@v3
2334
with:
24-
node-version: '12'
35+
node-version: '16'
2536

2637
- name: Set up JDK 8
27-
uses: actions/setup-java@v2
38+
uses: actions/setup-java@v3
2839
with:
2940
java-version: '8'
3041
distribution: 'adopt'
31-
32-
- name: Cache sbt
33-
uses: actions/cache@v2
34-
with:
35-
path: |
36-
~/.sbt
37-
~/.ivy2/cache
38-
~/.coursier/cache/v1
39-
~/.cache/coursier/v1
40-
key: ${{ runner.os }}-sbt-cache-v2-${{ hashFiles('**/*.sbt', 'project/**/*.scala') }}
42+
cache: 'sbt'
4143

4244
- name: Cache node_modules
43-
uses: actions/cache@v2
45+
uses: actions/cache@v3
4446
with:
4547
path: |
4648
~/.npm
4749
~/.nvm
48-
key: ${{ runner.os }}-node_modules-cache-v2-${{ hashFiles('**/package-lock.json') }}
50+
key: ${{ runner.os }}-node_modules-cache-v3-${{ hashFiles('**/package-lock.json') }}
4951
restore-keys: |
50-
${{ runner.os }}-node_modules-cache-v2-
52+
${{ runner.os }}-node_modules-cache-v3-
5153
5254
- name: Extract Tag Name
5355
run: echo "TAG_NAME=$(echo ${GITHUB_REF##*/})" >> $GITHUB_ENV

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
*.class
22
*.log
3+
package-lock.json
34

45
# sbt specific
56
.cache

.sbtopts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
-J-Xmx2G
2+
-J-XX:+UseG1GC

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
[![CI](https://github.com/scommons/scommons-api/actions/workflows/ci.yml/badge.svg?branch=master)](https://github.com/scommons/scommons-api/actions/workflows/ci.yml?query=workflow%3Aci+branch%3Amaster)
33
[![Coverage Status](https://coveralls.io/repos/github/scommons/scommons-api/badge.svg?branch=master)](https://coveralls.io/github/scommons/scommons-api?branch=master)
44
[![scala-index](https://index.scala-lang.org/scommons/scommons-api/scommons-api-core/latest.svg)](https://index.scala-lang.org/scommons/scommons-api/scommons-api-core)
5-
[![Scala.js](https://www.scala-js.org/assets/badges/scalajs-1.5.0.svg)](https://www.scala-js.org)
5+
[![Scala.js](https://www.scala-js.org/assets/badges/scalajs-1.8.0.svg)](https://www.scala-js.org)
66

77
## scommons-api
88
Common REST API Scala/Scala.js components

project/build.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
sbt.version = 1.5.2
1+
sbt.version = 1.6.2

project/plugins.sbt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
//resolvers += "Typesafe repository" at "https://repo.typesafe.com/typesafe/releases/"
22
resolvers += "Sonatype Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots/"
33

4-
//addSbtPlugin(("org.scommons.sbt" % "sbt-scommons-plugin" % "0.9.0-SNAPSHOT").changing())
5-
addSbtPlugin("org.scommons.sbt" % "sbt-scommons-plugin" % "0.9.0")
4+
addSbtPlugin(("org.scommons.sbt" % "sbt-scommons-plugin" % "1.0.0-SNAPSHOT").changing())
5+
//addSbtPlugin("org.scommons.sbt" % "sbt-scommons-plugin" % "0.9.0")
66

77
addSbtPlugin("org.xerial.sbt" % "sbt-sonatype" % "3.9.5")
88
addSbtPlugin("com.jsuereth" % "sbt-pgp" % "1.1.0")
99

10-
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "1.7.3")
11-
addSbtPlugin("org.scoverage" % "sbt-coveralls" % "1.2.7")
10+
addSbtPlugin("org.scoverage" % "sbt-scoverage" % "1.9.3")
11+
addSbtPlugin("org.scoverage" % "sbt-coveralls" % "1.3.2")

project/src/main/scala/definitions/ApiAdmin.scala

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package definitions
22

3-
import common.TestLibs
3+
import common.{Libs, TestLibs}
44
import sbt.Keys._
55
import sbt._
66
import sbtcrossproject.CrossPlugin.autoImport._
@@ -29,7 +29,11 @@ object ApiAdmin {
2929
// Add JVM-specific settings here
3030
).jsSettings(
3131
// Add JS-specific settings here
32-
ScalaJsModule.settings: _*
32+
ScalaJsModule.settings ++ Seq(
33+
libraryDependencies ++= Seq(
34+
Libs.scalaJsJavaSecureRandom.value % "test"
35+
)
36+
): _*
3337
)
3438

3539
lazy val jvm: Project = `scommons-api-admin`.jvm

project/src/main/scala/definitions/ApiCore.scala

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@ object ApiCore {
3131
Libs.jodaTime.value
3232
)
3333
).jsSettings(
34-
ScalaJsModule.settings: _*
34+
ScalaJsModule.settings ++ Seq(
35+
libraryDependencies ++= Seq(
36+
Libs.scalaJsJavaSecureRandom.value % "test"
37+
)
38+
): _*
3539
)
3640

3741
lazy val jvm: Project = `scommons-api-core`.jvm

project/src/main/scala/definitions/ApiJodaTime.scala

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,11 @@ object ApiJodaTime {
3030
Libs.jodaTime.value
3131
)
3232
).jsSettings(
33-
ScalaJsModule.settings: _*
33+
ScalaJsModule.settings ++ Seq(
34+
libraryDependencies ++= Seq(
35+
Libs.scalaJsJavaSecureRandom.value % "test"
36+
)
37+
): _*
3438
)
3539

3640
lazy val jvm: Project = `scommons-api-joda-time`.jvm

project/src/main/scala/definitions/ApiModule.scala

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package definitions
22

3+
import org.scoverage.coveralls.Imports.CoverallsKeys._
34
import sbt.Keys._
45
import sbt._
56
import scommons.sbtplugin.project.CommonModule
@@ -20,6 +21,8 @@ object ApiModule {
2021
val settings: Seq[Setting[_]] = Seq(
2122
organization := "org.scommons.api",
2223

24+
coverallsService := GitHubActionsCI.jobId.map(_ => GitHubActionsCI),
25+
2326
//
2427
// publish/release related settings:
2528
//

0 commit comments

Comments
 (0)