Skip to content

Commit b18d727

Browse files
sukimasclem
authored andcommitted
Reference working websocket.io branch
Close markserv#19 In commit b449a88 ("Use a specific unreleased commit of Website.io until it get released later.", 2017-01-17) we needed an unreleased fix to websocket.io. It seems that either GitHub or NPM has lost the option to reference commits linked through another fork. This fixes markserv#19 by referencing the original author's branch. This unreleased version is required because websocket.io is broken on Node 7+. Unfortunately it seems that the websocket.io authors no longer are interested in keeping their package Node 7+ compatible. (Discussion at LearnBoost/websocket.io#57). There still exists the following caveats: * If @kewisch wishes to remove his fork then this will no longer work * Official support seems lacking * This program is dependent on an unstable package I suggest investigating the possibility of using an alternative websocket package with less problems.
1 parent 20620a5 commit b18d727

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"open": "0.0.5",
3737
"openport": "0.0.4",
3838
"send": "^0.14.1",
39-
"websocket.io": "git://github.com/LearnBoost/websocket.io#5f0b3799f50944bc4d1eb58acdef61c38883d6cf"
39+
"websocket.io": "git://github.com/kewisch/websocket.io#require-events"
4040
},
4141
"devDependencies": {
4242
"connect-livereload": "^0.6.0",

0 commit comments

Comments
 (0)