add parentheses to all non-arg java methods

Author: rochala

presentation-compiler/src/main/dotty/tools/pc/CompilerSearchVisitor.scala

@@ -17,7 +17,7 @@ class CompilerSearchVisitor(
 )(using ctx: Context, reports: ReportContext)
     extends SymbolSearchVisitor:
 
-  val logger: Logger = Logger.getLogger(classOf[CompilerSearchVisitor].getName.nn).nn
+  val logger: Logger = Logger.getLogger(classOf[CompilerSearchVisitor].getName().nn).nn
 
   private def isAccessible(sym: Symbol): Boolean = try
     sym != NoSymbol && sym.isPublic && sym.isStatic

presentation-compiler/src/main/dotty/tools/pc/CompletionItemResolver.scala

@@ -60,7 +60,7 @@ object CompletionItemResolver extends ItemResolver:
       else ""
     val companion = gsym.companion
     if companion == NoSymbol || gsym.is(JavaDefined) then
-      if gsymDoc.isEmpty then
+      if gsymDoc.isEmpty() then
         if gsym.isAliasType then
           fullDocstring(gsym.info.metalsDealias.typeSymbol, search)
         else if gsym.is(Method) then
@@ -73,8 +73,8 @@ object CompletionItemResolver extends ItemResolver:
       else gsymDoc
     else
       val companionDoc = docs(companion)
-      if companionDoc.isEmpty then gsymDoc
-      else if gsymDoc.isEmpty then companionDoc
+      if companionDoc.isEmpty() then gsymDoc
+      else if gsymDoc.isEmpty() then companionDoc
       else
         List(
           s"""|### ${keyword(companion)} ${companion.name}

presentation-compiler/src/main/dotty/tools/pc/HoverProvider.scala

@@ -78,7 +78,7 @@ object HoverProvider:
         )
       end report
       reportContext.unsanitized.create(report, ifVerbose = true)
-      ju.Optional.empty.nn
+      ju.Optional.empty().nn
     else
       val skipCheckOnName =
         !pos.isPoint // don't check isHoveringOnName for RangeHover
@@ -146,7 +146,7 @@ object HoverProvider:
                 )
               ).nn
             case _ =>
-              ju.Optional.empty.nn
+              ju.Optional.empty().nn
           end match
       end match
     end if
@@ -189,7 +189,7 @@ object HoverProvider:
 
       refTpe.flatMap(findRefinement).asJava
     case _ =>
-      ju.Optional.empty.nn
+      ju.Optional.empty().nn
 
 end HoverProvider
 

presentation-compiler/src/main/dotty/tools/pc/InferredTypeProvider.scala

@@ -67,7 +67,7 @@ final class InferredTypeProvider(
 
     val sourceText = adjustOpt.map(_.text).getOrElse(params.text.nn)
     val source =
-      SourceFile.virtual(filePath.toString, sourceText)
+      SourceFile.virtual(filePath.toString(), sourceText)
     driver.run(uri, source)
     val unit = driver.currentCtx.run.nn.units.head
     val pos = driver.sourcePosition(params)
@@ -308,7 +308,7 @@ final class InferredTypeProvider(
           val end = if withBacktick then idx + 1 else idx
           val pos = tree.source.atSpan(Span(start, end, start))
           Some(pos)
-        case None if idx < text.length =>
+        case None if idx < text.length() =>
           val ch = text.charAt(idx)
           if ch == realName.head then
             lookup(idx + 1, Some((idx, realName.tail)), withBacktick)

presentation-compiler/src/main/dotty/tools/pc/MetalsDriver.scala

@@ -48,7 +48,7 @@ class MetalsDriver(
 
   override def run(uri: URI, sourceCode: String): List[Diagnostic] =
     val diags =
-      if alreadyCompiled(uri, sourceCode.toCharArray.nn) then Nil
+      if alreadyCompiled(uri, sourceCode.toCharArray().nn) then Nil
       else super.run(uri, sourceCode)
     lastCompiledURI = uri
     diags

presentation-compiler/src/main/dotty/tools/pc/PcCollector.scala

@@ -37,7 +37,7 @@ abstract class PcCollector[T](
   val filePath = Paths.get(uri).nn
   val sourceText = params.text.nn
   val source =
-    SourceFile.virtual(filePath.toString, sourceText)
+    SourceFile.virtual(filePath.toString(), sourceText)
   driver.run(uri, source)
   given ctx: Context = driver.currentCtx
 

presentation-compiler/src/main/dotty/tools/pc/PcDefinitionProvider.scala

@@ -54,7 +54,7 @@ class PcDefinitionProvider(
       if findTypeDef then findTypeDefinitions(path, pos, indexedContext)
       else findDefinitions(path, pos, indexedContext)
 
-    if result.locations.nn.isEmpty then fallbackToUntyped(pos)(using ctx)
+    if result.locations.nn.isEmpty() then fallbackToUntyped(pos)(using ctx)
     else result
   end definitions
 

presentation-compiler/src/main/dotty/tools/pc/PcInlineValueProviderImpl.scala

@@ -27,7 +27,7 @@ final class PcInlineValueProviderImpl(
 ) extends PcCollector[Occurence](driver, params)
     with InlineValueProvider:
 
-  val text = params.text.nn.toCharArray.nn
+  val text = params.text.nn.toCharArray().nn
 
   val position: l.Position = pos.toLsp.getStart.nn
 

presentation-compiler/src/main/dotty/tools/pc/SemanticdbTextDocumentProvider.scala

@@ -29,7 +29,7 @@ class SemanticdbTextDocumentProvider(
     val validCode = removeMagicImports(sourceCode, filePath)
     driver.run(
       uri,
-      SourceFile.virtual(filePath.toString, validCode)
+      SourceFile.virtual(filePath.toString(), validCode)
     )
     val tree = driver.currentCtx.run.nn.units.head.tpdTree
     val extractor = ExtractSemanticDB.Extractor()
@@ -42,7 +42,7 @@ class SemanticdbTextDocumentProvider(
         if Properties.isWin then relativeUri.toString().replace("\\", "/")
         else relativeUri.toString()
       }
-      .getOrElse(filePath.toString)
+      .getOrElse(filePath.toString())
 
     val document = TextDocument(
       schema = Schema.SEMANTICDB4,
@@ -57,7 +57,7 @@ class SemanticdbTextDocumentProvider(
     val out = SemanticdbOutputStream.newInstance(byteStream)
     document.writeTo(out)
     out.flush()
-    byteStream.toByteArray.nn
+    byteStream.toByteArray().nn
   end textDocument
 
 end SemanticdbTextDocumentProvider

presentation-compiler/src/main/dotty/tools/pc/SignatureHelpProvider.scala

@@ -175,11 +175,11 @@ object SignatureHelpProvider:
     info
 
   private def markupContent(content: String): l.MarkupContent | Null =
-    if content.isEmpty then null
+    if content.isEmpty() then null
     else
       val markup = new l.MarkupContent
       markup.setKind("markdown")
-      markup.setValue(content.trim)
+      markup.setValue(content.trim())
       markup
 
 end SignatureHelpProvider