ci(kitchen+gitlab): update for new pre-salted images

* Semi-automated using myii/ssf-formula#288

Author: myii

.gitlab-ci.yml

@@ -143,6 +143,7 @@ default-centos-7-master-py3: {extends: '.test_instance'}
 # default-fedora-33-master-py3: {extends: '.test_instance'}
 # default-fedora-32-master-py3: {extends: '.test_instance'}
 default-opensuse-leap-152-master-py3: {extends: '.test_instance'}
+default-opensuse-tmbl-latest-master-py3: {extends: '.test_instance'}
 default-amazonlinux-2-master-py3: {extends: '.test_instance'}
 # default-oraclelinux-8-master-py3: {extends: '.test_instance'}
 # default-gentoo-stage3-latest-master-py3: {extends: '.test_instance'}
@@ -157,6 +158,7 @@ default-amazonlinux-2-master-py3: {extends: '.test_instance'}
 # default-fedora-33-3002-2-py3: {extends: '.test_instance'}
 # default-fedora-32-3002-2-py3: {extends: '.test_instance'}
 # default-opensuse-leap-152-3002-2-py3: {extends: '.test_instance'}
+# default-opensuse-tmbl-latest-3002-2-py3: {extends: '.test_instance'}
 # default-amazonlinux-2-3002-2-py3: {extends: '.test_instance'}
 # default-oraclelinux-8-3002-2-py3: {extends: '.test_instance'}
 default-oraclelinux-7-3002-2-py3: {extends: '.test_instance'}
@@ -173,6 +175,7 @@ default-oraclelinux-7-3002-2-py3: {extends: '.test_instance'}
 # default-fedora-33-3001-4-py3: {extends: '.test_instance'}
 # default-fedora-32-3001-4-py3: {extends: '.test_instance'}
 # default-opensuse-leap-152-3001-4-py3: {extends: '.test_instance'}
+# default-opensuse-tmbl-latest-3001-4-py3: {extends: '.test_instance'}
 # default-amazonlinux-2-3001-4-py3: {extends: '.test_instance'}
 # default-oraclelinux-8-3001-4-py3: {extends: '.test_instance'}
 # default-oraclelinux-7-3001-4-py3: {extends: '.test_instance'}

.travis.yml

@@ -103,6 +103,7 @@ jobs:
     # - env: INSTANCE=default-fedora-33-master-py3
     # - env: INSTANCE=default-fedora-32-master-py3
     - env: INSTANCE=default-opensuse-leap-152-master-py3
+    - env: INSTANCE=default-opensuse-tmbl-latest-master-py3
     - env: INSTANCE=default-amazonlinux-2-master-py3
     # - env: INSTANCE=default-oraclelinux-8-master-py3
     # - env: INSTANCE=default-gentoo-stage3-latest-master-py3
@@ -117,6 +118,7 @@ jobs:
     # - env: INSTANCE=default-fedora-33-3002-2-py3
     # - env: INSTANCE=default-fedora-32-3002-2-py3
     # - env: INSTANCE=default-opensuse-leap-152-3002-2-py3
+    # - env: INSTANCE=default-opensuse-tmbl-latest-3002-2-py3
     # - env: INSTANCE=default-amazonlinux-2-3002-2-py3
     # - env: INSTANCE=default-oraclelinux-8-3002-2-py3
     - env: INSTANCE=default-oraclelinux-7-3002-2-py3
@@ -133,6 +135,7 @@ jobs:
     # - env: INSTANCE=default-fedora-33-3001-4-py3
     # - env: INSTANCE=default-fedora-32-3001-4-py3
     # - env: INSTANCE=default-opensuse-leap-152-3001-4-py3
+    # - env: INSTANCE=default-opensuse-tmbl-latest-3001-4-py3
     # - env: INSTANCE=default-amazonlinux-2-3001-4-py3
     # - env: INSTANCE=default-oraclelinux-8-3001-4-py3
     # - env: INSTANCE=default-oraclelinux-7-3001-4-py3

kitchen.yml

@@ -79,6 +79,14 @@ platforms:
     # => SCP did not finish successfully (255):  (Net::SCP::Error)
     transport:
       max_ssh_sessions: 1
+  - name: opensuse-tmbl-latest-master-py3
+    driver:
+      image: saltimages/salt-master-py3:opensuse-tumbleweed-latest
+      run_command: /usr/lib/systemd/systemd
+    # Workaround to avoid intermittent failures on `opensuse-tumbleweed`:
+    # => SCP did not finish successfully (255):  (Net::SCP::Error)
+    transport:
+      max_ssh_sessions: 1
   - name: amazonlinux-2-master-py3
     driver:
       image: saltimages/salt-master-py3:amazonlinux-2
@@ -129,6 +137,14 @@ platforms:
     # => SCP did not finish successfully (255):  (Net::SCP::Error)
     transport:
       max_ssh_sessions: 1
+  - name: opensuse-tmbl-latest-3002-2-py3
+    driver:
+      image: saltimages/salt-3002.2-py3:opensuse-tumbleweed-latest
+      run_command: /usr/lib/systemd/systemd
+    # Workaround to avoid intermittent failures on `opensuse-tumbleweed`:
+    # => SCP did not finish successfully (255):  (Net::SCP::Error)
+    transport:
+      max_ssh_sessions: 1
   - name: amazonlinux-2-3002-2-py3
     driver:
       image: saltimages/salt-3002.2-py3:amazonlinux-2
@@ -186,6 +202,14 @@ platforms:
     # => SCP did not finish successfully (255):  (Net::SCP::Error)
     transport:
       max_ssh_sessions: 1
+  - name: opensuse-tmbl-latest-3001-4-py3
+    driver:
+      image: saltimages/salt-3001.4-py3:opensuse-tumbleweed-latest
+      run_command: /usr/lib/systemd/systemd
+    # Workaround to avoid intermittent failures on `opensuse-tumbleweed`:
+    # => SCP did not finish successfully (255):  (Net::SCP::Error)
+    transport:
+      max_ssh_sessions: 1
   - name: amazonlinux-2-3001-4-py3
     driver:
       image: saltimages/salt-3001.4-py3:amazonlinux-2

test/integration/share/README.md

@@ -13,9 +13,10 @@ The `system` library provides easy access to system dependent information:
 - `system.platform`: based on `inspec.platform`, modify to values that are more consistent from a SaltStack perspective
   - `system.platform[:family]` provide a family name for Arch and Gentoo
   - `system.platform[:name]` append `linux` to both `amazon` and `oracle`; ensure Windows platforms are resolved as simply `windows`
-  - `system.platform[:release]` tweak Arch, Amazon Linux, Gentoo and Windows:
+  - `system.platform[:release]` tweak Arch, Amazon Linux, Gentoo, openSUSE and Windows:
     - `Arch` is always `base-latest`
     - `Amazon Linux` release `2018` is resolved as `1`
     - `Gentoo` release is trimmed to its major version number and then the init system is appended (i.e. `sysv` or `sysd`)
+    - `openSUSE` is resolved as `tumbleweed` if the `platform[:release]` is in date format
     - `Windows` uses the widely-used release number (e.g. `8.1` or `2019-server`) in place of the actual system release version
   - `system.platform[:finger]` is the concatenation of the name and the major release number (except for Ubuntu, which gives `ubuntu-20.04` for example)

test/integration/share/libraries/system.rb

@@ -45,7 +45,7 @@ def build_platform_name
     end
   end
 
-  # rubocop:disable Metrics/MethodLength
+  # rubocop:disable Metrics/MethodLength,Metrics/AbcSize,Metrics/CyclomaticComplexity
   def build_platform_release
     case inspec.platform[:name]
     when 'amazon'
@@ -55,6 +55,10 @@ def build_platform_release
       'base-latest'
     when 'gentoo'
       "#{inspec.platform[:release].split('.')[0]}-#{derive_gentoo_init_system}"
+    when 'opensuse'
+      # rubocop:disable Style/NumericLiterals,Layout/LineLength
+      inspec.platform[:release].to_i > 20210101 ? 'tumbleweed' : inspec.platform[:release]
+      # rubocop:enable Style/NumericLiterals,Layout/LineLength
     when 'windows_8.1_pro'
       '8.1'
     when 'windows_server_2019_datacenter'
@@ -63,15 +67,10 @@ def build_platform_release
       inspec.platform[:release]
     end
   end
-  # rubocop:enable Metrics/MethodLength
+  # rubocop:enable Metrics/MethodLength,Metrics/AbcSize,Metrics/CyclomaticComplexity
 
   def derive_gentoo_init_system
-    case inspec.command('systemctl').exist?
-    when true
-      'sysd'
-    else
-      'sysv'
-    end
+    inspec.command('systemctl').exist? ? 'sysd' : 'sysv'
   end
 
   def build_platform_finger