fix: add message to query for errors when more than 12

Author: WillieRuemmele

messages/package_version_create_report.md

@@ -18,3 +18,9 @@ package version creation request ID (starts with 08c)
 # requestIdLong
 
 The ID (starts with 08c) of the package version creation request you want to display.
+
+# truncatedErrors
+
+...
+
+To see all errors, run: sfdx force:data:soql:query -t -q "SELECT Message FROM Package2VersionCreateRequestError WHERE ParentRequest.Id='%s'" -u %s

src/commands/force/package/beta/version/create/report.ts

@@ -18,6 +18,7 @@ const messages = Messages.loadMessages('@salesforce/plugin-packaging', 'package_
 const pvclMessages = Messages.loadMessages('@salesforce/plugin-packaging', 'package_version_create_list');
 const plMessages = Messages.loadMessages('@salesforce/plugin-packaging', 'package_list');
 
+const ERROR_LIMIT = 12;
 export class PackageVersionCreateReportCommand extends SfdxCommand {
   public static readonly description = messages.getMessage('cliDescription');
   public static readonly examples = messages.getMessage('examples').split(os.EOL);
@@ -93,11 +94,22 @@ export class PackageVersionCreateReportCommand extends SfdxCommand {
     if (record.Error?.length > 0) {
       this.ux.log('');
       const errors = [];
-      record.Error.forEach((error: string) => {
+      record.Error.slice(0, ERROR_LIMIT).forEach((error: string) => {
         errors.push(`(${errors.length + 1}) ${error}`);
       });
       this.ux.styledHeader(chalk.red('Errors'));
       this.ux.log(errors.join('\n'));
+
+      // Check if errors were truncated.  If so, inform the user with
+      // instructions on how to retrieve the remaining errors.
+      if (record.Error.length > ERROR_LIMIT) {
+        this.ux.log(
+          messages.getMessage('truncatedErrors', [
+            this.flags.packagecreaterequestid as string,
+            this.hubOrg.getUsername(),
+          ])
+        );
+      }
     }
   }
 }

test/commands/force/package/packageVersionCreateReport.test.ts

@@ -34,6 +34,17 @@ describe('force:package:version:create:report - tests', () => {
       'PropertyController: Invalid type: Schema.Property__c',
       'SampleDataController: Invalid type: Schema.Property__c',
       'SampleDataController: Invalid type: Schema.Broker__c',
+      'PropertyController: Invalid type: Schema.Property__c',
+      'SampleDataController: Invalid type: Schema.Property__c',
+      'SampleDataController: Invalid type: Schema.Broker__c',
+      'PropertyController: Invalid type: Schema.Property__c',
+      'SampleDataController: Invalid type: Schema.Property__c',
+      'SampleDataController: Invalid type: Schema.Broker__c',
+      'PropertyController: Invalid type: Schema.Property__c',
+      'SampleDataController: Invalid type: Schema.Property__c',
+      'SampleDataController: Invalid type: Schema.Broker__c',
+      'SampleDataController: Invalid type: Schema.Broker__c',
+      'SampleDataController: Invalid type: Schema.Broker__c',
     ],
     CreatedDate: '2022-11-03 09:21',
     HasMetadataRemoved: null,
@@ -117,15 +128,27 @@ describe('force:package:version:create:report - tests', () => {
 
       const result = await runCmd(['-i', '08c3i000000fyoVAAQ', '-v', '[email protected]']);
 
-      expect(logStub.callCount).to.equal(2);
+      expect(logStub.callCount).to.equal(3);
       expect(result[0]).to.deep.equal({
         Branch: null,
         CreatedBy: '0053i000001ZIyXXXX',
         CreatedDate: '2022-11-03 09:21',
+        // requires 12+ errors for error truncation message
         Error: [
           'PropertyController: Invalid type: Schema.Property__c',
           'SampleDataController: Invalid type: Schema.Property__c',
           'SampleDataController: Invalid type: Schema.Broker__c',
+          'PropertyController: Invalid type: Schema.Property__c',
+          'SampleDataController: Invalid type: Schema.Property__c',
+          'SampleDataController: Invalid type: Schema.Broker__c',
+          'PropertyController: Invalid type: Schema.Property__c',
+          'SampleDataController: Invalid type: Schema.Property__c',
+          'SampleDataController: Invalid type: Schema.Broker__c',
+          'PropertyController: Invalid type: Schema.Property__c',
+          'SampleDataController: Invalid type: Schema.Property__c',
+          'SampleDataController: Invalid type: Schema.Broker__c',
+          'SampleDataController: Invalid type: Schema.Broker__c',
+          'SampleDataController: Invalid type: Schema.Broker__c',
         ],
         HasMetadataRemoved: null,
         Id: '08c3i000000fylXXXX',
@@ -135,9 +158,15 @@ describe('force:package:version:create:report - tests', () => {
         SubscriberPackageVersionId: null,
         Tag: null,
       });
-      expect(logStub.secondCall.args[0]).to.equal(
+      expect(logStub.secondCall.args[0]).to.include(
         '(1) PropertyController: Invalid type: Schema.Property__c\n(2) SampleDataController: Invalid type: Schema.Property__c\n(3) SampleDataController: Invalid type: Schema.Broker__c'
       );
+      expect(logStub.secondCall.args[0]).to.include(
+        '(11) SampleDataController: Invalid type: Schema.Property__c\n(12) SampleDataController: Invalid type: Schema.Broker__c'
+      );
+      expect(logStub.thirdCall.args[0]).to.deep.equal(
+        '...\n\nTo see all errors, run: sfdx force:data:soql:query -t -q "SELECT Message FROM Package2VersionCreateRequestError WHERE ParentRequest.Id=\'08c3i000000fyoVAAQ\'" -u [email protected]'
+      );
     });
   });
 });