Merge pull request #62 from salesforcecli/phale/W-11644909

fix: add spinner and fix preserve file location msg

Author: WillieRuemmele

messages/package_version_create.md

@@ -303,4 +303,12 @@ The %s value "%s" from the command line or sfdx-project.json is not in the corre
 
 # requestInProgress
 
-Request in progress. Sleeping %s seconds. Will wait a total of %s more seconds before timing out. Current Status=%s.
+Version create.
+
+# packageVersionCreateWaitingStatus
+
+%d minutes remaining until timeout. Create version status: %s
+
+# packageVersionCreateFinalStatus
+
+Create version status: %s

package.json

@@ -10,7 +10,7 @@
     "@salesforce/command": "^5.2.6",
     "@salesforce/core": "^3.26.2",
     "@salesforce/kit": "^1.6.0",
-    "@salesforce/packaging": "^0.0.23",
+    "@salesforce/packaging": "^0.0.27",
     "tslib": "^2",
     "chalk": "^4.1.2"
   },

src/commands/force/package/beta/version/create.ts

@@ -159,11 +159,18 @@ export class PackageVersionCreateCommand extends SfdxCommand {
     // eslint-disable-next-line @typescript-eslint/require-await
     Lifecycle.getInstance().on('in-progress', async (data: PackageVersionCreateReportProgress) => {
       if (data.Status !== Package2VersionStatus.success && data.Status !== Package2VersionStatus.error) {
-        this.ux.log(
-          messages.getMessage('requestInProgress', [frequency.seconds, data.remainingWaitTime.seconds, data.Status])
+        this.ux.setSpinnerStatus(
+          messages.getMessage('packageVersionCreateWaitingStatus', [data.remainingWaitTime.minutes, data.Status])
         );
       }
     });
+    Lifecycle.getInstance().on(
+      'packageVersionCreate:preserveFiles',
+      // eslint-disable-next-line @typescript-eslint/require-await
+      async (data: { location: string; message: string }) => {
+        this.ux.log(messages.getMessage('tempFileLocation', [data.location]));
+      }
+    );
 
     // resolve the package id from the --package flag, first checking if it's an alias, then using the flag (an id), and then looking for the package name from the --path flag
     let packageName: string;
@@ -179,18 +186,18 @@ export class PackageVersionCreateCommand extends SfdxCommand {
     const packageId = getPackageIdFromAlias(packageName, this.project);
 
     const pv = new PackageVersion({ project: this.project, connection: this.hubOrg.getConnection() });
+    this.ux.startSpinner(messages.getMessage('requestInProgress'));
     const result = await pv.create(
       { ...this.flags, ...{ packageId } },
       {
         timeout: this.flags.wait as Duration,
         frequency,
       }
     );
-
+    this.ux.stopSpinner(messages.getMessage('packageVersionCreateFinalStatus', [result.Status]));
     switch (result.Status) {
       case 'Error':
-        this.ux.log(messages.getMessage('unknownError', [result.Error.join('\n')]));
-        break;
+        throw messages.createError('unknownError', [result.Error.join('\n')]);
       case 'Success':
         this.ux.log(
           messages.getMessage(result.Status, [

yarn.lock

@@ -1150,10 +1150,10 @@
     shx "^0.3.3"
     tslib "^2.2.0"
 
-"@salesforce/packaging@^0.0.23":
-  version "0.0.23"
-  resolved "https://registry.yarnpkg.com/@salesforce/packaging/-/packaging-0.0.23.tgz#033cfbd6407fcfdb916b575355773b5210af2d2e"
-  integrity sha512-TbqhfeIsU20In8NJuMeYHCMCNdBU4hbT+uY1/+lLZIdhP4f4dlUkWPGM3Os10f9MW47PPb8gT8+vlPDf5FWbdg==
+"@salesforce/packaging@^0.0.27":
+  version "0.0.27"
+  resolved "https://registry.yarnpkg.com/@salesforce/packaging/-/packaging-0.0.27.tgz#4db9480024288a26f2549e4f3b7a7ddc20e62808"
+  integrity sha512-1hMGLD32zH/VCEik5wLVPXqQ7y6NHwvTsC5uKurCdvqjLjP3NuJQaSTXInaP3uXSttgmsy+XIsDlmp4f3aLtpw==
   dependencies:
     "@salesforce/core" "^3.26.2"
     "@salesforce/kit" "^1.6.0"
@@ -1212,12 +1212,7 @@
   resolved "https://registry.yarnpkg.com/@salesforce/prettier-config/-/prettier-config-0.0.2.tgz#ded39bf7cb75238edc9db6dd093649111350f8bc"
   integrity sha512-KExM355BLbxCW6siGBV7oUOotXvvVp0tAWERgzUkM2FcMb9fWrjwXDrIHc8V0UdDlA3UXtFltDWgN+Yqi+BA/g==
 
-"@salesforce/schemas@^1.0.1", "@salesforce/schemas@^1.1.0":
-  version "1.1.3"
-  resolved "https://registry.yarnpkg.com/@salesforce/schemas/-/schemas-1.1.3.tgz#fce83f55c7557d47b9c814d5d02978ad734300b3"
-  integrity sha512-XWohlOT2oQDqAJH00OXS3f2MGjkwZ6pr4emnnkHSQbg7UdGW0rvGpEnRKqBbDUfZ4K5YKSo9Gj216ZtaP3JLXg==
-
-"@salesforce/schemas@^1.2.0":
+"@salesforce/schemas@^1.0.1", "@salesforce/schemas@^1.1.0", "@salesforce/schemas@^1.2.0":
   version "1.2.0"
   resolved "https://registry.yarnpkg.com/@salesforce/schemas/-/schemas-1.2.0.tgz#3c7ed492e3ee5d9d9fb24a32b5c574893f6648db"
   integrity sha512-76oYf/9Rsn6Yl+awrTQvLaQuRDNX7F3X9ksRiw53OCJdydIF05buX6XLzN0WDWpkCg/asw+lZMuAzbDVS0tBmg==
@@ -2274,9 +2269,9 @@ camelcase@^6.0.0:
   integrity sha512-Gmy6FhYlCY7uOElZUSbxo2UCDH8owEk996gkbrpsgGtrJLM3J7jGxl9Ic7Qwwj4ivOE5AWZWRMecDdF7hqGjFA==
 
 caniuse-lite@^1.0.30001370:
-  version "1.0.30001382"
-  resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001382.tgz#4d37f0d0b6fffb826c8e5e1c0f4bf8ce592db949"
-  integrity sha512-2rtJwDmSZ716Pxm1wCtbPvHtbDWAreTPxXbkc5RkKglow3Ig/4GNGazDI9/BVnXbG/wnv6r3B5FEbkfg9OcTGg==
+  version "1.0.30001383"
+  resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001383.tgz#aecf317ccd940690725ae3ae4f28293c5fb8050e"
+  integrity sha512-swMpEoTp5vDoGBZsYZX7L7nXHe6dsHxi9o6/LKf/f0LukVtnrxly5GVb/fWdCDTqi/yw6Km6tiJ0pmBacm0gbg==
 
 capital-case@^1.0.4:
   version "1.0.4"
@@ -2788,14 +2783,14 @@ convert-source-map@^1.7.0:
     safe-buffer "~5.1.1"
 
 core-js-pure@^3.20.2:
-  version "3.24.1"
-  resolved "https://registry.yarnpkg.com/core-js-pure/-/core-js-pure-3.24.1.tgz#8839dde5da545521bf282feb7dc6d0b425f39fd3"
-  integrity sha512-r1nJk41QLLPyozHUUPmILCEMtMw24NG4oWK6RbsDdjzQgg9ZvrUsPBj1MnG0wXXp1DCDU6j+wUvEmBSrtRbLXg==
+  version "3.25.0"
+  resolved "https://registry.yarnpkg.com/core-js-pure/-/core-js-pure-3.25.0.tgz#f8d1f176ff29abbfeb610110de891d5ae5a361d4"
+  integrity sha512-IeHpLwk3uoci37yoI2Laty59+YqH9x5uR65/yiA0ARAJrTrN4YU0rmauLWfvqOuk77SlNJXj2rM6oT/dBD87+A==
 
 core-js@^3.6.4:
-  version "3.24.1"
-  resolved "https://registry.yarnpkg.com/core-js/-/core-js-3.24.1.tgz#cf7724d41724154010a6576b7b57d94c5d66e64f"
-  integrity sha512-0QTBSYSUZ6Gq21utGzkfITDylE8jWC9Ne1D2MrhvlsZBI1x39OdDIVbzSqtgMndIy6BlHxBXpMGqzZmnztg2rg==
+  version "3.25.0"
+  resolved "https://registry.yarnpkg.com/core-js/-/core-js-3.25.0.tgz#be71d9e0dd648ffd70c44a7ec2319d039357eceb"
+  integrity sha512-CVU1xvJEfJGhyCpBrzzzU1kjCfgsGUxhEvwUV2e/cOedYWHdmluamx+knDnmhqALddMG16fZvIqvs9aijsHHaA==
 
 [email protected]:
   version "1.0.2"
@@ -3197,9 +3192,9 @@ ejs@^3.1.6, ejs@^3.1.8:
     jake "^10.8.5"
 
 electron-to-chromium@^1.4.202:
-  version "1.4.228"
-  resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.228.tgz#3baff13cf54198c2045f9bdd8b64db93aafd7f33"
-  integrity sha512-XfDHCvou7CsDMlFwb0WZ1tWmW48e7Sn7VBRyPfZsZZila9esRsJl1trO+OqDNV97GggFSt0ISbWslKXfQkG//g==
+  version "1.4.230"
+  resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.230.tgz#666909fdf5765acb1348b69752ee9955dc1664b7"
+  integrity sha512-3pwjAK0qHSDN9+YAF4fJknsSruP7mpjdWzUSruIJD/JCH77pEh0SorEyb3xVaKkfwk2tzjOt2D8scJ0KAdfXLA==
 
 emoji-regex@^8.0.0:
   version "8.0.0"