Replace atomic operations with Once in backend/util #4503
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chain-Fox
force-pushed
the
fix-race-condition2
branch
2 times, most recently
from
441c36c to
841f8e1
Compare
Chain-Fox
force-pushed
the
fix-race-condition2
branch
from
841f8e1 to
cbac5f7
Compare
Chain-Fox
changed the title
Contributor
|
Automated PRs are not appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4502
The fix is to use
OnceLockOnce and atomic variables (for older Rust versions) to replace the original two atomic variables.OnceLock guarantees the hash can only be initialized once.
This reduces the race condition and provides a slightly better performance.
I also add a test to it to ensure the result before and after patch is consistent.