give Pointer::into_parts a more scary name and offer a safer alternative

RalfJung · RalfJung · commit 6e635990da9c · 2025-06-29T00:16:19.000+02:00
diff --git a/src/common.rs b/src/common.rs
@@ -261,7 +261,7 @@ impl<'gcc, 'tcx> ConstCodegenMethods for CodegenCx<'gcc, 'tcx> {
                 }
             }
             Scalar::Ptr(ptr, _size) => {
-                let (prov, offset) = ptr.into_parts(); // we know the `offset` is relative
+                let (prov, offset) = ptr.prov_and_relative_offset();
                 let alloc_id = prov.alloc_id();
                 let base_addr = match self.tcx.global_alloc(alloc_id) {
                     GlobalAlloc::Memory(alloc) => {

Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ impl<'gcc, 'tcx> ConstCodegenMethods for CodegenCx<'gcc, 'tcx> {`
`261`	`261`	`}`
`262`	`262`	`}`
`263`	`263`	`Scalar::Ptr(ptr, _size) => {`
`264`		- let (prov, offset) = ptr.into_parts(); // we know the `offset` is relative
	`264`	`+ let (prov, offset) = ptr.prov_and_relative_offset();`
`265`	`265`	`let alloc_id = prov.alloc_id();`
`266`	`266`	`let base_addr = match self.tcx.global_alloc(alloc_id) {`
`267`	`267`	`GlobalAlloc::Memory(alloc) => {`