From b7d6a429b5abd50fa62e50c72117a8387e43c032 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Fri, 27 May 2022 22:21:41 +0200 Subject: [PATCH 1/3] Add "arrow-parens" eslint rule --- src/librustdoc/html/static/.eslintrc.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/librustdoc/html/static/.eslintrc.js b/src/librustdoc/html/static/.eslintrc.js index 7afd09b34d30d..3ad7f4d9e064d 100644 --- a/src/librustdoc/html/static/.eslintrc.js +++ b/src/librustdoc/html/static/.eslintrc.js @@ -54,5 +54,6 @@ module.exports = { "comma-style": ["error", "last"], "max-len": ["error", { "code": 100, "tabWidth": 4 }], "eol-last": ["error", "always"], + "arrow-parens": ["error", "as-needed"], } }; From 3741a88ad7d6d8b636e997ec7ebe6739718ebddf Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Fri, 27 May 2022 22:22:22 +0200 Subject: [PATCH 2/3] Add "no-unused-vars" eslint rule --- src/librustdoc/html/static/.eslintrc.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/librustdoc/html/static/.eslintrc.js b/src/librustdoc/html/static/.eslintrc.js index 3ad7f4d9e064d..5a79610b73633 100644 --- a/src/librustdoc/html/static/.eslintrc.js +++ b/src/librustdoc/html/static/.eslintrc.js @@ -55,5 +55,12 @@ module.exports = { "max-len": ["error", { "code": 100, "tabWidth": 4 }], "eol-last": ["error", "always"], "arrow-parens": ["error", "as-needed"], + "no-unused-vars": [ + "error", + { + "argsIgnorePattern": "^_", + "varsIgnorePattern": "^_" + } + ], } }; From 334f12c28e0aec80f29b43ad289362c484269a8d Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Fri, 27 May 2022 22:30:19 +0200 Subject: [PATCH 3/3] Add "eqeqeq" eslint rule --- src/librustdoc/html/static/.eslintrc.js | 1 + src/librustdoc/html/static/js/main.js | 4 ++-- src/librustdoc/html/static/js/search.js | 8 ++++---- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/librustdoc/html/static/.eslintrc.js b/src/librustdoc/html/static/.eslintrc.js index 5a79610b73633..997def1657fa0 100644 --- a/src/librustdoc/html/static/.eslintrc.js +++ b/src/librustdoc/html/static/.eslintrc.js @@ -62,5 +62,6 @@ module.exports = { "varsIgnorePattern": "^_" } ], + "eqeqeq": "error", } }; diff --git a/src/librustdoc/html/static/js/main.js b/src/librustdoc/html/static/js/main.js index 0fbc2d0e33c90..548aeedd03384 100644 --- a/src/librustdoc/html/static/js/main.js +++ b/src/librustdoc/html/static/js/main.js @@ -97,12 +97,12 @@ function showMain() { // // So I guess you could say things are getting pretty interoperable. function getVirtualKey(ev) { - if ("key" in ev && typeof ev.key != "undefined") { + if ("key" in ev && typeof ev.key !== "undefined") { return ev.key; } const c = ev.charCode || ev.keyCode; - if (c == 27) { + if (c === 27) { return "Escape"; } return String.fromCharCode(c); diff --git a/src/librustdoc/html/static/js/search.js b/src/librustdoc/html/static/js/search.js index c784d69dcd66f..c726aeeff4729 100644 --- a/src/librustdoc/html/static/js/search.js +++ b/src/librustdoc/html/static/js/search.js @@ -70,7 +70,7 @@ function printTab(nb) { }); if (foundCurrentTab && foundCurrentResultSet) { searchState.currentTab = nb; - } else if (nb != 0) { + } else if (nb !== 0) { printTab(0); } } @@ -200,7 +200,7 @@ function initSearch(rawSearchIndex) { * @return {boolean} */ function isPathStart(parserState) { - return parserState.userQuery.slice(parserState.pos, parserState.pos + 2) == "::"; + return parserState.userQuery.slice(parserState.pos, parserState.pos + 2) === "::"; } /** @@ -211,7 +211,7 @@ function initSearch(rawSearchIndex) { * @return {boolean} */ function isReturnArrow(parserState) { - return parserState.userQuery.slice(parserState.pos, parserState.pos + 2) == "->"; + return parserState.userQuery.slice(parserState.pos, parserState.pos + 2) === "->"; } /** @@ -1726,7 +1726,7 @@ function initSearch(rawSearchIndex) { crates = " in "; }