From eadfe0e3c9b55ec48637d5cdae36eca7421a8159 Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Sat, 4 Jan 2014 12:21:46 -0800 Subject: [PATCH] Don't abort the process in native::start If the main closure failed, then the `exit_code` variable would still be `None`, and the `unwrap()` was failing (triggering a process abort). This changes the `unwrap()` to an `unwrap_or()` in order to prevent process abort and detect when the native task failed. --- src/libnative/lib.rs | 3 ++- src/test/run-fail/native-failure.rs | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 src/test/run-fail/native-failure.rs diff --git a/src/libnative/lib.rs b/src/libnative/lib.rs index b3b83fda59956..9c30e94194dd2 100644 --- a/src/libnative/lib.rs +++ b/src/libnative/lib.rs @@ -73,7 +73,8 @@ pub fn start(argc: int, argv: **u8, main: proc()) -> int { exit_code = Some(run(main.take_unwrap())); }); unsafe { rt::cleanup(); } - return exit_code.unwrap(); + // If the exit code wasn't set, then the task block must have failed. + return exit_code.unwrap_or(rt::DEFAULT_ERROR_CODE); } /// Executes a procedure on the current thread in a Rust task context. diff --git a/src/test/run-fail/native-failure.rs b/src/test/run-fail/native-failure.rs new file mode 100644 index 0000000000000..11aac2b0fa718 --- /dev/null +++ b/src/test/run-fail/native-failure.rs @@ -0,0 +1,22 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// error-pattern:explicit failure + +#[no_uv]; + +extern mod native; + +#[start] +fn start(argc: int, argv: **u8) -> int { + do native::start(argc, argv) { + fail!(); + } +}