Merge pull request #657 from tisonkun/relax-feature-flag

Relax feature flag for value's std_support

Author: KodrAus

.github/workflows/main.yml

@@ -47,6 +47,7 @@ jobs:
     - run: cargo test --verbose --features kv
     - run: cargo test --verbose --features kv_sval
     - run: cargo test --verbose --features kv_serde
+    - run: cargo test --verbose --features kv,std
     - run: cargo test --verbose --features "kv kv_std kv_sval kv_serde"
     - run: cargo run --verbose --manifest-path test_max_level_features/Cargo.toml
     - run: cargo run --verbose --manifest-path test_max_level_features/Cargo.toml --release

src/kv/value.rs

@@ -385,7 +385,7 @@ impl<'v> Value<'v> {
     }
 }
 
-#[cfg(feature = "kv_std")]
+#[cfg(feature = "std")]
 mod std_support {
     use std::borrow::Cow;
     use std::rc::Rc;
@@ -432,20 +432,29 @@ mod std_support {
         }
     }
 
-    impl<'v> Value<'v> {
-        /// Try to convert this value into a string.
-        pub fn to_cow_str(&self) -> Option<Cow<'v, str>> {
-            self.inner.to_str()
-        }
-    }
-
     impl<'v> From<&'v String> for Value<'v> {
         fn from(v: &'v String) -> Self {
             Value::from(&**v)
         }
     }
 }
 
+#[cfg(all(feature = "std", feature = "value-bag"))]
+impl<'v> Value<'v> {
+    /// Try to convert this value into a string.
+    pub fn to_cow_str(&self) -> Option<std::borrow::Cow<'v, str>> {
+        self.inner.to_str()
+    }
+}
+
+#[cfg(all(feature = "std", not(feature = "value-bag")))]
+impl<'v> Value<'v> {
+    /// Try to convert this value into a string.
+    pub fn to_cow_str(&self) -> Option<std::borrow::Cow<'v, str>> {
+        self.inner.to_borrowed_str().map(std::borrow::Cow::Borrowed)
+    }
+}
+
 /// A visitor for a [`Value`].
 ///
 /// Also see [`Value`'s documentation on seralization]. Value visitors are a simple alternative