Skip to content

Commit 372daf1

Browse files
authored
Stop specifying the gem version of strscan in benchmarks. (#113)
## [Why] Because benchmarks are broken when new strscan is released. https://github.com/ruby/rexml/actions/runs/7825513689/job/21349811563 ``` RUBYLIB= BUNDLER_ORIG_RUBYLIB= /opt/hostedtoolcache/Ruby/3.3.0/x64/bin/ruby -v -S benchmark-driver /home/runner/work/rexml/rexml/benchmark/parse.yaml ruby 3.3.0 (2023-12-25 revision 5124f9ac75) [x86_64-linux] Calculating ------------------------------------- rexml 3.2.6 master 3.2.6(YJIT) master(YJIT) /opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/rubygems/dependency.rb:315:in `to_specs': Could not find 'strscan' (= 3.0.9) - did find: [strscan-3.1.0,strscan-3.0.7] (Gem::MissingSpecVersionError) Checked in 'GEM_PATH=/home/runner/.local/share/gem/ruby/3.3.0:/opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/gems/3.3.0' , execute `gem env` for more information from /opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/rubygems/dependency.rb:325:in `to_spec' from /opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/rubygems/core_ext/kernel_gem.rb:56:in `gem' from /tmp/benchmark_driver-20240208-1790-njwk6u.rb:1:in `<main>' ```
1 parent fc6cad5 commit 372daf1

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

benchmark/parse.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ contexts:
55
require: false
66
prelude: require 'rexml'
77
- name: master
8-
gems:
9-
strscan: 3.0.9
108
prelude: |
119
$LOAD_PATH.unshift(File.expand_path("lib"))
1210
require 'rexml'
@@ -18,8 +16,6 @@ contexts:
1816
require 'rexml'
1917
RubyVM::YJIT.enable
2018
- name: master(YJIT)
21-
gems:
22-
strscan: 3.0.9
2319
prelude: |
2420
$LOAD_PATH.unshift(File.expand_path("lib"))
2521
require 'rexml'

0 commit comments

Comments
 (0)