Skip to content

Aborting rake execution needlessly dumps a backtrace #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
booch opened this issue Aug 30, 2018 · 3 comments
Open

Aborting rake execution needlessly dumps a backtrace #272

booch opened this issue Aug 30, 2018 · 3 comments

Comments

@booch
Copy link

booch commented Aug 30, 2018

When aborting rake with Ctrl+C, it outputs rake aborted! then dumps a long backtrace. This seems unnecessary, as aborting isn't really an unexpected outcome of pressing Ctrl+C (or sending an INT signal).

I'd like to propose catching the Interrupt exception and exiting cleanly (with an exit code of 1). We can still print the backtrace if the --trace option is used.

I can submit a pull request, if this seems reasonable.

@SwagDevOps
Copy link

Exit code, should be more specific than 1: http://tldp.org/LDP/abs/html/exitcodes.html

sleep infinity
# Ctl-C
echo $?
# 130

@mateusdeap
Copy link

Is this something we still want to look at? I can also submit a PR for this if needed.

@SwagDevOps
Copy link

Yes! I'm still interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@booch @SwagDevOps @mateusdeap and others