From 0dec1d971701db1e5e65f59ce9c8bec1b5f6f3e2 Mon Sep 17 00:00:00 2001 From: Jerry Cheung Date: Fri, 8 Jan 2016 11:41:25 -0800 Subject: [PATCH 1/6] fix multiline blocks --- lib/net/ldap.rb | 8 ++++---- lib/net/ldap/auth_adapter/gss_spnego.rb | 2 -- lib/net/ldap/auth_adapter/sasl.rb | 4 ++-- lib/net/ldap/connection.rb | 8 ++++---- lib/net/ldap/entry.rb | 4 ++-- lib/net/ldap/filter.rb | 4 ++-- lib/net/snmp.rb | 12 ++++++------ test/test_filter.rb | 4 ++-- test/test_snmp.rb | 8 ++++---- 9 files changed, 26 insertions(+), 28 deletions(-) diff --git a/lib/net/ldap.rb b/lib/net/ldap.rb index 455bbd6e..6dbda5a3 100644 --- a/lib/net/ldap.rb +++ b/lib/net/ldap.rb @@ -775,10 +775,10 @@ def search(args = {}) instrument "search.net_ldap", args do |payload| @result = use_connection(args) do |conn| - conn.search(args) { |entry| + conn.search(args) do |entry| result_set << entry if result_set yield entry if block_given? - } + end end if return_result_set @@ -917,7 +917,7 @@ def bind(auth = @auth) # end def bind_as(args = {}) result = false - open { |me| + open do |me| rs = search args if rs and rs.first and dn = rs.first.dn password = args[:password] @@ -925,7 +925,7 @@ def bind_as(args = {}) result = rs if bind(:method => :simple, :username => dn, :password => password) end - } + end result end diff --git a/lib/net/ldap/auth_adapter/gss_spnego.rb b/lib/net/ldap/auth_adapter/gss_spnego.rb index b4fec88c..fffdc04f 100644 --- a/lib/net/ldap/auth_adapter/gss_spnego.rb +++ b/lib/net/ldap/auth_adapter/gss_spnego.rb @@ -22,12 +22,10 @@ def bind(auth) user, psw = [auth[:username] || auth[:dn], auth[:password]] raise Net::LDAP::BindingInformationInvalidError, "Invalid binding information" unless (user && psw) - nego = proc { |challenge| t2_msg = NTLM::Message.parse(challenge) t3_msg = t2_msg.response({ :user => user, :password => psw }, { :ntlmv2 => true }) t3_msg.serialize - } Net::LDAP::AuthAdapter::Sasl.new(@connection).bind \ :method => :sasl, diff --git a/lib/net/ldap/auth_adapter/sasl.rb b/lib/net/ldap/auth_adapter/sasl.rb index fa7315b5..ebbe4e63 100644 --- a/lib/net/ldap/auth_adapter/sasl.rb +++ b/lib/net/ldap/auth_adapter/sasl.rb @@ -33,7 +33,7 @@ def bind(auth) message_id = @connection.next_msgid n = 0 - loop { + loop do sasl = [mech.to_ber, cred.to_ber].to_ber_contextspecific(3) request = [ Net::LDAP::Connection::LdapVersion.to_ber, "".to_ber, sasl @@ -50,7 +50,7 @@ def bind(auth) raise Net::LDAP::SASLChallengeOverflowError, "sasl-challenge overflow" if ((n += 1) > MaxSaslChallenges) cred = chall.call(pdu.result_server_sasl_creds) - } + end raise Net::LDAP::SASLChallengeOverflowError, "why are we here?" end diff --git a/lib/net/ldap/connection.rb b/lib/net/ldap/connection.rb index 67757323..0064cbda 100644 --- a/lib/net/ldap/connection.rb +++ b/lib/net/ldap/connection.rb @@ -500,14 +500,14 @@ def search(args = nil) def self.modify_ops(operations) ops = [] if operations - operations.each { |op, attrib, values| + operations.each do |op, attrib, values| # TODO, fix the following line, which gives a bogus error if the # opcode is invalid. op_ber = MODIFY_OPERATIONS[op.to_sym].to_ber_enumerated values = [ values ].flatten.map { |v| v.to_ber if v }.to_ber_set values = [ attrib.to_s.to_ber, values ].to_ber_sequence ops << [ op_ber, values ].to_ber - } + end end ops end @@ -594,9 +594,9 @@ def password_modify(args) def add(args) add_dn = args[:dn] or raise Net::LDAP::EmptyDNError, "Unable to add empty DN" add_attrs = [] - a = args[:attributes] and a.each { |k, v| + a = args[:attributes] and a.each do |k, v| add_attrs << [ k.to_s.to_ber, Array(v).map { |m| m.to_ber}.to_ber_set ].to_ber_sequence - } + end message_id = next_msgid request = [add_dn.to_ber, add_attrs.to_ber_sequence].to_ber_appsequence(Net::LDAP::PDU::AddRequest) diff --git a/lib/net/ldap/entry.rb b/lib/net/ldap/entry.rb index c2615268..f46912ba 100644 --- a/lib/net/ldap/entry.rb +++ b/lib/net/ldap/entry.rb @@ -141,10 +141,10 @@ def attribute_names # (possibly empty) \Array of data values. def each # :yields: attribute-name, data-values-array if block_given? - attribute_names.each {|a| + attribute_names.each do|a| attr_name,values = a,self[a] yield attr_name, values - } + end end end alias_method :each_attribute, :each diff --git a/lib/net/ldap/filter.rb b/lib/net/ldap/filter.rb index aad84f83..d4542e3d 100644 --- a/lib/net/ldap/filter.rb +++ b/lib/net/ldap/filter.rb @@ -287,7 +287,7 @@ def parse_ber(ber) when 0xa4 # context-specific constructed 4, "substring" str = "" final = false - ber.last.each { |b| + ber.last.each do |b| case b.ber_identifier when 0x80 # context-specific primitive 0, SubstringFilter "initial" raise Net::LDAP::SubstringFilterError, "Unrecognized substring filter; bad initial value." if str.length > 0 @@ -298,7 +298,7 @@ def parse_ber(ber) str += "*#{escape(b)}" final = true end - } + end str += "*" unless final eq(ber.first.to_s, str) when 0xa5 # context-specific constructed 5, "greaterOrEqual" diff --git a/lib/net/snmp.rb b/lib/net/snmp.rb index 501df851..fe7a2899 100644 --- a/lib/net/snmp.rb +++ b/lib/net/snmp.rb @@ -227,9 +227,9 @@ def pdu_to_ber_string error_status.to_ber, error_index.to_ber, [ - @variables.map {|n,v| + @variables.map do|n,v| [n.to_ber_oid, Net::BER::BerIdentifiedNull.new.to_ber].to_ber_sequence - } + end ].to_ber_sequence ].to_ber_contextspecific(0) when :get_next_request @@ -238,9 +238,9 @@ def pdu_to_ber_string error_status.to_ber, error_index.to_ber, [ - @variables.map {|n,v| + @variables.map do|n,v| [n.to_ber_oid, Net::BER::BerIdentifiedNull.new.to_ber].to_ber_sequence - } + end ].to_ber_sequence ].to_ber_contextspecific(1) when :get_response @@ -249,9 +249,9 @@ def pdu_to_ber_string error_status.to_ber, error_index.to_ber, [ - @variables.map {|n,v| + @variables.map do|n,v| [n.to_ber_oid, v.to_ber].to_ber_sequence - } + end ].to_ber_sequence ].to_ber_contextspecific(2) else diff --git a/test/test_filter.rb b/test/test_filter.rb index 2bcccd92..dd4577eb 100644 --- a/test/test_filter.rb +++ b/test/test_filter.rb @@ -13,11 +13,11 @@ def test_invalid_filter_string end def test_invalid_filter - assert_raises(Net::LDAP::OperatorError) { + assert_raises(Net::LDAP::OperatorError) do # This test exists to prove that our constructor blocks unknown filter # types. All filters must be constructed using helpers. Filter.__send__(:new, :xx, nil, nil) - } + end end def test_to_s diff --git a/test/test_snmp.rb b/test/test_snmp.rb index fe1ee168..6a809a80 100644 --- a/test/test_snmp.rb +++ b/test/test_snmp.rb @@ -16,9 +16,9 @@ def self.raw_string(s) def test_invalid_packet data = "xxxx" - assert_raise(Net::BER::BerError) { + assert_raise(Net::BER::BerError) do ary = data.read_ber(Net::SNMP::AsnSyntax) - } + end end # The method String#read_ber! added by Net::BER consumes a well-formed BER @@ -40,9 +40,9 @@ def _test_consume_string end def test_weird_packet - assert_raise(Net::SnmpPdu::Error) { + assert_raise(Net::SnmpPdu::Error) do Net::SnmpPdu.parse("aaaaaaaaaaaaaa") - } + end end def test_get_request From 63d7bbb3198445bf3509aebc7e7841661a5b2a7a Mon Sep 17 00:00:00 2001 From: Jerry Cheung Date: Fri, 8 Jan 2016 11:41:35 -0800 Subject: [PATCH 2/6] fix trailing underscore --- test/integration/test_search.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integration/test_search.rb b/test/integration/test_search.rb index b56052ce..96f9ff42 100644 --- a/test/integration/test_search.rb +++ b/test/integration/test_search.rb @@ -57,7 +57,7 @@ def test_search_timeout entries << entry end - payload, _ = events.pop + payload, = events.pop assert_equal 5, payload[:time] assert_equal entries, result end From 17e2fe6ed983f1ccd12b32d33022868dd5b11893 Mon Sep 17 00:00:00 2001 From: Jerry Cheung Date: Fri, 8 Jan 2016 11:41:48 -0800 Subject: [PATCH 3/6] fix multiline block --- lib/net/ldap/auth_adapter/gss_spnego.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/net/ldap/auth_adapter/gss_spnego.rb b/lib/net/ldap/auth_adapter/gss_spnego.rb index fffdc04f..9f773454 100644 --- a/lib/net/ldap/auth_adapter/gss_spnego.rb +++ b/lib/net/ldap/auth_adapter/gss_spnego.rb @@ -22,10 +22,12 @@ def bind(auth) user, psw = [auth[:username] || auth[:dn], auth[:password]] raise Net::LDAP::BindingInformationInvalidError, "Invalid binding information" unless (user && psw) + nego = proc do |challenge| t2_msg = NTLM::Message.parse(challenge) t3_msg = t2_msg.response({ :user => user, :password => psw }, { :ntlmv2 => true }) t3_msg.serialize + end Net::LDAP::AuthAdapter::Sasl.new(@connection).bind \ :method => :sasl, From 2702b89bac61d26440a17794297c873acd9044fd Mon Sep 17 00:00:00 2001 From: Jerry Cheung Date: Fri, 8 Jan 2016 11:46:41 -0800 Subject: [PATCH 4/6] fix multiline blocks --- test/test_ldif.rb | 8 ++++---- testserver/ldapserver.rb | 13 ++++++------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/test/test_ldif.rb b/test/test_ldif.rb index 988c3155..8181671c 100644 --- a/test/test_ldif.rb +++ b/test/test_ldif.rb @@ -68,10 +68,10 @@ def test_ldif_with_base64_dn_and_continuation_lines # TODO, INADEQUATE. We need some more tests # to verify the content. def test_ldif - File.open(TestLdifFilename, "r") {|f| + File.open(TestLdifFilename, "r") do |f| ds = Net::LDAP::Dataset::read_ldif(f) assert_equal(13, ds.length) - } + end end # Must test folded lines and base64-encoded lines as well as normal ones. @@ -84,13 +84,13 @@ def test_to_ldif entries = data.lines.grep(/^dn:\s*/) { $'.chomp } dn_entries = entries.dup - ds = Net::LDAP::Dataset::read_ldif(io) { |type, value| + ds = Net::LDAP::Dataset::read_ldif(io) do |type, value| case type when :dn assert_equal(dn_entries.first, value) dn_entries.shift end - } + end assert_equal(entries.size, ds.size) assert_equal(entries.sort, ds.to_ldif.grep(/^dn:\s*/) { $'.chomp }) end diff --git a/testserver/ldapserver.rb b/testserver/ldapserver.rb index eba130ce..24578ffb 100644 --- a/testserver/ldapserver.rb +++ b/testserver/ldapserver.rb @@ -133,21 +133,21 @@ def handle_search_request pdu # TODO, what if this returns nil? filter = Net::LDAP::Filter.parse_ldap_filter( filters ) - $ldif.each {|dn, entry| + $ldif.each do |dn, entry| if filter.match( entry ) attrs = [] - entry.each {|k, v| + entry.each do |k, v| if requested_attrs == :all or requested_attrs.include?(k.downcase) attrvals = v.map {|v1| v1.to_ber}.to_ber_set attrs << [k.to_ber, attrvals].to_ber_sequence end - } + end appseq = [dn.to_ber, attrs.to_ber_sequence].to_ber_appsequence(4) pkt = [msgid.to_ber, appseq].to_ber_sequence send_data pkt end - } + end send_ldap_response 5, pdu[0].to_i, 0, "", "Was that what you wanted?" @@ -201,10 +201,9 @@ def load_test_data require 'net/ldap' - EventMachine.run { + EventMachine.run do $logger.info "starting LDAP server on 127.0.0.1 port 3890" EventMachine.start_server "127.0.0.1", 3890, LdapServer EventMachine.add_periodic_timer 60, proc {$logger.info "heartbeat"} - } + end end - From defcc866c40a0439f498cd3bfdb965870e19d7c2 Mon Sep 17 00:00:00 2001 From: Jerry Cheung Date: Fri, 8 Jan 2016 11:53:54 -0800 Subject: [PATCH 5/6] add explicit exceptions for this project --- .rubocop.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index 85ffa202..084ca199 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -3,3 +3,12 @@ inherit_from: .rubocop_todo.yml AllCops: Exclude: - 'pkg/**/*' + +Style/ExtraSpacing: + Enabled: false + +Lint/AssignmentInCondition: + Enabled: false + +Style/ParallelAssignment: + Enabled: false From 5a06857f8adfff1d63477a455b765389264a0f1a Mon Sep 17 00:00:00 2001 From: Jerry Cheung Date: Fri, 8 Jan 2016 11:54:06 -0800 Subject: [PATCH 6/6] regenerate rubocop_todo --- .rubocop_todo.yml | 448 +++++++++++++++++++++++++++++++++------------- 1 file changed, 323 insertions(+), 125 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 5a5dcbc7..4c6c68d2 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,43 +1,61 @@ -# This configuration was generated by `rubocop --auto-gen-config` -# on 2014-12-19 15:32:44 +1100 using RuboCop version 0.28.0. +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2016-01-08 11:47:42 -0800 using RuboCop version 0.35.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 12 -# Configuration parameters: AllowSafeAssignment. -Lint/AssignmentInCondition: - Enabled: false - # Offense count: 1 -# Configuration parameters: AlignWith, SupportedStyles. +# Cop supports --auto-correct. +# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect. Lint/EndAlignment: Enabled: false +# Offense count: 1 +Lint/NonLocalExitFromIterator: + Exclude: + - 'lib/net/ldap/connection.rb' + # Offense count: 1 Lint/RescueException: - Enabled: false + Exclude: + - 'lib/net/ldap/pdu.rb' # Offense count: 1 Lint/ShadowingOuterLocalVariable: - Enabled: false + Exclude: + - 'lib/net/ldap/instrumentation.rb' -# Offense count: 9 +# Offense count: 10 # Cop supports --auto-correct. +# Configuration parameters: IgnoreEmptyBlocks. Lint/UnusedBlockArgument: - Enabled: false + Exclude: + - 'lib/net/ldap.rb' + - 'lib/net/snmp.rb' + - 'test/support/vm/openldap/Vagrantfile' # Offense count: 3 # Cop supports --auto-correct. +# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. Lint/UnusedMethodArgument: - Enabled: false + Exclude: + - 'lib/net/ldap/entry.rb' + - 'lib/net/ldap/pdu.rb' + - 'test/test_search.rb' -# Offense count: 7 +# Offense count: 9 Lint/UselessAssignment: - Enabled: false - -# Offense count: 47 + Exclude: + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/password.rb' + - 'test/integration/test_add.rb' + - 'test/test_ldap_connection.rb' + - 'test/test_search.rb' + - 'test/test_snmp.rb' + +# Offense count: 48 Metrics/AbcSize: Max: 114 @@ -45,16 +63,16 @@ Metrics/AbcSize: Metrics/BlockNesting: Max: 4 -# Offense count: 9 +# Offense count: 10 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 470 + Max: 423 -# Offense count: 20 +# Offense count: 21 Metrics/CyclomaticComplexity: Max: 41 -# Offense count: 193 +# Offense count: 229 # Configuration parameters: AllowURI, URISchemes. Metrics/LineLength: Max: 360 @@ -64,54 +82,76 @@ Metrics/LineLength: Metrics/MethodLength: Max: 130 +# Offense count: 1 +# Configuration parameters: CountComments. +Metrics/ModuleLength: + Max: 104 + # Offense count: 13 Metrics/PerceivedComplexity: - Max: 36 + Max: 37 # Offense count: 1 Style/AccessorMethodName: - Enabled: false + Exclude: + - 'lib/net/ldap.rb' # Offense count: 4 # Cop supports --auto-correct. Style/AlignArray: - Enabled: false + Exclude: + - 'lib/net/ldap.rb' + - 'lib/net/ldap/auth_adapter/sasl.rb' + - 'lib/net/ldap/connection.rb' -# Offense count: 3 +# Offense count: 10 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. Style/AlignParameters: - Enabled: false + Exclude: + - 'test/ber/test_ber.rb' + - 'test/integration/test_ber.rb' + - 'test/integration/test_bind.rb' + - 'test/integration/test_password_modify.rb' -# Offense count: 36 +# Offense count: 37 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. Style/AndOr: - Enabled: false + Exclude: + - 'lib/net/ber/ber_parser.rb' + - 'lib/net/ldap.rb' + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/dataset.rb' + - 'lib/net/ldap/filter.rb' + - 'lib/net/ldap/pdu.rb' + - 'testserver/ldapserver.rb' # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. Style/BarePercentLiterals: - Enabled: false + Exclude: + - 'test/test_entry.rb' # Offense count: 1 # Cop supports --auto-correct. Style/BlockComments: - Enabled: false + Exclude: + - 'test/test_rename.rb' -# Offense count: 20 -# Cop supports --auto-correct. -Style/Blocks: - Enabled: false - -# Offense count: 2 +# Offense count: 9 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. Style/BracesAroundHashParameters: - Enabled: false + Exclude: + - 'lib/net/ldap/auth_adapter/gss_spnego.rb' + - 'lib/net/snmp.rb' + - 'test/test_auth_adapter.rb' + - 'test/test_ldap_connection.rb' # Offense count: 4 +# Cop supports --auto-correct. # Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep. Style/CaseIndentation: Enabled: false @@ -119,41 +159,82 @@ Style/CaseIndentation: # Offense count: 4 # Cop supports --auto-correct. Style/CharacterLiteral: - Enabled: false + Exclude: + - 'lib/net/ldap/dataset.rb' + - 'lib/net/ldap/entry.rb' + +# Offense count: 1 +Style/ClassAndModuleCamelCase: + Exclude: + - 'lib/net/ldap/auth_adapter/gss_spnego.rb' -# Offense count: 22 +# Offense count: 23 # Configuration parameters: EnforcedStyle, SupportedStyles. Style/ClassAndModuleChildren: Enabled: false -# Offense count: 1 +# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. Style/ClassCheck: - Enabled: false + Exclude: + - 'lib/net/ber/core_ext/array.rb' + - 'lib/net/ldap/error.rb' # Offense count: 13 # Cop supports --auto-correct. Style/ColonMethodCall: - Enabled: false + Exclude: + - 'test/test_ldif.rb' + - 'test/test_ssl_ber.rb' -# Offense count: 2 +# Offense count: 1 +# Cop supports --auto-correct. # Configuration parameters: Keywords. Style/CommentAnnotation: - Enabled: false + Exclude: + - 'lib/net/ber.rb' -# Offense count: 86 +# Offense count: 88 Style/ConstantName: - Enabled: false + Exclude: + - 'lib/net/ldap.rb' + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/filter.rb' + - 'lib/net/ldap/pdu.rb' + - 'lib/net/snmp.rb' + - 'test/test_ldif.rb' + - 'testserver/ldapserver.rb' # Offense count: 18 # Cop supports --auto-correct. Style/DeprecatedHashMethods: - Enabled: false + Exclude: + - 'lib/net/snmp.rb' + - 'test/test_ldap_connection.rb' + - 'test/test_ldif.rb' + - 'test/test_search.rb' -# Offense count: 46 +# Offense count: 21 +# Configuration parameters: Exclude. Style/Documentation: - Enabled: false + Exclude: + - 'spec/**/*' + - 'test/**/*' + - 'lib/net/ber.rb' + - 'lib/net/ber/core_ext.rb' + - 'lib/net/ldap.rb' + - 'lib/net/ldap/auth_adapter.rb' + - 'lib/net/ldap/auth_adapter/sasl.rb' + - 'lib/net/ldap/auth_adapter/simple.rb' + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/error.rb' + - 'lib/net/ldap/instrumentation.rb' + - 'lib/net/ldap/password.rb' + - 'lib/net/ldap/pdu.rb' + - 'lib/net/ldap/version.rb' + - 'lib/net/snmp.rb' + - 'testserver/ldapserver.rb' # Offense count: 23 # Cop supports --auto-correct. @@ -164,77 +245,106 @@ Style/DotPosition: # Offense count: 1 # Cop supports --auto-correct. Style/ElseAlignment: - Enabled: false + Exclude: + - 'testserver/ldapserver.rb' -# Offense count: 4 +# Offense count: 5 # Cop supports --auto-correct. # Configuration parameters: AllowAdjacentOneLineDefs. Style/EmptyLineBetweenDefs: - Enabled: false + Exclude: + - 'lib/net/ldap.rb' + - 'lib/net/ldap/dataset.rb' + - 'lib/net/snmp.rb' -# Offense count: 9 +# Offense count: 8 # Cop supports --auto-correct. Style/EmptyLines: - Enabled: false + Exclude: + - 'lib/net/snmp.rb' + - 'testserver/ldapserver.rb' # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. Style/EmptyLinesAroundClassBody: - Enabled: false + Exclude: + - 'test/test_snmp.rb' # Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. Style/EmptyLinesAroundModuleBody: - Enabled: false + Exclude: + - 'testserver/ldapserver.rb' # Offense count: 3 +# Cop supports --auto-correct. Style/EvenOdd: - Enabled: false + Exclude: + - 'lib/net/ldap/dn.rb' # Offense count: 1 # Configuration parameters: Exclude. Style/FileName: - Enabled: false + Exclude: + - 'lib/net-ldap.rb' # Offense count: 9 # Configuration parameters: AllowedVariables. Style/GlobalVars: - Enabled: false + Exclude: + - 'testserver/ldapserver.rb' -# Offense count: 3 +# Offense count: 4 # Configuration parameters: MinBodyLength. Style/GuardClause: - Enabled: false + Exclude: + - 'lib/net/ber.rb' + - 'lib/net/ldap/entry.rb' + - 'lib/net/ldap/filter.rb' -# Offense count: 150 +# Offense count: 149 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues. Style/HashSyntax: Enabled: false -# Offense count: 8 +# Offense count: 7 +# Cop supports --auto-correct. # Configuration parameters: MaxLineLength. Style/IfUnlessModifier: - Enabled: false + Exclude: + - 'lib/net/ber.rb' + - 'lib/net/ber/core_ext/integer.rb' + - 'lib/net/ldap.rb' + - 'lib/net/ldap/filter.rb' + - 'lib/net/snmp.rb' # Offense count: 2 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Configuration parameters: SupportedStyles. Style/IndentHash: - Enabled: false + EnforcedStyle: consistent -# Offense count: 6 +# Offense count: 10 # Cop supports --auto-correct. # Configuration parameters: Width. Style/IndentationWidth: - Enabled: false + Exclude: + - 'lib/net/ber.rb' + - 'lib/net/ldap/password.rb' + - 'lib/net/snmp.rb' + - 'test/test_snmp.rb' + - 'testserver/ldapserver.rb' -# Offense count: 2 +# Offense count: 3 # Cop supports --auto-correct. Style/LeadingCommentSpace: - Enabled: false + Exclude: + - 'lib/net/ber/core_ext/array.rb' + - 'lib/net/ldap.rb' + - 'lib/net/ldap/connection.rb' # Offense count: 21 # Cop supports --auto-correct. @@ -255,66 +365,85 @@ Style/MultilineOperationIndentation: # Offense count: 1 Style/MultilineTernaryOperator: - Enabled: false + Exclude: + - 'lib/net/ldap/connection.rb' # Offense count: 1 # Cop supports --auto-correct. Style/NegatedIf: - Enabled: false + Exclude: + - 'test/test_helper.rb' # Offense count: 1 # Cop supports --auto-correct. Style/NegatedWhile: - Enabled: false + Exclude: + - 'lib/net/ldap/filter.rb' # Offense count: 3 +# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles. Style/Next: - Enabled: false + Exclude: + - 'lib/net/ldap/connection.rb' + - 'testserver/ldapserver.rb' # Offense count: 1 # Cop supports --auto-correct. Style/NilComparison: - Enabled: false + Exclude: + - 'lib/net/ldap/connection.rb' # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: IncludeSemanticChanges. Style/NonNilCheck: - Enabled: false + Exclude: + - 'lib/net/ber/ber_parser.rb' # Offense count: 1 # Cop supports --auto-correct. Style/Not: - Enabled: false + Exclude: + - 'lib/net/ldap/filter.rb' -# Offense count: 10 +# Offense count: 11 # Cop supports --auto-correct. Style/NumericLiterals: MinDigits: 8 # Offense count: 3 Style/OpMethod: - Enabled: false + Exclude: + - 'lib/net/ldap/filter.rb' # Offense count: 6 # Cop supports --auto-correct. # Configuration parameters: AllowSafeAssignment. Style/ParenthesesAroundCondition: - Enabled: false + Exclude: + - 'lib/net/ldap.rb' + - 'lib/net/ldap/auth_adapter/gss_spnego.rb' + - 'lib/net/ldap/auth_adapter/sasl.rb' + - 'lib/net/ldap/auth_adapter/simple.rb' # Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: - Enabled: false + Exclude: + - 'net-ldap.gemspec' + - 'test/test_entry.rb' # Offense count: 11 # Cop supports --auto-correct. Style/PerlBackrefs: - Enabled: false + Exclude: + - 'lib/net/ldap/dataset.rb' + - 'lib/net/ldap/filter.rb' + - 'testserver/ldapserver.rb' -# Offense count: 9 +# Offense count: 10 # Configuration parameters: EnforcedStyle, SupportedStyles. Style/RaiseArgs: Enabled: false @@ -322,54 +451,96 @@ Style/RaiseArgs: # Offense count: 1 # Cop supports --auto-correct. Style/RedundantBegin: - Enabled: false + Exclude: + - 'lib/net/snmp.rb' -# Offense count: 3 +# Offense count: 4 # Cop supports --auto-correct. # Configuration parameters: AllowMultipleReturnValues. Style/RedundantReturn: - Enabled: false + Exclude: + - 'lib/net/ber/core_ext/string.rb' + - 'lib/net/ldap/auth_adapter.rb' + - 'lib/net/ldap/entry.rb' + - 'lib/net/ldap/password.rb' -# Offense count: 7 +# Offense count: 6 # Cop supports --auto-correct. Style/RedundantSelf: - Enabled: false + Exclude: + - 'lib/net/ber/core_ext/array.rb' + - 'lib/net/ber/core_ext/string.rb' + - 'lib/net/ldap/dn.rb' + - 'lib/net/ldap/filter.rb' -# Offense count: 1 -# Configuration parameters: MaxSlashes. +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes. Style/RegexpLiteral: - Enabled: false + Exclude: + - 'lib/net/ldap/filter.rb' + - 'net-ldap.gemspec' -# Offense count: 2 +# Offense count: 1 +# Cop supports --auto-correct. Style/RescueModifier: - Enabled: false + Exclude: + - 'test/ber/core_ext/test_string.rb' -# Offense count: 7 +# Offense count: 8 # Cop supports --auto-correct. # Configuration parameters: AllowAsExpressionSeparator. Style/Semicolon: - Enabled: false + Exclude: + - 'lib/net/ldap/dn.rb' + - 'lib/net/ldap/error.rb' + - 'testserver/ldapserver.rb' -# Offense count: 61 +# Offense count: 66 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. Style/SignalException: - Enabled: false + Exclude: + - 'lib/net/ber/ber_parser.rb' + - 'lib/net/ber/core_ext/array.rb' + - 'lib/net/ldap.rb' + - 'lib/net/ldap/auth_adapter.rb' + - 'lib/net/ldap/auth_adapter/gss_spnego.rb' + - 'lib/net/ldap/auth_adapter/sasl.rb' + - 'lib/net/ldap/auth_adapter/simple.rb' + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/dn.rb' + - 'lib/net/ldap/entry.rb' + - 'lib/net/ldap/filter.rb' + - 'lib/net/ldap/password.rb' + - 'lib/net/ldap/pdu.rb' + - 'lib/net/snmp.rb' # Offense count: 2 # Configuration parameters: Methods. Style/SingleLineBlockParams: - Enabled: false + Exclude: + - 'lib/net/ldap/filter.rb' # Offense count: 2 # Cop supports --auto-correct. Style/SingleSpaceBeforeFirstArg: - Enabled: false + Exclude: + - 'lib/net/ldap/dataset.rb' + - 'lib/net/ldap/instrumentation.rb' # Offense count: 24 # Cop supports --auto-correct. Style/SpaceAfterComma: - Enabled: false + Exclude: + - 'lib/net/ber/core_ext/integer.rb' + - 'lib/net/ber/core_ext/string.rb' + - 'lib/net/ldap/dataset.rb' + - 'lib/net/ldap/entry.rb' + - 'lib/net/snmp.rb' + - 'test/ber/core_ext/test_array.rb' + - 'test/ber/test_ber.rb' + - 'test/test_dn.rb' # Offense count: 2 # Cop supports --auto-correct. @@ -377,10 +548,16 @@ Style/SpaceAfterComma: Style/SpaceAroundEqualsInParameterDefault: Enabled: false -# Offense count: 8 +# Offense count: 9 # Cop supports --auto-correct. +# Configuration parameters: MultiSpaceAllowedForOperators. Style/SpaceAroundOperators: - Enabled: false + Exclude: + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/entry.rb' + - 'lib/net/ldap/filter.rb' + - 'test/test_entry.rb' + - 'test/test_ldap_connection.rb' # Offense count: 2 # Cop supports --auto-correct. @@ -397,7 +574,13 @@ Style/SpaceInsideBlockBraces: # Offense count: 37 # Cop supports --auto-correct. Style/SpaceInsideBrackets: - Enabled: false + Exclude: + - 'lib/net/ber.rb' + - 'lib/net/ldap.rb' + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/filter.rb' + - 'test/test_ldap_connection.rb' + - 'testserver/ldapserver.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -408,52 +591,67 @@ Style/SpaceInsideHashLiteralBraces: # Offense count: 20 # Cop supports --auto-correct. Style/SpaceInsideParens: - Enabled: false + Exclude: + - 'lib/net/ldap/entry.rb' + - 'lib/net/snmp.rb' + - 'test/test_password.rb' + - 'testserver/ldapserver.rb' # Offense count: 5 # Cop supports --auto-correct. Style/SpecialGlobalVars: - Enabled: false + Exclude: + - 'lib/net/snmp.rb' + - 'net-ldap.gemspec' + - 'testserver/ldapserver.rb' -# Offense count: 645 +# Offense count: 663 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. Style/StringLiterals: Enabled: false -# Offense count: 10 +# Offense count: 11 # Cop supports --auto-correct. # Configuration parameters: IgnoredMethods. Style/SymbolProc: - Enabled: false + Exclude: + - 'lib/net/ber.rb' + - 'lib/net/ber/core_ext/array.rb' + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/dataset.rb' + - 'lib/net/ldap/filter.rb' + - 'test/ber/test_ber.rb' + - 'test/test_ldif.rb' + - 'testserver/ldapserver.rb' -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/TrailingBlankLines: - Enabled: false - -# Offense count: 9 +# Offense count: 12 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyleForMultiline, SupportedStyles. Style/TrailingComma: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist. -Style/TrivialAccessors: - Enabled: false + Exclude: + - 'lib/net/ldap.rb' + - 'lib/net/ldap/dn.rb' + - 'lib/net/snmp.rb' + - 'test/ber/test_ber.rb' + - 'test/test_dn.rb' + - 'test/test_filter.rb' + - 'test/test_ldap_connection.rb' + - 'testserver/ldapserver.rb' # Offense count: 5 # Cop supports --auto-correct. Style/UnneededPercentQ: - Enabled: false + Exclude: + - 'net-ldap.gemspec' + - 'test/test_entry.rb' # Offense count: 1 +# Cop supports --auto-correct. # Configuration parameters: MaxLineLength. Style/WhileUntilModifier: - Enabled: false + Exclude: + - 'lib/net/ldap/filter.rb' # Offense count: 1 # Cop supports --auto-correct.