Skip to content

[BUG] Pluralization rules for unknown locales require 'one' and 'other' keys #706

@JasonBarnabe

Description

@JasonBarnabe

What I tried to do

I am using Transifex on devise-i18n for localization. This lets translators do their work with a web UI and I (the dev) can pull from Transifex.

In this project, I include translations for some locales where pluralization rules are not specified by svenfuchs/rails-i18n: Igbo (ig) and Yoruba (yo). For these languages, Transifex uses the other-only plural form, which is correct according the Plural Language Rules.

What I expected to happen

I expected to be able to use these translations with the correct plural forms as provided by Transifex.

What actually happened

I18n::InvalidPluralizationData: translation data {:other=>"%{count}àsìse sèdíwọ elè yìí %{resource} láti lè fi pamọ́"} can not be used with :count => 1. key 'one' is missing.

Digging through the code, I found the logic here:

def pluralization_key(entry, count)
key = :zero if count == 0 && entry.has_key?(:zero)
key ||= count == 1 ? :one : :other
end

Considering it's smart enough to check for the presence of a zero key before using it, why not do the same for one? That way, for locales without pluralization data, having other is sufficient to avoid an error.

As a workaround, I can manually duplicate the others into ones for both of these locales, but that's a hassle.

Versions of i18n, rails, and anything else you think is necessary

  • i18n 1.14.6
  • rails-i18n 7.0.8

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions