Fixed ExtFieldCustomData in Route4MeSDK.DataTypes.Order

Author: Dmitry Koval

route4me-csharp-sdk/Route4MeSDKLibrary/DataTypes/Order.cs

@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using System.Runtime.Serialization;
-using System.Text.Json.Serialization;
 using Route4MeSDK.QueryTypes;
 
 namespace Route4MeSDK.DataTypes
@@ -156,24 +155,10 @@ public sealed class Order : GenericParameters
         public string ExtFieldPhone { get; set; }
 
         /// <summary>
-        ///     Not serialized - for prevention wrong data (e.g. Dictionary<string, string>[])
-        /// </summary>
-        [JsonIgnore]
-        public Dictionary<string, string> ExtFieldCustomData
-        {
-            get =>
-                ExtFieldCustomData2 != null && ExtFieldCustomData2.GetType() == typeof(Dictionary<string, string>)
-                    ? (Dictionary<string, string>) ExtFieldCustomData2
-                    : null;
-            set => ExtFieldCustomData2 = value;
-        }
-
-        /// <summary>
-        ///     Custom data - serialized
+        ///     Custom data
         /// </summary>
         [DataMember(Name = "EXT_FIELD_custom_data", EmitDefaultValue = false)]
-        private object ExtFieldCustomData2 { get; set; }
-
+        public Dictionary<string, string> ExtFieldCustomData { get; set; }
 
         /// <summary>
         ///     Local timezone string
@@ -212,14 +197,5 @@ public Dictionary<string, string> ExtFieldCustomData
         [DataMember(Name = "tracking_number", EmitDefaultValue = false)]
         [ReadOnly(true)]
         public string TrackingNumber { get; set; }
-
-        public bool ShouldSerializeExtFieldCustomData()
-        {
-            return ExtFieldCustomData == null
-                ? false
-                : ExtFieldCustomData.GetType() == typeof(Dictionary<string, string>)
-                    ? true
-                    : false;
-        }
     }
 }

route4me-csharp-sdk/Route4MeSDKUnitTest/Route4MeManagerUnitTest.cs

@@ -11811,6 +11811,46 @@ public void AddScheduledOrderTest()
             lsOrders.Add(newOrder);
         }
 
+        [TestMethod]
+        public void AddScheduledOrderAndCheckExtFieldCustomDataTest()
+        {
+            if (skip == "yes") return;
+
+            var route4Me = new Route4MeManager(c_ApiKey);
+
+            var orderParams = new Order
+            {
+                Address1 = "318 S 39th St, Louisville, KY 40212, USA",
+                CachedLat = 38.259326,
+                CachedLng = -85.814979,
+                CurbsideLat = 38.259326,
+                CurbsideLng = -85.814979,
+                AddressAlias = "318 S 39th St 40212",
+                AddressCity = "Louisville",
+                ExtFieldFirstName = "Lui",
+                ExtFieldLastName = "Carol",
+                ExtFieldEmail = "[email protected]",
+                ExtFieldPhone = "897946541",
+                ExtFieldCustomData = new Dictionary<string, string> { { "order_type", "scheduled order" } },
+                DayScheduledFor_YYYYMMDD = "2020-12-20",
+                LocalTimeWindowEnd = 39000,
+                LocalTimeWindowEnd2 = 46200,
+                LocalTimeWindowStart = 37800,
+                LocalTimeWindowStart2 = 45000,
+                LocalTimezoneString = "America/New_York",
+                OrderIcon = "emoji/emoji-bank"
+            };
+
+            var newOrder = route4Me.AddOrder(orderParams, out _);
+
+            Assert.IsNotNull(newOrder.ExtFieldCustomData);
+            Assert.IsTrue(newOrder.ExtFieldCustomData.Count == 1);
+            Assert.IsTrue(newOrder.ExtFieldCustomData.ContainsKey("order_type"));
+            Assert.IsTrue(newOrder.ExtFieldCustomData["order_type"] == "scheduled order");
+
+            lsOrders.Add(newOrder);
+        }
+
         [TestMethod]
         public void AddOrdersToOptimizationTest()
         {