Merge pull request #186 from rom-py/postprocess_cli

Added postprocess command to cli

Author: tomdurrant

rompy/cli.py

@@ -479,6 +479,60 @@ def generate(
         sys.exit(1)
 
 
+@cli.command()
+@click.argument("config", type=click.Path(exists=True), required=False)
+@click.option("--processor", default="noop", help="Postprocessor to use (default: noop)")
+@click.option("--output-dir", help="Override output directory for postprocessing")
+@click.option("--validate-outputs/--no-validate", default=True, help="Validate outputs exist (default: True)")
+@add_common_options
+def postprocess(
+    config,
+    processor,
+    output_dir,
+    validate_outputs,
+    verbose,
+    log_dir,
+    show_warnings,
+    ascii_only,
+    simple_logs,
+    config_from_env,
+):
+    """Run postprocessing on model outputs using the specified postprocessor."""
+    configure_logging(verbose, log_dir, simple_logs, ascii_only, show_warnings)
+
+    # Validate config source
+    if config_from_env and config:
+        raise click.UsageError("Cannot specify both config file and --config-from-env")
+    if not config_from_env and not config:
+        raise click.UsageError("Must specify either config file or --config-from-env")
+
+    try:
+        # Load configuration
+        config_data = load_config(config, from_env=config_from_env)
+        model_run = ModelRun(**config_data)
+
+        logger.info(f"Running postprocessing for: {model_run.config.model_type}")
+        logger.info(f"Run ID: {model_run.run_id}")
+        logger.info(f"Postprocessor: {processor}")
+
+        # Run postprocessing
+        start_time = datetime.now()
+        results = model_run.postprocess(
+            processor=processor,
+            output_dir=output_dir,
+            validate_outputs=validate_outputs,
+        )
+        elapsed = datetime.now() - start_time
+
+        logger.info(f"✅ Postprocessing completed in {elapsed.total_seconds():.2f}s")
+        logger.info(f"Results: {results}")
+
+    except Exception as e:
+        logger.error(f"❌ Postprocessing failed: {e}")
+        if verbose > 0:
+            logger.exception("Full traceback:")
+        sys.exit(1)
+
 @cli.command()
 @click.argument("config", type=click.Path(exists=True), required=False)
 @add_common_options

tests/test_cli_config.py

@@ -194,6 +194,16 @@ def test_pipeline_with_config_from_env(self):
                 ])
                 assert result.exit_code == 0
 
+    def test_postprocess_with_config_from_env(self):
+        """Test postprocess command with config from environment variable."""
+        with patch.dict(os.environ, {'ROMPY_CONFIG': self.config_json}):
+            with patch('rompy.cli.ModelRun') as mock_model_run:
+                result = self.runner.invoke(cli, [
+                    'postprocess', '--config-from-env', '--processor', 'noop'
+                ])
+                assert result.exit_code == 0
+                assert mock_model_run.called
+
     def test_config_from_env_missing_variable(self):
         """Test error when ROMPY_CONFIG environment variable is missing."""
         with patch.dict(os.environ, {}, clear=True):
@@ -232,6 +242,24 @@ def setup_method(self):
             "period": {"start": "2020-01-01", "end": "2020-01-02"}
         }
 
+    def test_postprocess_error_on_missing_config(self):
+        """Test error when neither config file nor --config-from-env is specified for postprocess."""
+        result = self.runner.invoke(cli, ['postprocess'])
+        assert result.exit_code != 0
+        assert "Must specify either" in result.output
+
+    def test_postprocess_error_on_both_config_and_env(self):
+        """Test error when both config file and --config-from-env are specified for postprocess."""
+        with tempfile.NamedTemporaryFile(mode='w', suffix='.json', delete=False) as f:
+            json.dump(self.config_data, f)
+            config_path = f.name
+        try:
+            result = self.runner.invoke(cli, ['postprocess', config_path, '--config-from-env'])
+            assert result.exit_code != 0
+            assert "Cannot specify both" in result.output
+        finally:
+            os.unlink(config_path)
+
     def test_validate_with_config_file(self):
         """Test that validate command still works with config files."""
         with tempfile.NamedTemporaryFile(mode='w', suffix='.json', delete=False) as f:
@@ -283,6 +311,21 @@ def test_run_with_config_file(self):
             os.unlink(config_path)
             os.unlink(backend_path)
 
+    def test_postprocess_with_config_file(self):
+        """Test that postprocess command works with config files."""
+        with tempfile.NamedTemporaryFile(mode='w', suffix='.json', delete=False) as f:
+            json.dump(self.config_data, f)
+            config_path = f.name
+        try:
+            with patch('rompy.cli.ModelRun') as mock_model_run:
+                result = self.runner.invoke(cli, [
+                    'postprocess', config_path, '--processor', 'noop'
+                ])
+                assert result.exit_code == 0
+                assert mock_model_run.called
+        finally:
+            os.unlink(config_path)
+
 
 class TestCLIHelpOutput:
     """Test that help output includes information about environment variable option."""
@@ -315,3 +358,9 @@ def test_pipeline_help_includes_config_from_env(self):
         result = self.runner.invoke(cli, ['pipeline', '--help'])
         assert result.exit_code == 0
         assert '--config-from-env' in result.output
+
+    def test_postprocess_help_includes_config_from_env(self):
+        """Test that postprocess command help mentions --config-from-env option."""
+        result = self.runner.invoke(cli, ['postprocess', '--help'])
+        assert result.exit_code == 0
+        assert '--config-from-env' in result.output