style(Android): Many warnings and style fixes (#10886) abb33a5433

Warnings:
- Move from deprecated functions
- var -> val
- Clang tidy static suggestion
- Clang tidy for const in header functions
- Delete unused JNI reference methods
- Use auto when suggested by Clang
- Remove unused JNIEnv and thisObj references
- Add suggested function annotations
- Change visibility of deleted members
- Modernize includes
- Null handling
- Struct syntax
- Narrowing/casts
- Unnecessary pBuffer checks
- Naming (typo checker)
- Unneeded `GetTargetValue` checks
- Deprecation warnings on tests
- Superclass name match
- Unnecessary casts
- Use non-deprecated functions
- Unused vars
- Shadowing of `it`
- Remove app bar hiding part of the bind button
- Warning around modifier being first optional param
- Double null coercion
- Duplicate in gitignore
- Update 10dp -> 11sp (minimum)
- Warned height value
- Kotlin APIs

Style:
- Automatic style changes
- Move to #pragma once
- Naming
- Spaces/newlines
- Inferred generic
- Use resource class
- Hide app bar on main menu
- Capitalize app name
- Automated XML formatting
- Remove template comments
- Minor style tweaks to RiveButton and ButtonActivity

Documentation:
- Clarify premake5 locations
- Update authors
- Update issue template

Cleanup:
- Unused C++ testing directory
- Unmaintained docs code
- Unused raw assets
- Unused ids.xml
- Irrelevant test
- Remove single Rive Renderer split

Chore:
- Bump Material version
- Bump Gradle Git Version plugin

Fix:
- Doc import
- Remove blank issues, add support links

Co-authored-by: Erik <[email protected]>

Author: ErikUggeldahl

.github/ISSUE_TEMPLATE/i-have-a-problem-with-rive-android.md

@@ -4,71 +4,82 @@ about: Tell us what's wrong
 title: ''
 labels: ''
 assignees: ''
-
 ---
 
-<-- Thanks for using Rive!
-
-If something isn't working like you expected, please:
+<!-- Thanks for using Rive!
 
-- Make sure you've updated rive-android to the latest version:
-      https://search.maven.org/artifact/app.rive/rive-android
-- Check out our documentation
-			https://rive.app/community/doc
-- Get help on our forums
-			https://rive.app/community/forums/home		
-- You can file a new feature request at
-      https://rive.app/community/forums/feature-requests/fsnweJpNLqIh
+If something isn't working as expected, please:
 
-If you think you found a bug or if you can't find what you're looking for
-in our docs, fill out the template below.
+- Make sure you've updated rive-android to the 
+[latest version](https://central.sonatype.com/artifact/app.rive/rive-android).
+- Check out [our documentation](https://rive.app/docs/runtimes/)
+- Get help in our [community](https://community.rive.app/)
+- You can file a [new general feature request](https://community.rive.app/c/feature-requests/) in
+  our community
 
+If you think you've found a bug or if you can't find what you're looking for in our docs, fill out
+the template below.
 -->
 
 ### Description
 
-<-- A clear and concise description of what the problem is. -->
+<!-- A clear and concise description of what the problem is.
+
+Please include a stack trace if one is available and relevant. Ideally it is symbolicated. -->
+
+### Versions, Device, and Other Information
+
+<!-- Please complete the following information. -->
+
+- Rive Android Runtime Version: <!-- e.g. 10.0.0 -->
+- Rive API: <!-- e.g. Compose or Legacy -->
+- Device: <!-- e.g. Android Emulator, Pixel 4a -->
+- App Minimum SDK Level: <!-- e.g. Android SDK API Level 21 -->
+- App Target SDK Level: <!-- e.g. Android SDK API Level 36 -->
+- App NDK Level: <!-- [e.g. Android NDK API Level 21 -->
+- Frequency: <!-- e.g. Every time, often, rarely. More information is better -->
 
-### Provide a Repro
+<!-- Optional Information -->
 
-<--
-Please provide the most **minimal repro** you can:
+- Other Rive runtimes affected: <!-- e.g. iOS, Flutter, React Native -->
+- Dependencies with native libraries: <!-- e.g. ExoPlayer, OpenCV, TensorFlow Lite -->
+
+### Reproduction Steps
+
+<!-- Please provide the most **minimal reproduction** you can:
 
 - If the problem is small enough, paste a code snippet
 - Otherwise, you can attach a ZIP archive or paste a link to a GitHub repository with the app bundle
   that is reproducing the issue
 
 -->
 
-#### Source `.riv`/`.rev` file
+### Source `.riv`/`.rev` File
+
+<!--
+Attaching the exported `.riv` file that reproduces the issue is immensely helpful for our team to
+identify the problem as fast as possible and fix it.
 
-<--
-Attaching runtime-exported `.riv` file that reproduces the issue is immensely helpful for our team
-to identify the problem as fast as possible and fix it.
-Please also include the source (`.rev`)
-by [downloading a backup](https://rive.app/community/doc/exporting/dockj1y5YeDd#for-backup) from the Editor.
+Please also include the source (`.rev`) by
+[downloading a backup](https://rive.app/docs/editor/exporting/exporting-for-backup) from the
+editor.
 
-N.B. Because GitHub only supports certain file types use a ZIP archive to upload `.riv`/`.rev` files
-to this issue.
+Note: Because GitHub only supports certain file types, use a ZIP archive to upload your `.riv`/
+`.rev` files for this issue.
 
 You can also privately share the `.riv`/`.rev` file with us at [email protected].
 -->
 
-### Expected behavior
+### Expected Behavior
 
-<-- A clear and concise description of what you expected to happen. -->
+<!-- A clear and concise description of what you expected to happen. -->
 
-#### Screenshots
+### Screenshots
 
-<-- If applicable, add screenshots to help explain your problem. -->
+<!-- If applicable, add screenshots or video to help explain your problem. -->
 
 ![Screenshot](url)
 
-### Device & Versions (please complete the following information)
-
-- Device: [e.g. Android Emulator, Pixel 4a]
-- SDK Level [e.g. Android SDK API Level 30]
-
-#### Additional context
+### Additional context
 
-<-- Add any other context about the problem here. -->
+<!-- Add any other context about the problem here. -->

.gitignore

@@ -47,6 +47,3 @@ bugreport*.zip
 
 # Test history
 test_history.csv
-
-# OS files
-.DS_Store

.rive_head

@@ -1 +1 @@
-c1e0f7b5951eda512b3b1417cf297d3f041a8216
+abb33a5433f43b5205b2b595a7f89e6402875d11

app/build.gradle

@@ -80,7 +80,7 @@ dependencies {
     implementation "androidx.fragment:fragment-ktx:1.8.9"
     implementation "androidx.startup:startup-runtime:1.2.0"
     implementation "com.android.volley:volley:1.2.1"
-    implementation "com.google.android.material:material:1.12.0"
+    implementation "com.google.android.material:material:1.13.0"
 
     debugImplementation project(path: ":kotlin")
     releaseImplementation project(path: ":kotlin")

app/src/androidTest/java/app/rive/runtime/example/DeviceRunner.kt

@@ -150,7 +150,6 @@ class RiveActivityLifecycleTest {
         assertNull(controller.activeArtboard)
     }
 
-
     @Test
     fun resizeRiveView() {
         val activityScenario = ActivityScenario.launch(SingleActivity::class.java)

app/src/androidTest/java/app/rive/runtime/example/RiveActivityLifecycleTest.kt

@@ -27,7 +27,6 @@ class TestUtils {
                     throw TimeoutException("Took too long.")
                 }
             } while (!condition())
-
         }
 
         // Helper function to check whether it's running on an emulator

app/src/androidTest/java/app/rive/runtime/example/RiveRendererActivityTest.kt

@@ -93,4 +93,4 @@
         <activity android:name=".EmptyActivity" />
     </application>
 
-</manifest>
+</manifest>

app/src/androidTest/java/app/rive/runtime/example/TestUtils.kt

@@ -79,11 +79,10 @@ class AndroidPlayerActivity : AppCompatActivity() {
         }
     }
 
-
     fun onLoopModeSelected(view: View) {
         if (view is RadioButton && view.isChecked) {
             // Check which radio button was clicked
-            when (view.getId()) {
+            when (view.id) {
                 R.id.loop_auto ->
                     loop = Loop.AUTO
 
@@ -102,7 +101,7 @@ class AndroidPlayerActivity : AppCompatActivity() {
     fun onDirectionSelected(view: View) {
         if (view is RadioButton && view.isChecked) {
             // Check which radio button was clicked
-            when (view.getId()) {
+            when (view.id) {
                 R.id.direction_auto ->
                     direction = Direction.AUTO
 
@@ -153,15 +152,13 @@ class AndroidPlayerActivity : AppCompatActivity() {
         }
         stopButtonMap[animationName] = stopButton
 
-
         layout.addView(text)
         layout.addView(playButton)
         layout.addView(pauseButton)
         layout.addView(stopButton)
         return layout
     }
 
-
     fun addStateMachineControl(artboard: Artboard, stateMachineName: String): List<View> {
         val views = mutableListOf<View>()
         val layout = LinearLayout(this)
@@ -203,7 +200,6 @@ class AndroidPlayerActivity : AppCompatActivity() {
         layout.addView(stopButton)
         views.add(layout)
 
-
         stateMachine.inputs.forEach {
             val innerLayout = LinearLayout(this)
             innerLayout.orientation = LinearLayout.HORIZONTAL
@@ -312,7 +308,6 @@ class AndroidPlayerActivity : AppCompatActivity() {
         }
     }
 
-
     fun setResourceSpinner() {
         animationResources.let { _ ->
             val dropdown = findViewById<Spinner>(R.id.resources)
@@ -337,7 +332,6 @@ class AndroidPlayerActivity : AppCompatActivity() {
         }
     }
 
-
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.android_player)
@@ -432,4 +426,3 @@ class AndroidPlayerActivity : AppCompatActivity() {
         animationView.registerListener(listener)
     }
 }
-