From 9ff287b4ec97ecf2caadf24fbd767690e5c62f89 Mon Sep 17 00:00:00 2001
From: Cristiano Calcagno <cristianoc@users.noreply.github.com>
Date: Fri, 13 May 2022 11:12:41 +0200
Subject: [PATCH] Fix extension crash when renaming a file.

More robust solution where the file cache is set also for files with extension not `.res` or `.resi`.
In case of rename e.g. from `.res` to `.rex` an opened file notification is sent for the `.rex` file and a crash happens when trying to get the current file content.
After this change, the file content array is set also for the .rex` file, preventing the crash.

Fixes https://github.com/rescript-lang/rescript-vscode/issues/392
---
 server/src/server.ts | 37 +------------------------------------
 1 file changed, 1 insertion(+), 36 deletions(-)

diff --git a/server/src/server.ts b/server/src/server.ts
index ab28995cb..946778718 100644
--- a/server/src/server.ts
+++ b/server/src/server.ts
@@ -271,15 +271,6 @@ if (process.argv.includes("--stdio")) {
 function hover(msg: p.RequestMessage) {
   let params = msg.params as p.HoverParams;
   let filePath = fileURLToPath(params.textDocument.uri);
-  let extension = path.extname(params.textDocument.uri);
-  if (extension !== c.resExt && extension !== c.resiExt) {
-    // Can be called on renamed extension after rename
-    return {
-      jsonrpc: c.jsonrpcVersion,
-      id: msg.id,
-      result: null,
-    };
-  }
   let code = getOpenedFileContent(params.textDocument.uri);
   let tmpname = utils.createFileInTempDir();
   fs.writeFileSync(tmpname, code, { encoding: "utf-8" });
@@ -408,14 +399,6 @@ function documentSymbol(msg: p.RequestMessage) {
   let params = msg.params as p.DocumentSymbolParams;
   let filePath = fileURLToPath(params.textDocument.uri);
   let extension = path.extname(params.textDocument.uri);
-  if (extension !== c.resExt && extension !== c.resiExt) {
-    // Can be called on renamed extension after rename
-    return {
-      jsonrpc: c.jsonrpcVersion,
-      id: msg.id,
-      result: null,
-    };
-  }
   let code = getOpenedFileContent(params.textDocument.uri);
   let tmpname = utils.createFileInTempDir(extension);
   fs.writeFileSync(tmpname, code, { encoding: "utf-8" });
@@ -434,14 +417,6 @@ function semanticTokens(msg: p.RequestMessage) {
   let params = msg.params as p.SemanticTokensParams;
   let filePath = fileURLToPath(params.textDocument.uri);
   let extension = path.extname(params.textDocument.uri);
-  if (extension !== c.resExt && extension !== c.resiExt) {
-    // Can be called on renamed extension after rename
-    return {
-      jsonrpc: c.jsonrpcVersion,
-      id: msg.id,
-      result: null,
-    };
-  }
   let code = getOpenedFileContent(params.textDocument.uri);
   let tmpname = utils.createFileInTempDir(extension);
   fs.writeFileSync(tmpname, code, { encoding: "utf-8" });
@@ -460,14 +435,6 @@ function completion(msg: p.RequestMessage) {
   let params = msg.params as p.ReferenceParams;
   let filePath = fileURLToPath(params.textDocument.uri);
   let extension = path.extname(params.textDocument.uri);
-  if (extension !== c.resExt && extension !== c.resiExt) {
-    // Can be called on renamed extension after rename
-    return {
-      jsonrpc: c.jsonrpcVersion,
-      id: msg.id,
-      result: null,
-    };
-  }
   let code = getOpenedFileContent(params.textDocument.uri);
   let tmpname = utils.createFileInTempDir();
   fs.writeFileSync(tmpname, code, { encoding: "utf-8" });
@@ -777,9 +744,7 @@ function onMessage(msg: m.Message) {
     } else if (msg.method === DidOpenTextDocumentNotification.method) {
       let params = msg.params as p.DidOpenTextDocumentParams;
       let extName = path.extname(params.textDocument.uri);
-      if (extName === c.resExt || extName === c.resiExt) {
-        openedFile(params.textDocument.uri, params.textDocument.text);
-      }
+      openedFile(params.textDocument.uri, params.textDocument.text);
     } else if (msg.method === DidChangeTextDocumentNotification.method) {
       let params = msg.params as p.DidChangeTextDocumentParams;
       let extName = path.extname(params.textDocument.uri);