glms_mat4_mulN access violation

[junglie85]

I've never used the cglm library before and am giving it a try, but when multiplying matrices using the struct API function glms_mat4_mulN I'm hitting a memory access violation. I'm being dense, I'm tired which probably doesn't help - what am I doing wrong?

mat4s model_m[3] = {
    glms_scale_make(glms_vec3_make((float[]){ 100.0f, 100.0f, 0.0f })),
    glms_rotate_make(0.0f, glms_vec3_make((float[]){ 0.0f, 0.0f, 1.0f })),
    glms_translate_make(glms_vec3_make((float[]){ 0.0f, 0.0f, 0.0f })),
};
mat4s model = glms_mat4_mulN(model_m, 3); // <---- access violation

[junglie85]

Ah, okay, I missed the warning in the docs.

mat4s model = glms_mat4_mulN(
    (mat4s *[]){
        glms_scale_make(glms_vec3_make((float[]){ 100.0f, 100.0f, 0.0f })).raw,
        glms_rotate_make(0.0f, glms_vec3_make((float[]){ 0.0f, 0.0f, 1.0f })).raw,
        glms_translate_make(glms_vec3_make((float[]){ 0.0f, 0.0f, 0.0f })).raw,
    },
    3);

Is there a better way?

[recp]

Hi @junglie85,

#446 would be an alternative approach. glm_trs() or glm_mat4_trs(v,v,v,m) / mat4_trs(v,v,v,m) could be introduced to make it better.

[junglie85]

Thanks @recp , I didn't see that PR. I'll follow it and use when implemented/released.