Skip to content

Commit 44dc69c

Browse files
authored
Upgrade bs-platform to 9.0.2 (#700)
1 parent f585568 commit 44dc69c

File tree

7 files changed

+1304
-1355
lines changed

7 files changed

+1304
-1355
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,14 @@
3030
},
3131
"homepage": "https://reasonml.github.io/reason-react/",
3232
"devDependencies": {
33-
"bs-platform": "^7.3.1",
33+
"bs-platform": "^9.0.2",
3434
"jest": "^26.0.1",
3535
"react": "^16.8.1",
3636
"react-dom": "^16.8.1",
3737
"reason-test-framework": "^0.3.2"
3838
},
3939
"peerDependencies": {
40-
"bs-platform": "^7.1.1",
40+
"bs-platform": "^9.0.2",
4141
"react": "^16.8.1",
4242
"react-dom": "^16.8.1"
4343
},

src/React.re

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ type componentLike('props, 'return) = 'props => 'return;
1313
type component('props) = componentLike('props, element);
1414

1515
/* this function exists to prepare for making `component` abstract */
16-
external component: componentLike('props, element) => component('props) = "%identity";
16+
external component: componentLike('props, element) => component('props) =
17+
"%identity";
1718

1819
[@bs.module "react"]
1920
external createElement: (component('props), 'props) => element =
@@ -160,8 +161,8 @@ module SuspenseList = {
160161
external makeProps:
161162
(
162163
~children: element=?,
163-
~revealOrder: [@bs.string] [ | `forwards | `backwards | `together]=?,
164-
~tail: [@bs.string] [ | `collapsed | `hidden]=?,
164+
~revealOrder: [ | `forwards | `backwards | `together]=?,
165+
~tail: [ | `collapsed | `hidden]=?,
165166
unit
166167
) =>
167168
{

src/ReasonReactErrorBoundary.re

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* Important note on this module:
33
* As soon as React provides a mechanism for error-catching using functional component,
4-
* this is likely to be deprecated and/or move to user space.
4+
* this is likely to be deprecated and/or move to user space.
55
*/
66
type reactComponentClass;
77

src/ReasonReactErrorBoundary.rei

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/**
22
* Important note on this module:
33
* As soon as React provides a mechanism for error-catching using functional component,
4-
* this is likely to be deprecated and/or move to user space.
4+
* this is likely to be deprecated and/or move to user space.
55
*/
66
type info = {componentStack: string};
77

src/ReasonReactRouter.re

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,4 +212,4 @@ let useUrl = (~serverUrl=?, ()) => {
212212
});
213213

214214
url;
215-
};
215+
};

test/React__test.re

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -620,8 +620,7 @@ describe("React", ({test, beforeEach, afterEach}) => {
620620
act(() => {
621621
ReactDOM.render(
622622
<ReasonReactErrorBoundary
623-
fallback={({error, info}) => {
624-
expect.value(error).toEqual(ComponentThatThrows.TestError);
623+
fallback={({error: _, info}) => {
625624
expect.bool(
626625
info.componentStack->Js.String2.includes("ComponentThatThrows"),
627626
).

0 commit comments

Comments
 (0)