Refactor: generate instead of list files to copy.

Author: real-yfprojects

sphinx_polyversion/driver.py

@@ -337,10 +337,9 @@ async def build_local(self) -> None:
             # copy source files
             logger.info("Copying source files (except for files ignored by git)...")
             try:
-                files = await get_unignored_files(self.root)
-                for filename in files:
-                    source = self.root / filename
-                    target = path / filename
+                async for file in get_unignored_files(self.root):
+                    source = self.root / file
+                    target = path / file
                     target.parent.mkdir(parents=True, exist_ok=True)
                     if source.exists() and not target.exists():
                         shutil.copy2(source, target, follow_symlinks=False)

sphinx_polyversion/git.py

@@ -260,7 +260,7 @@ async def file_exists(repo: Path, ref: GitRef, file: PurePath) -> bool:
     return rc == 0
 
 
-async def get_unignored_files(directory: Path) -> list[Path]:
+async def get_unignored_files(directory: Path) -> AsyncGenerator[Path, None]:
     """
     List all unignored files in the directory.
 
@@ -271,7 +271,7 @@ async def get_unignored_files(directory: Path) -> list[Path]:
 
     Returns
     -------
-    Path
+    AsyncGenerator[Path, None]
         The paths to all un-ignored files in the directory (recursive)
 
     """
@@ -284,8 +284,8 @@ async def get_unignored_files(directory: Path) -> list[Path]:
     )
     process = await asyncio.create_subprocess_exec(*cmd, cwd=directory, stdout=PIPE)
     out, err = await process.communicate()
-    files = out.decode().split("\n")
-    return [Path(path.strip()) for path in files]
+    for line in out.decode().splitlines():
+        yield Path(line.strip())
 
 
 # -- VersionProvider API -----------------------------------------------------