Skip to content

Commit f841296

Browse files
committed
Mark all connector classes as final
Classes should be used via composition rather than extension. This reduces our API footprint and avoids future BC breaks by avoiding exposing its internal assumptions.
1 parent 3473047 commit f841296

File tree

6 files changed

+6
-13
lines changed

6 files changed

+6
-13
lines changed

src/Connector.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* @see DnsConnector for the newer replacement
1616
* @see ConnectorInterface for the base interface
1717
*/
18-
class Connector implements ConnectorInterface
18+
final class Connector implements ConnectorInterface
1919
{
2020
private $connector;
2121

src/DnsConnector.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@
33
namespace React\SocketClient;
44

55
use React\Dns\Resolver\Resolver;
6-
use React\Stream\Stream;
76
use React\Promise;
87
use React\Promise\CancellablePromiseInterface;
98

10-
class DnsConnector implements ConnectorInterface
9+
final class DnsConnector implements ConnectorInterface
1110
{
1211
private $connector;
1312
private $resolver;

src/SecureConnector.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@
55
use React\EventLoop\LoopInterface;
66
use React\Stream\Stream;
77
use React\Promise;
8-
use React\Promise\CancellablePromiseInterface;
98

10-
class SecureConnector implements ConnectorInterface
9+
final class SecureConnector implements ConnectorInterface
1110
{
1211
private $connector;
1312
private $streamEncryption;

src/TcpConnector.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,10 @@
33
namespace React\SocketClient;
44

55
use React\EventLoop\LoopInterface;
6-
use React\Dns\Resolver\Resolver;
76
use React\Stream\Stream;
87
use React\Promise;
9-
use React\Promise\Deferred;
108

11-
class TcpConnector implements ConnectorInterface
9+
final class TcpConnector implements ConnectorInterface
1210
{
1311
private $loop;
1412
private $context;

src/TimeoutConnector.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,8 @@
55
use React\SocketClient\ConnectorInterface;
66
use React\EventLoop\LoopInterface;
77
use React\Promise\Timer;
8-
use React\Stream\Stream;
9-
use React\Promise\Promise;
10-
use React\Promise\CancellablePromiseInterface;
118

12-
class TimeoutConnector implements ConnectorInterface
9+
final class TimeoutConnector implements ConnectorInterface
1310
{
1411
private $connector;
1512
private $timeout;

src/UnixConnector.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* Unix domain sockets use atomic operations, so we can as well emulate
1515
* async behavior.
1616
*/
17-
class UnixConnector implements ConnectorInterface
17+
final class UnixConnector implements ConnectorInterface
1818
{
1919
private $loop;
2020

0 commit comments

Comments
 (0)