From e24f4ed74e795afd36218d0f06658026aa056ec4 Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Sat, 11 Jun 2022 16:51:23 -0700 Subject: [PATCH 01/11] Fix IDOM run with default server --- src/idom/backend/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/idom/backend/utils.py b/src/idom/backend/utils.py index b4c864d97..b891ec793 100644 --- a/src/idom/backend/utils.py +++ b/src/idom/backend/utils.py @@ -40,7 +40,7 @@ def run( "Change this before deploying in production!" ) - implementation = implementation or import_module("idom.server.default") + implementation = implementation or import_module("idom.backend.default") app = implementation.create_development_app() implementation.configure(app, component) From 38bbb9c4a7375ce8a62c6cebe08dd30b52f3d647 Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Sat, 11 Jun 2022 16:57:47 -0700 Subject: [PATCH 02/11] bump to 0.38.2 --- VERSION | 2 +- docs/source/_custom_js/package-lock.json | 2 +- docs/source/about/changelog.rst | 8 ++++++++ src/client/package-lock.json | 8 ++++---- src/client/package.json | 2 +- src/client/packages/idom-app-react/package.json | 2 +- src/client/packages/idom-client-react/package.json | 2 +- src/idom/__init__.py | 2 +- 8 files changed, 18 insertions(+), 10 deletions(-) diff --git a/VERSION b/VERSION index bb22182d4..f2e78d495 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -0.38.1 +0.38.2 diff --git a/docs/source/_custom_js/package-lock.json b/docs/source/_custom_js/package-lock.json index dd27b5c34..f0bc3d471 100644 --- a/docs/source/_custom_js/package-lock.json +++ b/docs/source/_custom_js/package-lock.json @@ -19,7 +19,7 @@ } }, "../../../src/client/packages/idom-client-react": { - "version": "0.38.1", + "version": "0.38.2", "integrity": "sha512-pIK5eNwFSHKXg7ClpASWFVKyZDYxz59MSFpVaX/OqJFkrJaAxBuhKGXNTMXmuyWOL5Iyvb/ErwwDRxQRzMNkfQ==", "license": "MIT", "dependencies": { diff --git a/docs/source/about/changelog.rst b/docs/source/about/changelog.rst index 18d79e621..8e5619f3e 100644 --- a/docs/source/about/changelog.rst +++ b/docs/source/about/changelog.rst @@ -25,6 +25,14 @@ Unreleased No changes. +v0.38.2 +------- +:octicon:`milestone` *released on 2022-06-11* + +**Fixed** + +- ``idom.run`` would fail to run if not specifying a server implementation. + v0.38.1 ------- diff --git a/src/client/package-lock.json b/src/client/package-lock.json index 6f2d44d66..c3e38da42 100644 --- a/src/client/package-lock.json +++ b/src/client/package-lock.json @@ -1,11 +1,11 @@ { "name": "client", - "version": "0.38.1", + "version": "0.38.2", "lockfileVersion": 2, "requires": true, "packages": { "": { - "version": "0.38.1", + "version": "0.38.2", "license": "MIT", "workspaces": [ "./packages/*" @@ -5160,7 +5160,7 @@ } }, "packages/idom-app-react": { - "version": "0.38.1", + "version": "0.38.2", "license": "MIT", "dependencies": { "idom-client-react": "file:packages/idom-client-react", @@ -5176,7 +5176,7 @@ }, "packages/idom-app-react/packages/idom-client-react": {}, "packages/idom-client-react": { - "version": "0.38.1", + "version": "0.38.2", "license": "MIT", "dependencies": { "fast-json-patch": "^3.0.0-1", diff --git a/src/client/package.json b/src/client/package.json index b44cb3400..ecf68ff02 100644 --- a/src/client/package.json +++ b/src/client/package.json @@ -14,7 +14,7 @@ "publish": "npm --workspaces publish", "test": "npm --workspaces test" }, - "version": "0.38.1", + "version": "0.38.2", "workspaces": [ "./packages/*" ] diff --git a/src/client/packages/idom-app-react/package.json b/src/client/packages/idom-app-react/package.json index 8b0df7822..d89d3e638 100644 --- a/src/client/packages/idom-app-react/package.json +++ b/src/client/packages/idom-app-react/package.json @@ -20,5 +20,5 @@ "format": "prettier --write ./src", "test": "echo 'no tests'" }, - "version": "0.38.1" + "version": "0.38.2" } diff --git a/src/client/packages/idom-client-react/package.json b/src/client/packages/idom-client-react/package.json index 7b1ea9856..aa9a24400 100644 --- a/src/client/packages/idom-client-react/package.json +++ b/src/client/packages/idom-client-react/package.json @@ -31,5 +31,5 @@ "test": "uvu tests" }, "type": "module", - "version": "0.38.1" + "version": "0.38.2" } diff --git a/src/idom/__init__.py b/src/idom/__init__.py index e8b0fb4e8..fea39d6fc 100644 --- a/src/idom/__init__.py +++ b/src/idom/__init__.py @@ -22,7 +22,7 @@ __author__ = "idom-team" -__version__ = "0.38.1" # DO NOT MODIFY +__version__ = "0.38.2" # DO NOT MODIFY __all__ = [ "component", From 4d66d500a269729f751751f4415a21babbd071c2 Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Sat, 11 Jun 2022 16:58:56 -0700 Subject: [PATCH 03/11] disable greetings CI until we fix it --- .github/workflows/pr-greetings.yml | 42 +++++++++++++++--------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/workflows/pr-greetings.yml b/.github/workflows/pr-greetings.yml index 619f9bc4a..e654268ee 100644 --- a/.github/workflows/pr-greetings.yml +++ b/.github/workflows/pr-greetings.yml @@ -1,25 +1,25 @@ -name: Greetings Message +# name: Greetings Message -on: - pull_request: - types: [opened, synchronize] +# on: +# pull_request: +# types: [opened, synchronize] -jobs: - GreetCommitter: - runs-on: ubuntu-latest - steps: - - name: "Greetings Message" - uses: ibakshay/greet-contributors-action@v3 - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - with: - content: | - Hello @${{ github.actor }}! Please remember the following: +# jobs: +# GreetCommitter: +# runs-on: ubuntu-latest +# steps: +# - name: "Greetings Message" +# uses: ibakshay/greet-contributors-action@v3 +# env: +# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} +# with: +# content: | +# Hello @${{ github.actor }}! Please remember the following: - - Update the `changelog.rst` if your changes are significant. - - Provide a verbose PR title and description. - - List any GitHub issues that may be closed by this PR. - - Add tests if this PR adds functionality or bugfixes. - - Keep this PR marked as draft until ready for review. +# - Update the `changelog.rst` if your changes are significant. +# - Provide a verbose PR title and description. +# - List any GitHub issues that may be closed by this PR. +# - Add tests if this PR adds functionality or bugfixes. +# - Keep this PR marked as draft until ready for review. - Thank you for your contribution! +# Thank you for your contribution! From 9369aab199eed11675aa055790cf612bda7cfbde Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Sat, 11 Jun 2022 17:09:26 -0700 Subject: [PATCH 04/11] Fix all references to idom.server --- src/idom/backend/fastapi.py | 12 ++++++------ src/idom/backend/flask.py | 2 -- src/idom/backend/starlette.py | 2 -- src/idom/backend/tornado.py | 2 -- src/idom/testing/__init__.py | 4 ++-- src/idom/testing/{server.py => backend.py} | 4 ++-- src/idom/testing/display.py | 16 ++++++++-------- tests/conftest.py | 4 ++-- tests/test_client.py | 6 +++--- tests/test_server/test_common.py | 8 ++++---- tests/test_testing.py | 4 ++-- tests/test_web/test_module.py | 4 ++-- 12 files changed, 31 insertions(+), 37 deletions(-) rename src/idom/testing/{server.py => backend.py} (98%) diff --git a/src/idom/backend/fastapi.py b/src/idom/backend/fastapi.py index e99aad60c..cc8c84580 100644 --- a/src/idom/backend/fastapi.py +++ b/src/idom/backend/fastapi.py @@ -6,25 +6,25 @@ serve_development_app = starlette.serve_development_app -"""Alias for :func:`idom.server.starlette.serve_development_app`""" +"""Alias for :func:`idom.backend.starlette.serve_development_app`""" # see: https://github.com/idom-team/flake8-idom-hooks/issues/12 use_location = starlette.use_location # noqa: ROH101 -"""Alias for :func:`idom.server.starlette.use_location`""" +"""Alias for :func:`idom.backend.starlette.use_location`""" # see: https://github.com/idom-team/flake8-idom-hooks/issues/12 use_scope = starlette.use_scope # noqa: ROH101 -"""Alias for :func:`idom.server.starlette.use_scope`""" +"""Alias for :func:`idom.backend.starlette.use_scope`""" # see: https://github.com/idom-team/flake8-idom-hooks/issues/12 use_websocket = starlette.use_websocket # noqa: ROH101 -"""Alias for :func:`idom.server.starlette.use_websocket`""" +"""Alias for :func:`idom.backend.starlette.use_websocket`""" Options = starlette.Options -"""Alias for :class:`idom.server.starlette.Options`""" +"""Alias for :class:`idom.backend.starlette.Options`""" configure = starlette.configure -"""Alias for :class:`idom.server.starlette.configure`""" +"""Alias for :class:`idom.backend.starlette.configure`""" def create_development_app() -> FastAPI: diff --git a/src/idom/backend/flask.py b/src/idom/backend/flask.py index 6eacbe2c3..d5207db6b 100644 --- a/src/idom/backend/flask.py +++ b/src/idom/backend/flask.py @@ -47,8 +47,6 @@ def configure( ) -> None: """Return a :class:`FlaskServer` where each client has its own state. - Implements the :class:`~idom.server.proto.ServerFactory` protocol - Parameters: constructor: A component constructor options: Options for configuring server behavior diff --git a/src/idom/backend/starlette.py b/src/idom/backend/starlette.py index 5b78c8111..eb5e26837 100644 --- a/src/idom/backend/starlette.py +++ b/src/idom/backend/starlette.py @@ -42,8 +42,6 @@ def configure( ) -> None: """Return a :class:`StarletteServer` where each client has its own state. - Implements the :class:`~idom.server.proto.ServerFactory` protocol - Parameters: app: An application instance constructor: A component constructor diff --git a/src/idom/backend/tornado.py b/src/idom/backend/tornado.py index 113013376..054175378 100644 --- a/src/idom/backend/tornado.py +++ b/src/idom/backend/tornado.py @@ -38,8 +38,6 @@ def configure( ) -> None: """Return a :class:`TornadoServer` where each client has its own state. - Implements the :class:`~idom.server.proto.ServerFactory` protocol - Parameters: app: A tornado ``Application`` instance. component: A root component constructor diff --git a/src/idom/testing/__init__.py b/src/idom/testing/__init__.py index 34d68cb91..9ad1fe6b0 100644 --- a/src/idom/testing/__init__.py +++ b/src/idom/testing/__init__.py @@ -6,7 +6,7 @@ assert_idom_did_not_log, capture_idom_logs, ) -from .server import ServerFixture +from .backend import BackendFixture __all__ = [ @@ -18,6 +18,6 @@ "HookCatcher", "LogAssertionError", "poll", - "ServerFixture", + "BackendFixture", "StaticEventHandler", ] diff --git a/src/idom/testing/server.py b/src/idom/testing/backend.py similarity index 98% rename from src/idom/testing/server.py rename to src/idom/testing/backend.py index 6ca26429b..0234ef669 100644 --- a/src/idom/testing/server.py +++ b/src/idom/testing/backend.py @@ -15,7 +15,7 @@ from .logs import LogAssertionError, capture_idom_logs, list_logged_exceptions -class ServerFixture: +class BackendFixture: """A test fixture for running a server and imperatively displaying views This fixture is typically used alongside async web drivers like ``playwight``. @@ -99,7 +99,7 @@ def list_logged_exceptions( del_log_records, ) - async def __aenter__(self) -> ServerFixture: + async def __aenter__(self) -> BackendFixture: self._exit_stack = AsyncExitStack() self._records = self._exit_stack.enter_context(capture_idom_logs()) diff --git a/src/idom/testing/display.py b/src/idom/testing/display.py index 08f1e8cb1..f5871be2e 100644 --- a/src/idom/testing/display.py +++ b/src/idom/testing/display.py @@ -9,7 +9,7 @@ from idom import html from idom.types import RootComponentConstructor -from .server import ServerFixture +from .backend import BackendFixture class DisplayFixture: @@ -19,11 +19,11 @@ class DisplayFixture: def __init__( self, - server: ServerFixture | None = None, + server: BackendFixture | None = None, driver: Browser | BrowserContext | Page | None = None, ) -> None: if server is not None: - self.server = server + self.backend = server if driver is not None: if isinstance(driver, Page): self.page = driver @@ -37,13 +37,13 @@ async def show( ) -> None: self._next_view_id += 1 view_id = f"display-{self._next_view_id}" - self.server.mount(lambda: html.div({"id": view_id}, component())) + self.backend.mount(lambda: html.div({"id": view_id}, component())) await self.goto("/") await self.page.wait_for_selector(f"#{view_id}", state="attached") async def goto(self, path: str, query: Any | None = None) -> None: - await self.page.goto(self.server.url(path, query)) + await self.page.goto(self.backend.url(path, query)) async def __aenter__(self) -> DisplayFixture: es = self._exit_stack = AsyncExitStack() @@ -58,8 +58,8 @@ async def __aenter__(self) -> DisplayFixture: self.page = await browser.new_page() if not hasattr(self, "server"): - self.server = ServerFixture() - await es.enter_async_context(self.server) + self.backend = BackendFixture() + await es.enter_async_context(self.backend) return self @@ -69,5 +69,5 @@ async def __aexit__( exc_value: BaseException | None, traceback: TracebackType | None, ) -> None: - self.server.mount(None) + self.backend.mount(None) await self._exit_stack.aclose() diff --git a/tests/conftest.py b/tests/conftest.py index 10f92d1bf..79933eaab 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -10,7 +10,7 @@ from idom.config import IDOM_TESTING_DEFAULT_TIMEOUT from idom.testing import ( DisplayFixture, - ServerFixture, + BackendFixture, capture_idom_logs, clear_idom_web_modules_dir, ) @@ -34,7 +34,7 @@ async def display(server, page): @pytest.fixture(scope="session") async def server(): - async with ServerFixture() as server: + async with BackendFixture() as server: yield server diff --git a/tests/test_client.py b/tests/test_client.py index b17d690cc..49d2be576 100644 --- a/tests/test_client.py +++ b/tests/test_client.py @@ -5,7 +5,7 @@ from playwright.async_api import Browser import idom -from idom.testing import DisplayFixture, ServerFixture +from idom.testing import DisplayFixture, BackendFixture JS_DIR = Path(__file__).parent / "js" @@ -22,7 +22,7 @@ def OldComponent(): return idom.html.p({"id": "old-component"}, "old") async with AsyncExitStack() as exit_stack: - server = await exit_stack.enter_async_context(ServerFixture(port=8000)) + server = await exit_stack.enter_async_context(BackendFixture(port=8000)) display = await exit_stack.enter_async_context( DisplayFixture(server, driver=page) ) @@ -43,7 +43,7 @@ def NewComponent(): return idom.html.p({"id": f"new-component-{state}"}, f"new-{state}") async with AsyncExitStack() as exit_stack: - server = await exit_stack.enter_async_context(ServerFixture(port=8000)) + server = await exit_stack.enter_async_context(BackendFixture(port=8000)) display = await exit_stack.enter_async_context( DisplayFixture(server, driver=page) ) diff --git a/tests/test_server/test_common.py b/tests/test_server/test_common.py index 91c6dc41e..7db12301b 100644 --- a/tests/test_server/test_common.py +++ b/tests/test_server/test_common.py @@ -7,7 +7,7 @@ from idom.backend import default as default_implementation from idom.backend.types import Location from idom.backend.utils import all_implementations -from idom.testing import DisplayFixture, ServerFixture, poll +from idom.testing import DisplayFixture, BackendFixture, poll @pytest.fixture( @@ -16,7 +16,7 @@ scope="module", ) async def display(page, request): - async with ServerFixture(implementation=request.param) as server: + async with BackendFixture(implementation=request.param) as server: async with DisplayFixture(server=server, driver=page) as display: yield display @@ -69,7 +69,7 @@ async def test_use_scope(display: DisplayFixture): @idom.component def ShowScope(): - scope.current = display.server.implementation.use_scope() + scope.current = display.backend.implementation.use_scope() return html.pre({"id": "scope"}, str(scope.current)) await display.show(ShowScope) @@ -88,7 +88,7 @@ async def poll_location(): @idom.component def ShowRoute(): - location.current = display.server.implementation.use_location() + location.current = display.backend.implementation.use_location() return html.pre({"id": "scope"}, str(location.current)) await display.show(ShowRoute) diff --git a/tests/test_testing.py b/tests/test_testing.py index f42120f20..902648536 100644 --- a/tests/test_testing.py +++ b/tests/test_testing.py @@ -141,9 +141,9 @@ def test_if_app_is_given_implementation_must_be_too(): ValueError, match=r"If an application instance its corresponding server implementation must be provided too", ): - testing.ServerFixture(app=starlette_implementation.create_development_app()) + testing.BackendFixture(app=starlette_implementation.create_development_app()) - testing.ServerFixture( + testing.BackendFixture( app=starlette_implementation.create_development_app(), implementation=starlette_implementation, ) diff --git a/tests/test_web/test_module.py b/tests/test_web/test_module.py index 5f967be8d..c69698af8 100644 --- a/tests/test_web/test_module.py +++ b/tests/test_web/test_module.py @@ -7,7 +7,7 @@ from idom.backend import sanic as sanic_implementation from idom.testing import ( DisplayFixture, - ServerFixture, + BackendFixture, assert_idom_did_log, assert_idom_did_not_log, poll, @@ -70,7 +70,7 @@ async def test_module_from_url(browser): def ShowSimpleButton(): return SimpleButton({"id": "my-button"}) - async with ServerFixture(app=app, implementation=sanic_implementation) as server: + async with BackendFixture(app=app, implementation=sanic_implementation) as server: async with DisplayFixture(server, browser) as display: await display.show(ShowSimpleButton) From 6659541d1703c7e517218b86732d1abb8c21909c Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Sat, 11 Jun 2022 17:10:38 -0700 Subject: [PATCH 05/11] logger.warn -> logger.warning --- src/idom/backend/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/idom/backend/utils.py b/src/idom/backend/utils.py index b891ec793..35e4e75dd 100644 --- a/src/idom/backend/utils.py +++ b/src/idom/backend/utils.py @@ -35,7 +35,7 @@ def run( implementation: BackendImplementation[Any] | None = None, ) -> None: """Run a component with a development server""" - logger.warn( + logger.warning( "You are running a development server. " "Change this before deploying in production!" ) From 2823c398750ab335b3b60288f43b500fab4cb6df Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Sat, 11 Jun 2022 17:17:08 -0700 Subject: [PATCH 06/11] run isort --- src/idom/testing/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/idom/testing/__init__.py b/src/idom/testing/__init__.py index 9ad1fe6b0..e674e4555 100644 --- a/src/idom/testing/__init__.py +++ b/src/idom/testing/__init__.py @@ -1,3 +1,4 @@ +from .backend import BackendFixture from .common import HookCatcher, StaticEventHandler, clear_idom_web_modules_dir, poll from .display import DisplayFixture from .logs import ( @@ -6,7 +7,6 @@ assert_idom_did_not_log, capture_idom_logs, ) -from .backend import BackendFixture __all__ = [ From eef22977c229876399c41d0bcf1e023464a542ab Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Tue, 14 Jun 2022 03:37:07 -0700 Subject: [PATCH 07/11] run nox format --- tests/conftest.py | 2 +- tests/test_client.py | 2 +- tests/test_server/test_common.py | 2 +- tests/test_web/test_module.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/conftest.py b/tests/conftest.py index 79933eaab..f0400ebf9 100644 --- a/tests/conftest.py +++ b/tests/conftest.py @@ -9,8 +9,8 @@ from idom.config import IDOM_TESTING_DEFAULT_TIMEOUT from idom.testing import ( - DisplayFixture, BackendFixture, + DisplayFixture, capture_idom_logs, clear_idom_web_modules_dir, ) diff --git a/tests/test_client.py b/tests/test_client.py index 49d2be576..86b5a61a7 100644 --- a/tests/test_client.py +++ b/tests/test_client.py @@ -5,7 +5,7 @@ from playwright.async_api import Browser import idom -from idom.testing import DisplayFixture, BackendFixture +from idom.testing import BackendFixture, DisplayFixture JS_DIR = Path(__file__).parent / "js" diff --git a/tests/test_server/test_common.py b/tests/test_server/test_common.py index 7db12301b..9aea2558d 100644 --- a/tests/test_server/test_common.py +++ b/tests/test_server/test_common.py @@ -7,7 +7,7 @@ from idom.backend import default as default_implementation from idom.backend.types import Location from idom.backend.utils import all_implementations -from idom.testing import DisplayFixture, BackendFixture, poll +from idom.testing import BackendFixture, DisplayFixture, poll @pytest.fixture( diff --git a/tests/test_web/test_module.py b/tests/test_web/test_module.py index c69698af8..48b981ba9 100644 --- a/tests/test_web/test_module.py +++ b/tests/test_web/test_module.py @@ -6,8 +6,8 @@ import idom from idom.backend import sanic as sanic_implementation from idom.testing import ( - DisplayFixture, BackendFixture, + DisplayFixture, assert_idom_did_log, assert_idom_did_not_log, poll, From dbcf73afdeca89ae387813174813d26a97192bd5 Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Tue, 14 Jun 2022 03:41:58 -0700 Subject: [PATCH 08/11] fix typos in nox descriptions --- noxfile.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/noxfile.py b/noxfile.py index a3588e164..4c7b402a5 100644 --- a/noxfile.py +++ b/noxfile.py @@ -223,7 +223,7 @@ def test_python_style(session: Session) -> None: @nox.session @apply_standard_pip_upgrades def test_python_build(session: Session) -> None: - """Test whether the Python package can be build for distribution""" + """Test whether the Python package can be built for distribution""" install_requirements_file(session, "build-pkg") session.run("python", "-m", "build", "--sdist", "--wheel", "--outdir", "dist", ".") @@ -268,7 +268,7 @@ def test_javascript_suite(session: Session) -> None: @nox.session @setup_client_env def test_javascript_build(session: Session) -> None: - """Run the Javascript-based test suite and ensure it bundles succesfully""" + """Test whether the Javascript package can be built for distribution""" session.run("npm", "run", "test", external=True) From e61c3d7aad989bd92b6aa051d3d61376f2c59c4c Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Tue, 14 Jun 2022 03:42:38 -0700 Subject: [PATCH 09/11] attempt using event['target'] --- src/idom/widgets.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/idom/widgets.py b/src/idom/widgets.py index a089b9d21..be61697fe 100644 --- a/src/idom/widgets.py +++ b/src/idom/widgets.py @@ -80,7 +80,7 @@ def use_linked_inputs( value, set_value = idom.hooks.use_state(initial_value) def sync_inputs(event: Dict[str, Any]) -> None: - new_value = event["value"] + new_value = event["target"] set_value(new_value) if not new_value and ignore_empty: return None From a025dca1b90407be246c1c1645084c3058e3acc6 Mon Sep 17 00:00:00 2001 From: Archmonger <16909269+Archmonger@users.noreply.github.com> Date: Thu, 16 Jun 2022 15:03:25 -0700 Subject: [PATCH 10/11] Revert "bump to 0.38.2" This reverts commit 38bbb9c4a7375ce8a62c6cebe08dd30b52f3d647. --- VERSION | 2 +- docs/source/_custom_js/package-lock.json | 2 +- docs/source/about/changelog.rst | 8 -------- src/client/package-lock.json | 8 ++++---- src/client/package.json | 2 +- src/client/packages/idom-app-react/package.json | 2 +- src/client/packages/idom-client-react/package.json | 2 +- src/idom/__init__.py | 2 +- 8 files changed, 10 insertions(+), 18 deletions(-) diff --git a/VERSION b/VERSION index f2e78d495..bb22182d4 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -0.38.2 +0.38.1 diff --git a/docs/source/_custom_js/package-lock.json b/docs/source/_custom_js/package-lock.json index f0bc3d471..dd27b5c34 100644 --- a/docs/source/_custom_js/package-lock.json +++ b/docs/source/_custom_js/package-lock.json @@ -19,7 +19,7 @@ } }, "../../../src/client/packages/idom-client-react": { - "version": "0.38.2", + "version": "0.38.1", "integrity": "sha512-pIK5eNwFSHKXg7ClpASWFVKyZDYxz59MSFpVaX/OqJFkrJaAxBuhKGXNTMXmuyWOL5Iyvb/ErwwDRxQRzMNkfQ==", "license": "MIT", "dependencies": { diff --git a/docs/source/about/changelog.rst b/docs/source/about/changelog.rst index 8e5619f3e..18d79e621 100644 --- a/docs/source/about/changelog.rst +++ b/docs/source/about/changelog.rst @@ -25,14 +25,6 @@ Unreleased No changes. -v0.38.2 -------- -:octicon:`milestone` *released on 2022-06-11* - -**Fixed** - -- ``idom.run`` would fail to run if not specifying a server implementation. - v0.38.1 ------- diff --git a/src/client/package-lock.json b/src/client/package-lock.json index c3e38da42..6f2d44d66 100644 --- a/src/client/package-lock.json +++ b/src/client/package-lock.json @@ -1,11 +1,11 @@ { "name": "client", - "version": "0.38.2", + "version": "0.38.1", "lockfileVersion": 2, "requires": true, "packages": { "": { - "version": "0.38.2", + "version": "0.38.1", "license": "MIT", "workspaces": [ "./packages/*" @@ -5160,7 +5160,7 @@ } }, "packages/idom-app-react": { - "version": "0.38.2", + "version": "0.38.1", "license": "MIT", "dependencies": { "idom-client-react": "file:packages/idom-client-react", @@ -5176,7 +5176,7 @@ }, "packages/idom-app-react/packages/idom-client-react": {}, "packages/idom-client-react": { - "version": "0.38.2", + "version": "0.38.1", "license": "MIT", "dependencies": { "fast-json-patch": "^3.0.0-1", diff --git a/src/client/package.json b/src/client/package.json index ecf68ff02..b44cb3400 100644 --- a/src/client/package.json +++ b/src/client/package.json @@ -14,7 +14,7 @@ "publish": "npm --workspaces publish", "test": "npm --workspaces test" }, - "version": "0.38.2", + "version": "0.38.1", "workspaces": [ "./packages/*" ] diff --git a/src/client/packages/idom-app-react/package.json b/src/client/packages/idom-app-react/package.json index d89d3e638..8b0df7822 100644 --- a/src/client/packages/idom-app-react/package.json +++ b/src/client/packages/idom-app-react/package.json @@ -20,5 +20,5 @@ "format": "prettier --write ./src", "test": "echo 'no tests'" }, - "version": "0.38.2" + "version": "0.38.1" } diff --git a/src/client/packages/idom-client-react/package.json b/src/client/packages/idom-client-react/package.json index aa9a24400..7b1ea9856 100644 --- a/src/client/packages/idom-client-react/package.json +++ b/src/client/packages/idom-client-react/package.json @@ -31,5 +31,5 @@ "test": "uvu tests" }, "type": "module", - "version": "0.38.2" + "version": "0.38.1" } diff --git a/src/idom/__init__.py b/src/idom/__init__.py index fea39d6fc..e8b0fb4e8 100644 --- a/src/idom/__init__.py +++ b/src/idom/__init__.py @@ -22,7 +22,7 @@ __author__ = "idom-team" -__version__ = "0.38.2" # DO NOT MODIFY +__version__ = "0.38.1" # DO NOT MODIFY __all__ = [ "component", From 569788af56b63626afd1fc9ce2c0b3a382460803 Mon Sep 17 00:00:00 2001 From: Ryan Morshead Date: Thu, 16 Jun 2022 16:44:57 -0700 Subject: [PATCH 11/11] one last server->backend --- src/idom/testing/display.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/idom/testing/display.py b/src/idom/testing/display.py index f5871be2e..cbeda6bba 100644 --- a/src/idom/testing/display.py +++ b/src/idom/testing/display.py @@ -57,7 +57,7 @@ async def __aenter__(self) -> DisplayFixture: browser = self._browser self.page = await browser.new_page() - if not hasattr(self, "server"): + if not hasattr(self, "backend"): self.backend = BackendFixture() await es.enter_async_context(self.backend)