Skip to content

Commit 605520e

Browse files
committed
Add a comment explaining the flagging of pure MLKEM groups as yellow. #331
1 parent bf95ca9 commit 605520e

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

sslscan.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5674,6 +5674,13 @@ int testSupportedGroups(struct sslCheckOptions *options) {
56745674
{0x0102, "ffdhe4096", 150, COL_PLAIN, NID_ffdhe4096, NID_TYPE_DHE, 512},
56755675
{0x0103, "ffdhe6144", 175, COL_PLAIN, NID_ffdhe6144, NID_TYPE_DHE, 768},
56765676
{0x0104, "ffdhe8192", 192, COL_PLAIN, NID_ffdhe8192, NID_TYPE_DHE, 1024},
5677+
/* There are no demonstrated weaknesses with the pure MLKEM groups.
5678+
* But they've only very recently been standardised, and the implemenations
5679+
* haven't really been battle-proved to the extent of other groups.
5680+
* As such, they've flagged in yellow for now, but this should be reconsidered:
5681+
* - In a couple of years (2027)
5682+
* - If any significant weaknesses are identified
5683+
* - If they're considered robust by projects like OpenSSH or OpenSSL */
56775684
{0x0200, "MLKEM512", 128, COL_YELLOW, -1, NID_TYPE_MLKEM512, 800},
56785685
{0x0201, "MLKEM768", 192, COL_YELLOW, -1, NID_TYPE_MLKEM768, 1184},
56795686
{0x0202, "MLKEM1024", 256, COL_YELLOW, -1, NID_TYPE_MLKEM1024, 1568},

0 commit comments

Comments
 (0)