Skip to content

Implement client facing theme #95

@Jipperism

Description

@Jipperism

Starting work on implementing the client facing theme. Some questions, which we may have partially answered already but good to leave a written down version so it's available to everybody.

  • What developer experience do we envision. From the way it's currently build, I don't think merely swapping out the theme/wrapping the component in a separate provider will be sufficient, as not all styling is done entirely through the theme (for example, in some composed components like Card.tsx. In our previous call, I think we decided to duplicate components as well as providing a raidguild/client theme. The downside of this approach is that developers will be required to import the correct components from eg @raidguild/design-system/rg and @raidguild/design-system/client. The upside is that we don't have to rewrite anything that's already there.
  • Do we expect to see components from both sets side-by-side? In separate stories, under dropdowns for rg/client? It's pretty straightforward to show them side-by-side as the theme is currently only passed in through the global storybook parmas, which can also be defined on a story or component level (see the docs).

Pinging @scottrepreneur and @bitbeckers

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions