Skip to content

Commit def9a55

Browse files
committed
Fix #5 Add missing sonar.basePlugin property
1 parent c5515ca commit def9a55

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ This sample plugin is designed to help you get started writing your own plugin a
3232
* Create a [standard SonarQube plugin](https://docs.sonarqube.org/display/DEV/Build+Plugin) from scratch or start from this sample plugin
3333
* Attach this plugin to the SonarQube CSS / SCSS / Less plugin through the [POM](sonar-csscustomrules-plugin/pom.xml):
3434
* Add the [dependency](sonar-csscustomrules-plugin/pom.xml#L33) to the CSS / SCSS / Less plugin
35-
* [Require a minimal version of the CSS / SCSS / Less plugin](sonar-csscustomrules-plugin/pom.xml#L22)
35+
* [Base the plugin on the CSS / SCSS / Less plugin](sonar-csscustomrules-plugin/pom.xml#L22)
36+
* [Require a minimal version of the CSS / SCSS / Less plugin](sonar-csscustomrules-plugin/pom.xml#L23)
3637
* Implement the following extension points:
3738
* [Plugin](http://javadocs.sonarsource.org/latest/apidocs/index.html?org/sonar/api/Plugin.html) as in [`MyCssCustomRulesPlugin.java`](sonar-csscustomrules-plugin/src/main/java/org/sonar/css/MyCssCustomRulesPlugin.java)
3839
* [RulesDefinition](http://javadocs.sonarsource.org/latest/apidocs/index.html?org/sonar/api/server/rule/RulesDefinition.html) as in [`MyCssCustomRulesDefinition.java`](sonar-csscustomrules-plugin/src/main/java/org/sonar/css/MyCssCustomRulesDefinition.java)

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<packaging>pom</packaging>
1616

1717
<name>SonarQube CSS / SCSS / Less Custom Rules Plugin</name>
18-
<description>Sample plugin that defines SonarQube custom rules for CSS / SCSS / Less files</description>
18+
<description>Sample plugin that defines custom CSS / SCSS / Less rules</description>
1919
<url>https://github.com/racodond/sonar-css-custom-rules-plugin</url>
2020
<inceptionYear>2016</inceptionYear>
2121
<organization>

sonar-csscustomrules-plugin/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,13 @@
1313
<packaging>sonar-plugin</packaging>
1414

1515
<name>CSS / SCSS / Less Custom Rules Plugin</name>
16-
<description>Sample plugin that defines SonarQube custom rules for CSS / SCSS / Less files</description>
16+
<description>Sample plugin that defines custom CSS / SCSS / Less rules</description>
1717
<url>https://github.com/racodond/sonar-css-custom-rules-plugin</url>
1818

1919
<properties>
2020
<sonar.pluginName>CSS / SCSS / Less Custom Rules</sonar.pluginName>
2121
<sonar.pluginClass>org.sonar.css.MyCssCustomRulesPlugin</sonar.pluginClass>
22+
<sonar.basePlugin>css</sonar.basePlugin>
2223
<sonar.requirePlugins>css:4.13</sonar.requirePlugins>
2324
</properties>
2425

0 commit comments

Comments
 (0)