From 33abfb4094cd3981daf7e28fe4fe419149833ff9 Mon Sep 17 00:00:00 2001 From: Kevin Kirsche Date: Mon, 22 Aug 2022 08:53:15 -0400 Subject: [PATCH 01/10] refactor: expand types in xml module --- stdlib/xml/dom/minidom.pyi | 68 +++++++++++++++++++------------------- stdlib/xml/sax/handler.pyi | 7 ++-- 2 files changed, 38 insertions(+), 37 deletions(-) diff --git a/stdlib/xml/dom/minidom.pyi b/stdlib/xml/dom/minidom.pyi index b3d951752fca..546b09641739 100644 --- a/stdlib/xml/dom/minidom.pyi +++ b/stdlib/xml/dom/minidom.pyi @@ -1,6 +1,6 @@ import sys import xml.dom -from _typeshed import Self, SupportsRead +from _typeshed import Incomplete, Self, SupportsRead from typing import Any from typing_extensions import Literal from xml.dom.xmlbuilder import DocumentLS, DOMImplementationLS @@ -25,11 +25,11 @@ class Node(xml.dom.Node): def localName(self) -> str | None: ... def __bool__(self) -> Literal[True]: ... if sys.version_info >= (3, 9): - def toxml(self, encoding: Any | None = ..., standalone: Any | None = ...): ... - def toprettyxml(self, indent: str = ..., newl: str = ..., encoding: Any | None = ..., standalone: Any | None = ...): ... + def toxml(self, encoding: str | None = ..., standalone: bool | None = ...): ... + def toprettyxml(self, indent: str = ..., newl: str = ..., encoding: str | None = ..., standalone: bool | None = ...): ... else: - def toxml(self, encoding: Any | None = ...): ... - def toprettyxml(self, indent: str = ..., newl: str = ..., encoding: Any | None = ...): ... + def toxml(self, encoding: str | None = ...): ... + def toprettyxml(self, indent: str = ..., newl: str = ..., encoding: str | None = ...): ... def hasChildNodes(self) -> bool: ... def insertBefore(self, newChild, refChild): ... @@ -70,7 +70,7 @@ class Attr(Node): value: str prefix: Any def __init__( - self, qName: str, namespaceURI: str | None = ..., localName: Any | None = ..., prefix: Any | None = ... + self, qName: str, namespaceURI: str | None = ..., localName: str | None = ..., prefix: Any | None = ... ) -> None: ... def unlink(self) -> None: ... @property @@ -87,31 +87,31 @@ class NamedNodeMap: def keys(self): ... def keysNS(self): ... def values(self): ... - def get(self, name, value: Any | None = ...): ... + def get(self, name: str, value: Any | None = ...): ... def __len__(self) -> int: ... def __eq__(self, other: object) -> bool: ... - def __ge__(self, other: Any) -> bool: ... - def __gt__(self, other: Any) -> bool: ... - def __le__(self, other: Any) -> bool: ... - def __lt__(self, other: Any) -> bool: ... - def __getitem__(self, attname_or_tuple): ... - def __setitem__(self, attname, value) -> None: ... - def getNamedItem(self, name): ... - def getNamedItemNS(self, namespaceURI: str, localName): ... - def removeNamedItem(self, name): ... - def removeNamedItemNS(self, namespaceURI: str, localName): ... - def setNamedItem(self, node): ... - def setNamedItemNS(self, node): ... - def __delitem__(self, attname_or_tuple) -> None: ... + def __ge__(self, other: object) -> bool: ... + def __gt__(self, other: object) -> bool: ... + def __le__(self, other: object) -> bool: ... + def __lt__(self, other: object) -> bool: ... + def __getitem__(self, name_or_tuple: tuple[str, str | None] | str) -> Attr | None: ... + def __setitem__(self, attname: str, value: Attr | str) -> None: ... + def getNamedItem(self, name: str) -> Attr | None: ... + def getNamedItemNS(self, namespaceURI: str, localName: str | None) -> Attr | None: ... + def removeNamedItem(self, name: str) -> Attr: ... + def removeNamedItemNS(self, namespaceURI: str, localName: str | None): ... + def setNamedItem(self, node: Attr) -> Attr: ... + def setNamedItemNS(self, node: Attr) -> Attr: ... + def __delitem__(self, attname_or_tuple: str) -> None: ... @property def length(self) -> int: ... AttributeList = NamedNodeMap class TypeInfo: - namespace: Any - name: Any - def __init__(self, namespace, name) -> None: ... + namespace: Incomplete | None + name: str + def __init__(self, namespace: Incomplete | None, name: str) -> None: ... class Element(Node): nodeType: int @@ -290,13 +290,13 @@ class Document(Node, DocumentLS): previousSibling: Any nextSibling: Any actualEncoding: Any - encoding: Any - standalone: Any + encoding: str | None + standalone: bool | None version: Any strictErrorChecking: bool errorHandler: Any documentURI: Any - doctype: Any + doctype: DocumentType | None childNodes: Any def __init__(self) -> None: ... def appendChild(self, node): ... @@ -304,11 +304,11 @@ class Document(Node, DocumentLS): def removeChild(self, oldChild): ... def unlink(self) -> None: ... def cloneNode(self, deep): ... - def createDocumentFragment(self): ... - def createElement(self, tagName: str): ... - def createTextNode(self, data): ... - def createCDATASection(self, data): ... - def createComment(self, data): ... + def createDocumentFragment(self) -> DocumentFragment: ... + def createElement(self, tagName: str) -> Element: ... + def createTextNode(self, data: str) -> Text: ... + def createCDATASection(self, data: str) -> CDATASection: ... + def createComment(self, data: Incomplete) -> Comment: ... def createProcessingInstruction(self, target, data): ... def createAttribute(self, qName) -> Attr: ... def createElementNS(self, namespaceURI: str, qualifiedName: str): ... @@ -316,7 +316,7 @@ class Document(Node, DocumentLS): def getElementById(self, id): ... def getElementsByTagName(self, name: str): ... def getElementsByTagNameNS(self, namespaceURI: str, localName): ... - def isSupported(self, feature, version): ... + def isSupported(self, feature: str, version: str | None) -> bool: ... def importNode(self, node, deep): ... if sys.version_info >= (3, 9): def writexml( @@ -325,8 +325,8 @@ class Document(Node, DocumentLS): indent: str = ..., addindent: str = ..., newl: str = ..., - encoding: Any | None = ..., - standalone: Any | None = ..., + encoding: str | None = ..., + standalone: bool | None = ..., ) -> None: ... else: def writexml( diff --git a/stdlib/xml/sax/handler.pyi b/stdlib/xml/sax/handler.pyi index abf124f836cd..7aeb41405e04 100644 --- a/stdlib/xml/sax/handler.pyi +++ b/stdlib/xml/sax/handler.pyi @@ -1,11 +1,12 @@ import sys +from typing import NoReturn version: str class ErrorHandler: - def error(self, exception): ... - def fatalError(self, exception): ... - def warning(self, exception): ... + def error(self, exception: BaseException) -> NoReturn: ... + def fatalError(self, exception: BaseException) -> NoReturn: ... + def warning(self, exception: BaseException) -> None: ... class ContentHandler: def __init__(self) -> None: ... From 0e325b53e13fa5b828584ecdaf91dac0bb060842 Mon Sep 17 00:00:00 2001 From: Kevin Kirsche Date: Mon, 22 Aug 2022 08:55:58 -0400 Subject: [PATCH 02/10] fix: add types for writer --- stdlib/xml/dom/minidom.pyi | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/stdlib/xml/dom/minidom.pyi b/stdlib/xml/dom/minidom.pyi index 546b09641739..818d05cad7fa 100644 --- a/stdlib/xml/dom/minidom.pyi +++ b/stdlib/xml/dom/minidom.pyi @@ -1,11 +1,14 @@ +from io import StringIO, TextIOWrapper import sys import xml.dom from _typeshed import Incomplete, Self, SupportsRead -from typing import Any +from typing import Any, TypeAlias from typing_extensions import Literal from xml.dom.xmlbuilder import DocumentLS, DOMImplementationLS from xml.sax.xmlreader import XMLReader +_Writer: TypeAlias = StringIO | TextIOWrapper + def parse(file: str | SupportsRead[bytes] | SupportsRead[str], parser: XMLReader | None = ..., bufsize: int | None = ...): ... def parseString(string: str | bytes, parser: XMLReader | None = ...): ... def getDOMImplementation(features=...) -> DOMImplementation | None: ... @@ -144,7 +147,7 @@ class Element(Node): def hasAttributeNS(self, namespaceURI: str, localName) -> bool: ... def getElementsByTagName(self, name: str): ... def getElementsByTagNameNS(self, namespaceURI: str, localName): ... - def writexml(self, writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... def hasAttributes(self) -> bool: ... def setIdAttribute(self, name) -> None: ... def setIdAttributeNS(self, namespaceURI: str, localName) -> None: ... @@ -171,7 +174,7 @@ class ProcessingInstruction(Childless, Node): def __init__(self, target, data) -> None: ... nodeValue: Any nodeName: Any - def writexml(self, writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... class CharacterData(Childless, Node): ownerDocument: Any @@ -194,7 +197,7 @@ class Text(CharacterData): attributes: Any data: Any def splitText(self, offset): ... - def writexml(self, writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... def replaceWholeText(self, content): ... @property def isWhitespaceInElementContent(self) -> bool: ... @@ -205,12 +208,12 @@ class Comment(CharacterData): nodeType: int nodeName: str def __init__(self, data) -> None: ... - def writexml(self, writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... class CDATASection(Text): nodeType: int nodeName: str - def writexml(self, writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... class ReadOnlySequentialNamedNodeMap: def __init__(self, seq=...) -> None: ... @@ -240,7 +243,7 @@ class DocumentType(Identified, Childless, Node): nodeName: Any def __init__(self, qualifiedName: str) -> None: ... def cloneNode(self, deep): ... - def writexml(self, writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... class Entity(Identified, Node): attributes: Any @@ -321,7 +324,7 @@ class Document(Node, DocumentLS): if sys.version_info >= (3, 9): def writexml( self, - writer, + writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ..., @@ -330,7 +333,7 @@ class Document(Node, DocumentLS): ) -> None: ... else: def writexml( - self, writer, indent: str = ..., addindent: str = ..., newl: str = ..., encoding: Any | None = ... + self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ..., encoding: Any | None = ... ) -> None: ... def renameNode(self, n, namespaceURI: str, name): ... From 73260cd895ac20402acce665e8d562f79d4dc853 Mon Sep 17 00:00:00 2001 From: Kevin Kirsche Date: Mon, 22 Aug 2022 09:02:57 -0400 Subject: [PATCH 03/10] revert getitem as unsure --- stdlib/xml/dom/minidom.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stdlib/xml/dom/minidom.pyi b/stdlib/xml/dom/minidom.pyi index 818d05cad7fa..c901c6cb1f1a 100644 --- a/stdlib/xml/dom/minidom.pyi +++ b/stdlib/xml/dom/minidom.pyi @@ -97,7 +97,7 @@ class NamedNodeMap: def __gt__(self, other: object) -> bool: ... def __le__(self, other: object) -> bool: ... def __lt__(self, other: object) -> bool: ... - def __getitem__(self, name_or_tuple: tuple[str, str | None] | str) -> Attr | None: ... + def __getitem__(self, attname_or_tuple): ... def __setitem__(self, attname: str, value: Attr | str) -> None: ... def getNamedItem(self, name: str) -> Attr | None: ... def getNamedItemNS(self, namespaceURI: str, localName: str | None) -> Attr | None: ... From 4188badfc6c6a4e7ecafb0d739b9df312532c64b Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 22 Aug 2022 13:08:35 +0000 Subject: [PATCH 04/10] [pre-commit.ci] auto fixes from pre-commit.com hooks --- stdlib/xml/dom/minidom.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stdlib/xml/dom/minidom.pyi b/stdlib/xml/dom/minidom.pyi index c901c6cb1f1a..37c4c66ab30c 100644 --- a/stdlib/xml/dom/minidom.pyi +++ b/stdlib/xml/dom/minidom.pyi @@ -1,7 +1,7 @@ -from io import StringIO, TextIOWrapper import sys import xml.dom from _typeshed import Incomplete, Self, SupportsRead +from io import StringIO, TextIOWrapper from typing import Any, TypeAlias from typing_extensions import Literal from xml.dom.xmlbuilder import DocumentLS, DOMImplementationLS From 3de35db61c69b6e29a526b87c8ebd28fc78720ab Mon Sep 17 00:00:00 2001 From: Kevin Kirsche Date: Mon, 22 Aug 2022 09:09:10 -0400 Subject: [PATCH 05/10] fix: import location of TypeAlias --- stdlib/xml/dom/minidom.pyi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/stdlib/xml/dom/minidom.pyi b/stdlib/xml/dom/minidom.pyi index 37c4c66ab30c..453bfccb8582 100644 --- a/stdlib/xml/dom/minidom.pyi +++ b/stdlib/xml/dom/minidom.pyi @@ -2,8 +2,8 @@ import sys import xml.dom from _typeshed import Incomplete, Self, SupportsRead from io import StringIO, TextIOWrapper -from typing import Any, TypeAlias -from typing_extensions import Literal +from typing import Any +from typing_extensions import Literal, TypeAlias from xml.dom.xmlbuilder import DocumentLS, DOMImplementationLS from xml.sax.xmlreader import XMLReader From e9c33a626dab3169c96ca563271b6ff64a3bb066 Mon Sep 17 00:00:00 2001 From: Kevin Kirsche Date: Mon, 22 Aug 2022 10:14:22 -0400 Subject: [PATCH 06/10] fix: https://github.com/python/typeshed/pull/8590#discussion_r951483472 --- stdlib/xml/dom/minidom.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stdlib/xml/dom/minidom.pyi b/stdlib/xml/dom/minidom.pyi index 453bfccb8582..529cf73c7b5f 100644 --- a/stdlib/xml/dom/minidom.pyi +++ b/stdlib/xml/dom/minidom.pyi @@ -311,7 +311,7 @@ class Document(Node, DocumentLS): def createElement(self, tagName: str) -> Element: ... def createTextNode(self, data: str) -> Text: ... def createCDATASection(self, data: str) -> CDATASection: ... - def createComment(self, data: Incomplete) -> Comment: ... + def createComment(self, data: str) -> Comment: ... def createProcessingInstruction(self, target, data): ... def createAttribute(self, qName) -> Attr: ... def createElementNS(self, namespaceURI: str, qualifiedName: str): ... From a21a18a6097c6500c96b9643062e4051bfe173a1 Mon Sep 17 00:00:00 2001 From: Kevin Kirsche Date: Mon, 22 Aug 2022 10:15:47 -0400 Subject: [PATCH 07/10] fix: https://github.com/python/typeshed/pull/8590#discussion_r951480967 --- stdlib/xml/dom/minidom.pyi | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/stdlib/xml/dom/minidom.pyi b/stdlib/xml/dom/minidom.pyi index 529cf73c7b5f..1f5ecb11b5de 100644 --- a/stdlib/xml/dom/minidom.pyi +++ b/stdlib/xml/dom/minidom.pyi @@ -1,14 +1,11 @@ import sys import xml.dom -from _typeshed import Incomplete, Self, SupportsRead -from io import StringIO, TextIOWrapper +from _typeshed import Incomplete, Self, SupportsRead, SupportsWrite from typing import Any -from typing_extensions import Literal, TypeAlias +from typing_extensions import Literal from xml.dom.xmlbuilder import DocumentLS, DOMImplementationLS from xml.sax.xmlreader import XMLReader -_Writer: TypeAlias = StringIO | TextIOWrapper - def parse(file: str | SupportsRead[bytes] | SupportsRead[str], parser: XMLReader | None = ..., bufsize: int | None = ...): ... def parseString(string: str | bytes, parser: XMLReader | None = ...): ... def getDOMImplementation(features=...) -> DOMImplementation | None: ... @@ -147,7 +144,7 @@ class Element(Node): def hasAttributeNS(self, namespaceURI: str, localName) -> bool: ... def getElementsByTagName(self, name: str): ... def getElementsByTagNameNS(self, namespaceURI: str, localName): ... - def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: SupportsWrite[str], indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... def hasAttributes(self) -> bool: ... def setIdAttribute(self, name) -> None: ... def setIdAttributeNS(self, namespaceURI: str, localName) -> None: ... @@ -174,7 +171,7 @@ class ProcessingInstruction(Childless, Node): def __init__(self, target, data) -> None: ... nodeValue: Any nodeName: Any - def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: SupportsWrite[str], indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... class CharacterData(Childless, Node): ownerDocument: Any @@ -197,7 +194,7 @@ class Text(CharacterData): attributes: Any data: Any def splitText(self, offset): ... - def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: SupportsWrite[str], indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... def replaceWholeText(self, content): ... @property def isWhitespaceInElementContent(self) -> bool: ... @@ -208,12 +205,12 @@ class Comment(CharacterData): nodeType: int nodeName: str def __init__(self, data) -> None: ... - def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: SupportsWrite[str], indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... class CDATASection(Text): nodeType: int nodeName: str - def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: SupportsWrite[str], indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... class ReadOnlySequentialNamedNodeMap: def __init__(self, seq=...) -> None: ... @@ -243,7 +240,7 @@ class DocumentType(Identified, Childless, Node): nodeName: Any def __init__(self, qualifiedName: str) -> None: ... def cloneNode(self, deep): ... - def writexml(self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... + def writexml(self, writer: SupportsWrite[str], indent: str = ..., addindent: str = ..., newl: str = ...) -> None: ... class Entity(Identified, Node): attributes: Any @@ -324,7 +321,7 @@ class Document(Node, DocumentLS): if sys.version_info >= (3, 9): def writexml( self, - writer: _Writer, + writer: SupportsWrite[str], indent: str = ..., addindent: str = ..., newl: str = ..., @@ -333,7 +330,7 @@ class Document(Node, DocumentLS): ) -> None: ... else: def writexml( - self, writer: _Writer, indent: str = ..., addindent: str = ..., newl: str = ..., encoding: Any | None = ... + self, writer: SupportsWrite[str], indent: str = ..., addindent: str = ..., newl: str = ..., encoding: Any | None = ... ) -> None: ... def renameNode(self, n, namespaceURI: str, name): ... From b52553f455c6c6fdfe26eac28cd0b74676ffb362 Mon Sep 17 00:00:00 2001 From: Kevin Kirsche Date: Mon, 22 Aug 2022 10:19:11 -0400 Subject: [PATCH 08/10] fix: https://github.com/python/typeshed/pull/8590#discussion_r951478161 --- stdlib/xml/dom/minidom.pyi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/stdlib/xml/dom/minidom.pyi b/stdlib/xml/dom/minidom.pyi index 1f5ecb11b5de..70f111eaa2e8 100644 --- a/stdlib/xml/dom/minidom.pyi +++ b/stdlib/xml/dom/minidom.pyi @@ -94,7 +94,7 @@ class NamedNodeMap: def __gt__(self, other: object) -> bool: ... def __le__(self, other: object) -> bool: ... def __lt__(self, other: object) -> bool: ... - def __getitem__(self, attname_or_tuple): ... + def __getitem__(self, attname_or_tuple: tuple[str, str | None] | str): ... def __setitem__(self, attname: str, value: Attr | str) -> None: ... def getNamedItem(self, name: str) -> Attr | None: ... def getNamedItemNS(self, namespaceURI: str, localName: str | None) -> Attr | None: ... @@ -102,7 +102,7 @@ class NamedNodeMap: def removeNamedItemNS(self, namespaceURI: str, localName: str | None): ... def setNamedItem(self, node: Attr) -> Attr: ... def setNamedItemNS(self, node: Attr) -> Attr: ... - def __delitem__(self, attname_or_tuple: str) -> None: ... + def __delitem__(self, attname_or_tuple: tuple[str, str | None] | str) -> None: ... @property def length(self) -> int: ... From 6d5ac3afa9c4bc5003932bad0d6032088ae85564 Mon Sep 17 00:00:00 2001 From: Kevin Kirsche Date: Mon, 22 Aug 2022 11:05:30 -0400 Subject: [PATCH 09/10] fix: https://github.com/python/typeshed/pull/8590#discussion_r951505188 --- stdlib/xml/dom/minidom.pyi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/stdlib/xml/dom/minidom.pyi b/stdlib/xml/dom/minidom.pyi index 70f111eaa2e8..8fe6b160445c 100644 --- a/stdlib/xml/dom/minidom.pyi +++ b/stdlib/xml/dom/minidom.pyi @@ -89,11 +89,11 @@ class NamedNodeMap: def values(self): ... def get(self, name: str, value: Any | None = ...): ... def __len__(self) -> int: ... - def __eq__(self, other: object) -> bool: ... - def __ge__(self, other: object) -> bool: ... - def __gt__(self, other: object) -> bool: ... - def __le__(self, other: object) -> bool: ... - def __lt__(self, other: object) -> bool: ... + def __eq__(self, other: NamedNodeMap) -> bool: ... + def __ge__(self, other: NamedNodeMap) -> bool: ... + def __gt__(self, other: NamedNodeMap) -> bool: ... + def __le__(self, other: NamedNodeMap) -> bool: ... + def __lt__(self, other: NamedNodeMap) -> bool: ... def __getitem__(self, attname_or_tuple: tuple[str, str | None] | str): ... def __setitem__(self, attname: str, value: Attr | str) -> None: ... def getNamedItem(self, name: str) -> Attr | None: ... From 0a14966456934b8cec0127c1e8fc748cb7fc89b3 Mon Sep 17 00:00:00 2001 From: Kevin Kirsche Date: Mon, 22 Aug 2022 11:10:49 -0400 Subject: [PATCH 10/10] fix: incorrect value compared to supertype --- stdlib/xml/dom/minidom.pyi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stdlib/xml/dom/minidom.pyi b/stdlib/xml/dom/minidom.pyi index 8fe6b160445c..47ec2dd18e4c 100644 --- a/stdlib/xml/dom/minidom.pyi +++ b/stdlib/xml/dom/minidom.pyi @@ -89,7 +89,7 @@ class NamedNodeMap: def values(self): ... def get(self, name: str, value: Any | None = ...): ... def __len__(self) -> int: ... - def __eq__(self, other: NamedNodeMap) -> bool: ... + def __eq__(self, other: object) -> bool: ... def __ge__(self, other: NamedNodeMap) -> bool: ... def __gt__(self, other: NamedNodeMap) -> bool: ... def __le__(self, other: NamedNodeMap) -> bool: ...