From 11a39c10abaa80a2ccf9fc97e4169b79bad9ec1b Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Wed, 22 Jun 2022 22:31:22 +0200 Subject: [PATCH 1/3] gh-84623: Remove unused imports in idlelib Remove commented code in test_debugger_r.py --- Lib/idlelib/idle_test/test_debugger_r.py | 12 ------------ Lib/idlelib/idle_test/test_editor.py | 1 - Lib/idlelib/iomenu.py | 1 - 3 files changed, 14 deletions(-) diff --git a/Lib/idlelib/idle_test/test_debugger_r.py b/Lib/idlelib/idle_test/test_debugger_r.py index 638ebd36a7405d..d2765152b80a07 100644 --- a/Lib/idlelib/idle_test/test_debugger_r.py +++ b/Lib/idlelib/idle_test/test_debugger_r.py @@ -2,22 +2,10 @@ from idlelib import debugger_r import unittest -from test.support import requires -from tkinter import Tk class Test(unittest.TestCase): -## @classmethod -## def setUpClass(cls): -## requires('gui') -## cls.root = Tk() -## -## @classmethod -## def tearDownClass(cls): -## cls.root.destroy() -## del cls.root - def test_init(self): self.assertTrue(True) # Get coverage of import diff --git a/Lib/idlelib/idle_test/test_editor.py b/Lib/idlelib/idle_test/test_editor.py index 8665d680c0118f..fdb47abf43fb77 100644 --- a/Lib/idlelib/idle_test/test_editor.py +++ b/Lib/idlelib/idle_test/test_editor.py @@ -5,7 +5,6 @@ from collections import namedtuple from test.support import requires from tkinter import Tk -from idlelib.idle_test.mock_idle import Func Editor = editor.EditorWindow diff --git a/Lib/idlelib/iomenu.py b/Lib/idlelib/iomenu.py index ad3109df84096a..2ef42f8c950042 100644 --- a/Lib/idlelib/iomenu.py +++ b/Lib/idlelib/iomenu.py @@ -9,7 +9,6 @@ from tkinter import messagebox from tkinter.simpledialog import askstring -import idlelib from idlelib.config import idleConf from idlelib.util import py_extensions From aa128d6a8bb27ed4c1bdbd0d76c9e32887234433 Mon Sep 17 00:00:00 2001 From: Terry Jan Reedy Date: Wed, 22 Jun 2022 17:01:30 -0400 Subject: [PATCH 2/3] Remove extra blank line --- Lib/idlelib/iomenu.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Lib/idlelib/iomenu.py b/Lib/idlelib/iomenu.py index 2ef42f8c950042..86ce68c06a4470 100644 --- a/Lib/idlelib/iomenu.py +++ b/Lib/idlelib/iomenu.py @@ -20,8 +20,7 @@ else: errors = 'surrogateescape' - - + class IOBinding: # One instance per editor Window so methods know which to save, close. # Open returns focus to self.editwin if aborted. From 4bbc8466e706da27a3a054942c50d275b9eabfc1 Mon Sep 17 00:00:00 2001 From: Terry Jan Reedy Date: Wed, 22 Jun 2022 17:23:39 -0400 Subject: [PATCH 3/3] Update test_debugger_r.py --- Lib/idlelib/idle_test/test_debugger_r.py | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/Lib/idlelib/idle_test/test_debugger_r.py b/Lib/idlelib/idle_test/test_debugger_r.py index d2765152b80a07..cf8af05fe27e77 100644 --- a/Lib/idlelib/idle_test/test_debugger_r.py +++ b/Lib/idlelib/idle_test/test_debugger_r.py @@ -3,15 +3,20 @@ from idlelib import debugger_r import unittest - -class Test(unittest.TestCase): - - def test_init(self): - self.assertTrue(True) # Get coverage of import - - -# Classes GUIProxy, IdbAdapter, FrameProxy, CodeProxy, DictProxy, -# GUIAdapter, IdbProxy plus 7 module functions. +# Boilerplate likely to be needed for future test classes. +##from test.support import requires +##from tkinter import Tk +##class Test(unittest.TestCase): +## @classmethod +## def setUpClass(cls): +## requires('gui') +## cls.root = Tk() +## @classmethod +## def tearDownClass(cls): +## cls.root.destroy() + +# GUIProxy, IdbAdapter, FrameProxy, CodeProxy, DictProxy, +# GUIAdapter, IdbProxy, and 7 functions still need tests. class IdbAdapterTest(unittest.TestCase):