Minor formatting/include cleanups.

laramiel · copybara-github · commit 4bbac2763237 · 2024-09-24T18:15:25.000-07:00
PiperOrigin-RevId: 678453559
diff --git a/pybind11_protobuf/BUILD b/pybind11_protobuf/BUILD
@@ -71,7 +71,6 @@ cc_library(
     deps = [
         "@com_google_absl//absl/container:flat_hash_map",
         "@com_google_absl//absl/container:flat_hash_set",
-        "@com_google_absl//absl/meta:type_traits",
         "@com_google_absl//absl/strings",
         "@com_google_absl//absl/synchronization",
         "@com_google_protobuf//:protobuf",
diff --git a/pybind11_protobuf/check_unknown_fields.cc b/pybind11_protobuf/check_unknown_fields.cc
@@ -6,15 +6,16 @@
 #include <string>
 #include <vector>
 
-#include "google/protobuf/descriptor.h"
-#include "google/protobuf/message.h"
-#include "google/protobuf/unknown_field_set.h"
 #include "absl/container/flat_hash_map.h"
 #include "absl/container/flat_hash_set.h"
 #include "absl/strings/str_cat.h"
 #include "absl/strings/str_join.h"
 #include "absl/strings/string_view.h"
 #include "absl/synchronization/mutex.h"
+#include "google/protobuf/descriptor.h"
+#include "google/protobuf/message.h"
+#include "google/protobuf/unknown_field_set.h"
+#include "python/google/protobuf/proto_api.h"
 
 namespace pybind11_protobuf::check_unknown_fields {
 namespace {
@@ -103,8 +104,7 @@ bool HasUnknownFields::FindUnknownFieldsRecursive(
 
     // Stop only if the extension is known by Python.
     if (py_proto_api->GetDefaultDescriptorPool()->FindExtensionByNumber(
-            unknown_field_parent_descriptor,
-            unknown_field_number)) {
+            unknown_field_parent_descriptor, unknown_field_number)) {
       field_fqn_parts.resize(depth);
       return true;
     }
diff --git a/pybind11_protobuf/check_unknown_fields.h b/pybind11_protobuf/check_unknown_fields.h
@@ -2,10 +2,11 @@
 #define PYBIND11_PROTOBUF_CHECK_UNKNOWN_FIELDS_H_
 
 #include <optional>
+#include <string>
 
+#include "absl/strings/string_view.h"
 #include "google/protobuf/message.h"
 #include "python/google/protobuf/proto_api.h"
-#include "absl/strings/string_view.h"
 
 namespace pybind11_protobuf::check_unknown_fields {
 
diff --git a/pybind11_protobuf/enum_type_caster.h b/pybind11_protobuf/enum_type_caster.h
@@ -11,21 +11,19 @@
 #include <pybind11/pybind11.h>
 #include <pybind11/pytypes.h>
 
-#include <string>
 #include <type_traits>
 
-#include "google/protobuf/descriptor.h"
-#include "google/protobuf/generated_enum_reflection.h"
 #include "google/protobuf/generated_enum_util.h"
 
 // pybind11 type_caster specialization which translates Proto::Enum types
 // to/from ints. This will have ODR conflicts when users specify wrappers for
 // enums using py::enum_<T>.
 //
-// ::google::protobuf::is_proto_enum and ::google::protobuf::GetEnumDescriptor are require
+// ::google::protobuf::is_proto_enum and ::google::protobuf::GetEnumDescriptor
+// are require
 //
-// NOTE: The protobuf compiler does not generate ::google::protobuf::is_proto_enum traits
-// for enumerations of oneof fields.
+// NOTE: The protobuf compiler does not generate
+// ::google::protobuf::is_proto_enum traits for enumerations of oneof fields.
 //
 // Example:
 //  #include <pybind11/pybind11.h>
diff --git a/pybind11_protobuf/native_proto_caster.h b/pybind11_protobuf/native_proto_caster.h
@@ -11,22 +11,17 @@
 // IWYU
 #include <Python.h>
 
-#include <functional>
-#include <memory>
-#include <optional>
-#include <string>
 #include <type_traits>
-#include <utility>
 
-#include "google/protobuf/message.h"
 #include "absl/strings/string_view.h"
+#include "google/protobuf/message.h"
 #include "pybind11_protobuf/enum_type_caster.h"
 #include "pybind11_protobuf/proto_caster_impl.h"
 
-// pybind11::type_caster<> specialization for ::google::protobuf::Message types that
-// that converts protocol buffer objects between C++ and python representations.
-// This binder supports binaries linked with both native python protos
-// and fast cpp python protos.
+// pybind11::type_caster<> specialization for ::google::protobuf::Message types
+// that that converts protocol buffer objects between C++ and python
+// representations. This binder supports binaries linked with both native python
+// protos and fast cpp python protos.
 //
 // When passing protos between python and C++, if possible, an underlying C++
 // object may have ownership transferred, or may be copied if both instances
diff --git a/pybind11_protobuf/proto_cast_util.cc b/pybind11_protobuf/proto_cast_util.cc
@@ -11,9 +11,7 @@
 #include <string>
 #include <unordered_set>
 #include <utility>
-#include <vector>
 
-#include "google/protobuf/descriptor.pb.h"
 #include "absl/container/flat_hash_map.h"
 #include "absl/log/check.h"
 #include "absl/log/log.h"
@@ -25,6 +23,7 @@
 #include "absl/strings/strip.h"
 #include "absl/types/optional.h"
 #include "google/protobuf/descriptor.h"
+#include "google/protobuf/descriptor.pb.h"
 #include "google/protobuf/descriptor_database.h"
 #include "google/protobuf/dynamic_message.h"
 
@@ -34,7 +33,6 @@ using ::google::protobuf::Descriptor;
 using ::google::protobuf::DescriptorDatabase;
 using ::google::protobuf::DescriptorPool;
 using ::google::protobuf::DynamicMessageFactory;
-using ::google::protobuf::FileDescriptor;
 using ::google::protobuf::FileDescriptorProto;
 using ::google::protobuf::Message;
 using ::google::protobuf::MessageFactory;
@@ -184,10 +182,8 @@ GlobalState::GlobalState() {
   // pybind11_protobuf casting needs a dependency on proto internals to work.
   try {
     ImportCached("google.protobuf.descriptor");
-    auto descriptor_pool =
-        ImportCached("google.protobuf.descriptor_pool");
-    auto message_factory =
-        ImportCached("google.protobuf.message_factory");
+    auto descriptor_pool = ImportCached("google.protobuf.descriptor_pool");
+    auto message_factory = ImportCached("google.protobuf.message_factory");
     global_pool_ = descriptor_pool.attr("Default")();
     find_message_type_by_name_ = global_pool_.attr("FindMessageTypeByName");
     if (hasattr(message_factory, "GetMessageClass")) {
@@ -221,6 +217,7 @@ py::module_ GlobalState::ImportCached(const std::string& module_name) {
   if (cached != import_cache_.end()) {
     return cached->second;
   }
+  LOG(INFO) << "ImportCached " << module_name;
   auto module = py::module_::import(module_name.c_str());
   import_cache_[module_name] = module;
   return module;
diff --git a/pybind11_protobuf/proto_cast_util.h b/pybind11_protobuf/proto_cast_util.h
@@ -6,16 +6,13 @@
 #include <pybind11/pybind11.h>
 #include <pybind11/pytypes.h>
 
-#include <functional>
 #include <memory>
 #include <string>
-#include <type_traits>
-#include <utility>
 
-#include "google/protobuf/descriptor.h"
-#include "google/protobuf/message.h"
 #include "absl/strings/string_view.h"
 #include "absl/types/optional.h"
+#include "google/protobuf/descriptor.h"
+#include "google/protobuf/message.h"
 
 // PYBIND11_PROTOBUF_ASSUME_FULL_ABI_COMPATIBILITY can be defined by users
 // certain about ABI compatibility between all Python extensions in their
@@ -52,10 +49,12 @@ absl::string_view PyBytesAsStringView(pybind11::bytes py_bytes);
 // various protobuf-related modules.
 void InitializePybindProtoCastUtil();
 
-// Imports a module pertaining to a given ::google::protobuf::Descriptor, if possible.
+// Imports a module pertaining to a given ::google::protobuf::Descriptor, if
+// possible.
 void ImportProtoDescriptorModule(const ::google::protobuf::Descriptor *);
 
-// Returns a ::google::protobuf::Message* from a cpp_fast_proto, if backed by C++.
+// Returns a ::google::protobuf::Message* from a cpp_fast_proto, if backed by
+// C++.
 const ::google::protobuf::Message *PyProtoGetCppMessagePointer(pybind11::handle src);
 
 // Returns the protocol buffer's py_proto.DESCRIPTOR.full_name attribute.
diff --git a/pybind11_protobuf/proto_caster_impl.h b/pybind11_protobuf/proto_caster_impl.h
@@ -8,15 +8,13 @@
 #include <pybind11/pybind11.h>
 #include <pybind11/pytypes.h>
 
-#include <functional>
 #include <memory>
 #include <optional>
-#include <string>
 #include <type_traits>
 #include <utility>
 
-#include "google/protobuf/descriptor.pb.h"
 #include "google/protobuf/descriptor.h"
+#include "google/protobuf/descriptor.pb.h"
 #include "google/protobuf/message.h"
 #include "pybind11_protobuf/proto_cast_util.h"
 
@@ -74,8 +72,7 @@ struct proto_caster_load_impl {
 
     owned = std::unique_ptr<ProtoType>(new ProtoType());
     value = owned.get();
-    return owned.get()->ParsePartialFromString(
-        PyBytesAsStringView(serialized_bytes));
+    return owned->ParsePartialFromString(PyBytesAsStringView(serialized_bytes));
   }
 
   // ensure_owned ensures that the owned member contains a copy of the
@@ -126,8 +123,7 @@ struct proto_caster_load_impl<::google::protobuf::Message> {
             src, *descriptor_name)
             .release()));
     value = owned.get();
-    return owned.get()->ParsePartialFromString(
-        PyBytesAsStringView(serialized_bytes));
+    return owned->ParsePartialFromString(PyBytesAsStringView(serialized_bytes));
   }
 
   // ensure_owned ensures that the owned member contains a copy of the
@@ -156,7 +152,8 @@ struct fast_cpp_cast_impl {
         (policy == pybind11::return_value_policy::reference ||
          policy == pybind11::return_value_policy::reference_internal)) {
       throw pybind11::type_error(
-          "Cannot return a const reference to a ::google::protobuf::Message derived "
+          "Cannot return a const reference to a ::google::protobuf::Message "
+          "derived "
           "type.  Consider setting return_value_policy::copy in the "
           "pybind11 def().");
     }
diff --git a/pybind11_protobuf/proto_utils.cc b/pybind11_protobuf/proto_utils.cc
@@ -7,17 +7,20 @@
 
 #include <pybind11/functional.h>
 
-#include <cstddef>
+#include <cstdint>
+#include <cstdlib>
+#include <functional>
 #include <memory>
 #include <stdexcept>
 #include <string>
+#include <utility>
 
-#include "google/protobuf/descriptor.pb.h"
+#include "absl/strings/str_cat.h"
+#include "absl/strings/string_view.h"
 #include "google/protobuf/descriptor.h"
+#include "google/protobuf/descriptor.pb.h"
 #include "google/protobuf/message.h"
 #include "google/protobuf/reflection.h"
-#include "absl/strings/str_cat.h"
-#include "absl/strings/string_view.h"
 
 namespace pybind11 {
 namespace google {
@@ -516,7 +519,7 @@ struct FindMapPair {
                                       handle key, bool add_key = true) {
     // When using the proto reflection API, maps are represented as repeated
     // message fields (messages with 2 elements: 'key' and 'value'). If protocol
-    // buffers guarrantee a consistent (and useful) ordering of elements,
+    // buffers guarantee a consistent (and useful) ordering of elements,
     // it should be possible to do this search in O(log(n)) time. However, that
     // requires more knowledge of protobuf internals than I have, so for now
     // assume a random ordering of elements, in which case a O(n) search is
diff --git a/pybind11_protobuf/proto_utils.h b/pybind11_protobuf/proto_utils.h
@@ -19,9 +19,9 @@ namespace google {
 // Unlike ProtoSetField, this allows setting message, map and repeated fields.
 void ProtoInitFields(::google::protobuf::Message* message, kwargs kwargs_in);
 
-// Wrapper around ::google::protobuf::Message::CopyFrom which can efficiently copy from
-// either a wrapped C++ or native python proto. Throws an error if `other`
-// is not a proto of the correct type.
+// Wrapper around ::google::protobuf::Message::CopyFrom which can efficiently
+// copy from either a wrapped C++ or native python proto. Throws an error if
+// `other` is not a proto of the correct type.
 void ProtoCopyFrom(::google::protobuf::Message* msg, handle other);
 
 // Allocate and return the ProtoType given by the template argument.
diff --git a/pybind11_protobuf/tests/BUILD b/pybind11_protobuf/tests/BUILD
@@ -154,9 +154,9 @@ py_test(
     deps = [
         ":compare",
         ":test_py_pb2",
-        "@com_google_protobuf//:protobuf_python",
         "@com_google_absl_py//absl/testing:absltest",
         "@com_google_absl_py//absl/testing:parameterized",
+        "@com_google_protobuf//:protobuf_python",
         requirement("absl_py"),
     ],
 )
@@ -245,9 +245,9 @@ py_test(
     srcs_version = "PY3",
     deps = [
         ":test_py_pb2",
-        "@com_google_protobuf//:protobuf_python",
         "@com_google_absl_py//absl/testing:absltest",
         "@com_google_absl_py//absl/testing:parameterized",
+        "@com_google_protobuf//:protobuf_python",
         requirement("absl_py"),
     ],
 )
@@ -270,6 +270,7 @@ pybind_extension(
     deps = [
         ":test_cc_proto",
         "//pybind11_protobuf:wrapped_proto_caster",
+        "@com_google_absl//absl/functional:function_ref",
         "@com_google_absl//absl/status:statusor",
         "@com_google_absl//absl/types:optional",
         "@com_google_protobuf//:protobuf",
diff --git a/pybind11_protobuf/tests/dynamic_message_module.cc b/pybind11_protobuf/tests/dynamic_message_module.cc
@@ -5,12 +5,14 @@
 
 #include <pybind11/pybind11.h>
 
-#include <functional>
+#include <cassert>
+#include <cstdint>
 #include <memory>
 #include <stdexcept>
+#include <string>
 
-#include "google/protobuf/descriptor.pb.h"
 #include "google/protobuf/descriptor.h"
+#include "google/protobuf/descriptor.pb.h"
 #include "google/protobuf/dynamic_message.h"
 #include "google/protobuf/message.h"
 #include "google/protobuf/text_format.h"
diff --git a/pybind11_protobuf/tests/dynamic_message_test.py b/pybind11_protobuf/tests/dynamic_message_test.py
@@ -10,10 +10,10 @@
 
 from absl.testing import absltest
 from absl.testing import parameterized
-
 from google.protobuf import descriptor_pb2
 from google.protobuf import descriptor_pool
 from google.protobuf import message_factory
+
 from pybind11_protobuf.tests import compare
 from pybind11_protobuf.tests import dynamic_message_module as m
 from pybind11_protobuf.tests import test_pb2
diff --git a/pybind11_protobuf/tests/message_module.cc b/pybind11_protobuf/tests/message_module.cc
@@ -5,9 +5,7 @@
 
 #include <pybind11/pybind11.h>
 
-#include <functional>
-#include <memory>
-#include <stdexcept>
+#include <string>
 
 #include "google/protobuf/message.h"
 #include "google/protobuf/text_format.h"
@@ -18,8 +16,8 @@ namespace py = ::pybind11;
 
 namespace {
 
-using pybind11::test::IntMessage;
-using pybind11::test::TestMessage;
+using ::pybind11::test::IntMessage;
+using ::pybind11::test::TestMessage;
 
 PYBIND11_MODULE(message_module, m) {
   pybind11_protobuf::ImportNativeProtoCasters();
diff --git a/pybind11_protobuf/tests/message_test.py b/pybind11_protobuf/tests/message_test.py
@@ -14,12 +14,12 @@
 
 from absl.testing import absltest
 from absl.testing import parameterized
+from google.protobuf import text_format
 
 from google.protobuf import any_pb2
 from pybind11_protobuf.tests import compare
 from pybind11_protobuf.tests import message_module as m
 from pybind11_protobuf.tests import test_pb2
-from google.protobuf import text_format
 
 
 def get_py_message():
diff --git a/pybind11_protobuf/tests/pass_by_module.cc b/pybind11_protobuf/tests/pass_by_module.cc
diff --git a/pybind11_protobuf/tests/pass_by_test.py b/pybind11_protobuf/tests/pass_by_test.py
diff --git a/pybind11_protobuf/tests/regression_wrappers_module.cc b/pybind11_protobuf/tests/regression_wrappers_module.cc
diff --git a/pybind11_protobuf/tests/wrapped_proto_module.cc b/pybind11_protobuf/tests/wrapped_proto_module.cc
diff --git a/pybind11_protobuf/wrapped_proto_caster.h b/pybind11_protobuf/wrapped_proto_caster.h
