Skip to content

Commit 4dc4aca

Browse files
authored
[skip ci] Explain: conduit feature only covers from-Python-to-C++ conversions (#5740)
1 parent 03d8f48 commit 4dc4aca

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

include/pybind11/conduit/pybind11_conduit_v1.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@
66
77
* including pybind11 versions with different PYBIND11_INTERNALS_VERSION's.
88
9+
* NOTE: The conduit feature
10+
only covers from-Python-to-C++ conversions, it
11+
does not cover from-C++-to-Python conversions.
12+
(For the latter, a different feature would have to be added.)
13+
914
The naming of the feature is a bit misleading:
1015
1116
* The feature is in no way tied to pybind11 internals.

tests/test_cpp_conduit.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,8 @@ def test_exo_planet_c_api_premium_traveler(premium_traveler_type):
151151

152152
def test_home_planet_wrap_very_lonely_traveler():
153153
# This does not exercise the cpp_conduit feature, but is here to
154-
# demonstrate that the cpp_conduit feature does not solve all
155-
# cross-extension interoperability issues.
154+
# demonstrate that the cpp_conduit feature does not solve
155+
# cross-extension base-and-derived class interoperability issues.
156156
# Here is the proof that the following works for extensions with
157157
# matching `PYBIND11_INTERNALS_ID`s:
158158
# test_cpp_conduit.cpp:

0 commit comments

Comments
 (0)