File tree Expand file tree Collapse file tree 2 files changed +5
-7
lines changed
src/google/protobuf/compiler/java Expand file tree Collapse file tree 2 files changed +5
-7
lines changed Original file line number Diff line number Diff line change @@ -358,11 +358,7 @@ bool HasRequiredFields(const Descriptor* descriptor);
358
358
bool IsRealOneof (const FieldDescriptor* descriptor);
359
359
360
360
inline bool HasHasbit (const FieldDescriptor* descriptor) {
361
- // TODO(b/241441075) Replace this with internal::cpp::HasHasbit once Elysium
362
- // unblocks this change.
363
- return (FieldDescriptorLegacy (descriptor).has_optional_keyword () ||
364
- descriptor->is_required ()) &&
365
- !descriptor->options ().weak ();
361
+ return internal::cpp::HasHasbit (descriptor);
366
362
}
367
363
368
364
// Whether generate classes expose public PARSER instances.
Original file line number Diff line number Diff line change @@ -326,8 +326,10 @@ void ImmutableMessageFieldGenerator::GenerateBuilderMembers(
326
326
327
327
" $name$Builder_.mergeFrom(value);\n " ,
328
328
329
- " $set_has_field_bit_builder$\n "
330
- " $on_changed$\n "
329
+ " if ($name$_ != null) {\n "
330
+ " $set_has_field_bit_builder$\n "
331
+ " $on_changed$\n "
332
+ " }\n "
331
333
" return this;\n " ,
332
334
Semantic::kSet );
333
335
You can’t perform that action at this time.
0 commit comments