Skip to content

Commit a1b3ff0

Browse files
mkruskal-googlecopybara-github
authored andcommitted
Automated rollback of commit 3e188b7.
PiperOrigin-RevId: 542744002
1 parent a11f6b6 commit a1b3ff0

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

src/google/protobuf/compiler/java/helpers.h

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -358,11 +358,7 @@ bool HasRequiredFields(const Descriptor* descriptor);
358358
bool IsRealOneof(const FieldDescriptor* descriptor);
359359

360360
inline bool HasHasbit(const FieldDescriptor* descriptor) {
361-
// TODO(b/241441075) Replace this with internal::cpp::HasHasbit once Elysium
362-
// unblocks this change.
363-
return (FieldDescriptorLegacy(descriptor).has_optional_keyword() ||
364-
descriptor->is_required()) &&
365-
!descriptor->options().weak();
361+
return internal::cpp::HasHasbit(descriptor);
366362
}
367363

368364
// Whether generate classes expose public PARSER instances.

src/google/protobuf/compiler/java/message_field.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -326,8 +326,10 @@ void ImmutableMessageFieldGenerator::GenerateBuilderMembers(
326326

327327
"$name$Builder_.mergeFrom(value);\n",
328328

329-
"$set_has_field_bit_builder$\n"
330-
"$on_changed$\n"
329+
"if ($name$_ != null) {\n"
330+
" $set_has_field_bit_builder$\n"
331+
" $on_changed$\n"
332+
"}\n"
331333
"return this;\n",
332334
Semantic::kSet);
333335

0 commit comments

Comments
 (0)