Skip to content

PR auto tests fail at "Install Cretificates for Code Signing" stage #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Junology opened this issue Jan 10, 2025 · 6 comments · Fixed by #908
Closed

PR auto tests fail at "Install Cretificates for Code Signing" stage #906

Junology opened this issue Jan 10, 2025 · 6 comments · Fixed by #908
Labels
bug Something isn't working

Comments

@Junology
Copy link
Contributor

Most appropriate sub-area of Processing 4?

Build process

Processing version

GitHub Actions

Operating system

GitHub Actions

Steps to reproduce this

"1. Make PR

  1. The auto tests run and fail with error "At least one of p12-filepath or p12-file-base64 must be provided" from "Create Pull Request Build for macos (aarch64)"
    "

snippet

No response

Additional context

The tests fail at the stage before actual build, so maybe I have nothing to treat the errors.

Would you like to work on the issue?

I am glad if core maintainers could fix the issue.

@Junology Junology added the bug Something isn't working label Jan 10, 2025
@SableRaf
Copy link
Collaborator

SableRaf commented Jan 10, 2025

Hey @Junology! Thanks for the report.

Official macOS releases of Processing are signed and notarized during the automated build process. However, if you want to create your own custom builds of Processing to share with someone else, you will need to sign the code with your own certificates. This is because macOS won't allow apps from unknown developers to run. Instructions are available here: https://github.com/processing/processing4/blob/main/build/CODESIGNING.md

If you just want to test your changes on your machine, it may be easier to build Processing locally: https://github.com/processing/processing4/tree/main/build (Note that we're working on simplifying the build process so this page may be changing soon).

@Stefterv: feel free to correct me or add anything I missed.

@Junology
Copy link
Contributor Author

Junology commented Jan 10, 2025

@SableRaf I encountered error not on my fork repository but exactly this repository; namely in #899 #905 .
I remember #873 was okay.

@SableRaf
Copy link
Collaborator

Ah thanks for the clarification! I just saw the failure in #905

There doesn't seem to have been a recent change to the build workflow. Hopefully @Stefterv will have an idea why this is happening.

image

@Stefterv
Copy link
Collaborator

Yes, the secrets needed for building a signed version are hidden on PR because it is unverified code by third parties

@SableRaf
Copy link
Collaborator

Hm, that may be confusing for contributors since it presents as failed checks. How about we make macOS unsigned builds for PRs?

@Stefterv
Copy link
Collaborator

This should be fixed now, it will probably still fail if your branch is not up to date with main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants