Skip to content

Switch to getModifiersEx() in PSurfaceAWT #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
processing-bot opened this issue Oct 7, 2019 · 2 comments
Closed

Switch to getModifiersEx() in PSurfaceAWT #4

processing-bot opened this issue Oct 7, 2019 · 2 comments

Comments

@processing-bot
Copy link
Collaborator

Created by: benfry

We've not used getModifiersEx() in the past, because it (traditionally) has caused problems with some modifiers not being set properly. But now that it's deprecated, we need to make the switch and do a bunch of testing to make sure it's behaving the same way.

The fix is super easy. The debugging/testing is a bit time-consuming.

@processing-bot
Copy link
Collaborator Author

Created by: benfry

Passing all modifiers to the KeyEvent and MouseEvent constructors, though they aren't even being stored or used at the moment, so may not be a big deal.

Had trouble with this change in the past and rolled it back because it was optional at the time. This time around, just need to iron out any issues that come up:

@processing-bot
Copy link
Collaborator Author

Created by: github-actions[bot]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant