fix for #50, alternate solution but based on #75

Author: benfry

core/src/processing/opengl/PGL.java

@@ -170,11 +170,11 @@ public abstract class PGL {
    * Using FBO can cause a fatal error during runtime for
    * Intel HD Graphics 3000 chipsets (commonly used on older MacBooks)
    * <a href="https://github.com/processing/processing/issues/4104">#4104</a>
-   * The value remains as 'true' unless set false during init.
-   * TODO There's already code in here to enable/disable the FBO properly,
-   * this should be making use of that mechanism instead. [fry 191007]
+   * Changed to private because needs to be accessed via isFboAllowed().
+   * <a href="https://github.com/processing/processing4/pull/76">#76</a> and
+   * <a href="https://github.com/processing/processing4/issues/50">#50</a>
    */
-  protected boolean fboAllowed = true;
+  private Boolean fboAllowed = true;
 
   // ........................................................
 
@@ -863,7 +863,7 @@ protected void endRender(int windowColor) {
         saveFirstFrame();
       }
 
-      if (fboAllowed) {
+      if (isFboAllowed()) {
         if (!clearColor && 0 < sketch.frameCount || !sketch.isLooping()) {
           enableFBOLayer();
           if (SINGLE_BUFFERED) {
@@ -2304,6 +2304,28 @@ protected int getMaxTexUnits() {
   }
 
 
+  public boolean isFboAllowed() {
+    if (fboAllowed == null) {
+      if (PApplet.platform == PConstants.MACOS) {
+        try {
+          String hardware = getString(PGL.RENDERER);
+          if (hardware != null && hardware.contains("Intel HD Graphics 3000")) {
+            fboAllowed = false;
+            return false;
+          }
+        } catch (RuntimeException e) {
+          System.err.println("Could not read renderer name. FBOs disabled. Reason: " + e);
+          // disable for now, but will try again on next isFboAllowed() call
+          return false;
+        }
+      }
+      // all other scenarios allow for FBOs
+      fboAllowed = true;
+    }
+    return fboAllowed;
+  }
+
+
   protected static ByteBuffer allocateDirectByteBuffer(int size) {
     int bytes = PApplet.max(MIN_DIRECT_BUFFER_SIZE, size) * SIZEOF_BYTE;
     return ByteBuffer.allocateDirect(bytes).order(ByteOrder.nativeOrder());

core/src/processing/opengl/PSurfaceJOGL.java

@@ -38,7 +38,6 @@
 import java.io.FileInputStream;
 import java.io.IOException;
 import java.io.InputStream;
-import java.lang.reflect.Method;
 import java.nio.ByteBuffer;
 import java.util.HashMap;
 import java.util.Map;
@@ -255,22 +254,6 @@ protected void initDisplay() {
 
     GraphicsConfiguration config = awtDisplayDevice.getDefaultConfiguration();
     displayRect = config.getBounds();
-
-    /** See explanation at {@link PGL#fboAllowed} in PGL */
-    if (PApplet.platform == PConstants.MACOS) {
-      try {
-        Class<?> cglClass = Class.forName("sun.java2d.opengl.CGLGraphicsConfig");
-        Method cglMethod = cglClass.getMethod("getContextCapabilities");
-        Class<?> ctcClass = Class.forName("sun.java2d.pipe.hw.ContextCapabilities");
-        Method ctcMethod = ctcClass.getMethod("getAdapterId");
-        Object cglInstance = cglClass.cast(config);
-        Object ctcInstance = cglMethod.invoke(cglInstance);
-        Object idInstance = ctcMethod.invoke(ctcInstance);
-        if (String.valueOf(idInstance).contains("Intel HD Graphics 3000")) {
-          pgl.fboAllowed = false;
-        }
-      } catch (Exception e) { }
-    }
   }
 
 

todo.txt

@@ -24,7 +24,9 @@ X   https://github.com/processing/processing4/pull/96
 X Debug button in the toolbar is currently broken
 X   https://github.com/processing/processing4/issues/94
 X   https://github.com/processing/processing4/pull/95
-
+X Fix WARNING: Illegal reflective access by processing.opengl.PSurfaceJOGL” on getContextCapabilities()
+X   https://github.com/processing/processing4/issues/50
+X   https://github.com/processing/processing4/pull/76
 
 before final release
 _ Update graphics and visual design elements for 4.x