Remove comment-empty-line-before and order/properties-order (#520)

* Remove order rule

* Disable comment-empty-line-before

* Create shiny-points-tap.md

* Update test to expect 2 warnings

---------

Co-authored-by: Jon Rohan <[email protected]>

Author: iansan5653

.changeset/shiny-points-tap.md

@@ -0,0 +1,5 @@
+---
+"@primer/stylelint-config": patch
+---
+
+Remove comment-empty-line-before and order/properties-order rules

__tests__/index.js

@@ -34,9 +34,8 @@ describe('stylelint-config', () => {
         }
       `).then(data => {
       expect(data).toHaveErrored()
-      expect(data).toHaveWarningsLength(3)
+      expect(data).toHaveWarningsLength(2)
       expect(data).toHaveWarnings([
-        'Expected "top" to come before "width" (order/properties-order)',
         "Please use a primer size variable instead of '.2em'. Consult the primer docs for a suitable replacement. https://primer.style/foundations/primitives/size (primer/spacing)",
         'Unexpected value "initial" for property "max-width" (declaration-property-value-disallowed-list)',
       ])

index.js

@@ -1,5 +1,4 @@
 import browsers from '@github/browserslist-config'
-import propertyOrder from './property-order.js'
 
 import borders from './plugins/borders.js'
 import boxShadow from './plugins/box-shadow.js'
@@ -21,7 +20,6 @@ export default {
   plugins: [
     'stylelint-value-no-unknown-custom-properties',
     'stylelint-browser-compat',
-    'stylelint-order',
     borders,
     boxShadow,
     colors,
@@ -78,7 +76,6 @@ export default {
     'no-duplicate-selectors': true,
     'no-invalid-position-at-import-rule': [true, {ignoreAtRules: ['use']}],
     'number-max-precision': null,
-    'order/properties-order': propertyOrder,
     'plugin/browser-compat': [
       true,
       {
@@ -120,6 +117,7 @@ export default {
     'keyframe-selector-notation': ['percentage-unless-within-keyword-only-block'],
     'media-query-no-invalid': null,
     'media-feature-range-notation': ['prefix'],
+    'comment-empty-line-before': null,
   },
   overrides: [
     {
@@ -141,10 +139,8 @@ export default {
       files: ['**/*.tsx'],
       customSyntax: 'postcss-styled-syntax',
       rules: {
-        'order/properties-order': null,
         'rule-empty-line-before': null,
         'declaration-empty-line-before': null,
-        'comment-empty-line-before': null,
         'length-zero-no-unit': null,
         'selector-max-type': null,
         'primer/colors': null,

package-lock.json

@@ -26,7 +26,6 @@
   ],
   "files": [
     "dist/",
-    "property-order.js",
     "plugins/"
   ],
   "engines": {
@@ -51,7 +50,6 @@
     "stylelint": "^16.3.1",
     "stylelint-browser-compat": "^1.0.0-beta.136",
     "stylelint-config-standard": "^36.0.0",
-    "stylelint-order": "^6.0.4",
     "stylelint-scss": "^6.2.0",
     "stylelint-value-no-unknown-custom-properties": "^6.0.1"
   },