From e7cad17b1a87752c7c9f13746ace88a8ed04811a Mon Sep 17 00:00:00 2001 From: Marie Lucca Date: Wed, 21 May 2025 00:46:58 -0400 Subject: [PATCH 1/7] fix(Button): correct loading alignment --- packages/react/src/Button/ButtonBase.module.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/react/src/Button/ButtonBase.module.css b/packages/react/src/Button/ButtonBase.module.css index 24bf4e0b8ea..07e78042207 100644 --- a/packages/react/src/Button/ButtonBase.module.css +++ b/packages/react/src/Button/ButtonBase.module.css @@ -243,6 +243,10 @@ } } + .LoadingSpinner{ + display: flex; + } + /* Default Variant */ &:where([data-variant='default']) { From f2f3102438ecf6fc2a9a1962ed250000066cca10 Mon Sep 17 00:00:00 2001 From: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Date: Wed, 21 May 2025 00:48:54 -0400 Subject: [PATCH 2/7] Create light-pants-listen.md --- .changeset/light-pants-listen.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/light-pants-listen.md diff --git a/.changeset/light-pants-listen.md b/.changeset/light-pants-listen.md new file mode 100644 index 00000000000..b39376b0179 --- /dev/null +++ b/.changeset/light-pants-listen.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +fix(Button): correct loading alignment From 95638cf5cbfba140885aadc13833e848c7e9b15b Mon Sep 17 00:00:00 2001 From: Marie Lucca Date: Wed, 21 May 2025 00:53:36 -0400 Subject: [PATCH 3/7] format --- packages/react/src/Button/ButtonBase.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/Button/ButtonBase.module.css b/packages/react/src/Button/ButtonBase.module.css index 07e78042207..605f84e66b1 100644 --- a/packages/react/src/Button/ButtonBase.module.css +++ b/packages/react/src/Button/ButtonBase.module.css @@ -243,7 +243,7 @@ } } - .LoadingSpinner{ + .LoadingSpinner { display: flex; } From ac3a5b77aa67272078177b96a7269428fc2af996 Mon Sep 17 00:00:00 2001 From: Marie Lucca Date: Wed, 21 May 2025 00:59:23 -0400 Subject: [PATCH 4/7] update vitest snapshots --- .../__snapshots__/AnchoredOverlay.test.tsx.snap | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react/src/AnchoredOverlay/__snapshots__/AnchoredOverlay.test.tsx.snap b/packages/react/src/AnchoredOverlay/__snapshots__/AnchoredOverlay.test.tsx.snap index ca5f79d1056..87a9e7ceaea 100644 --- a/packages/react/src/AnchoredOverlay/__snapshots__/AnchoredOverlay.test.tsx.snap +++ b/packages/react/src/AnchoredOverlay/__snapshots__/AnchoredOverlay.test.tsx.snap @@ -13,7 +13,7 @@ exports[`AnchoredOverlay > should render consistently when open 1`] = ` aria-describedby=":rd:-loading-announcement" aria-expanded="true" aria-haspopup="true" - class="_ButtonBase_130zs_2" + class="_ButtonBase_y24iw_2" data-loading="false" data-no-visuals="true" data-size="medium" @@ -23,12 +23,12 @@ exports[`AnchoredOverlay > should render consistently when open 1`] = ` type="button" > Anchor Button From ea29f3b0c161c310c12435010c8f4f32e5e8b929 Mon Sep 17 00:00:00 2001 From: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Date: Wed, 21 May 2025 14:27:08 -0400 Subject: [PATCH 5/7] Update packages/react/src/Button/ButtonBase.module.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- packages/react/src/Button/ButtonBase.module.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react/src/Button/ButtonBase.module.css b/packages/react/src/Button/ButtonBase.module.css index 605f84e66b1..11d3e09a313 100644 --- a/packages/react/src/Button/ButtonBase.module.css +++ b/packages/react/src/Button/ButtonBase.module.css @@ -245,6 +245,8 @@ .LoadingSpinner { display: flex; + align-items: center; + justify-content: center; } /* Default Variant */ From 903bf6186de5916b8f4cf487163d18ffb4449331 Mon Sep 17 00:00:00 2001 From: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Date: Wed, 21 May 2025 22:52:17 -0400 Subject: [PATCH 6/7] Update packages/react/src/Button/ButtonBase.module.css Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- packages/react/src/Button/ButtonBase.module.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react/src/Button/ButtonBase.module.css b/packages/react/src/Button/ButtonBase.module.css index 11d3e09a313..f99941b01e0 100644 --- a/packages/react/src/Button/ButtonBase.module.css +++ b/packages/react/src/Button/ButtonBase.module.css @@ -243,6 +243,8 @@ } } + /* Styles for the spinner element displayed when the Button is in a loading state. + * Ensures the spinner is centered within its container. */ .LoadingSpinner { display: flex; align-items: center; From 406b525b732fd67814c25c5507a7aa851118e929 Mon Sep 17 00:00:00 2001 From: Marie Lucca Date: Wed, 21 May 2025 22:55:13 -0400 Subject: [PATCH 7/7] snapshot update --- .../__snapshots__/AnchoredOverlay.test.tsx.snap | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react/src/AnchoredOverlay/__snapshots__/AnchoredOverlay.test.tsx.snap b/packages/react/src/AnchoredOverlay/__snapshots__/AnchoredOverlay.test.tsx.snap index 87a9e7ceaea..57cbeab4ce0 100644 --- a/packages/react/src/AnchoredOverlay/__snapshots__/AnchoredOverlay.test.tsx.snap +++ b/packages/react/src/AnchoredOverlay/__snapshots__/AnchoredOverlay.test.tsx.snap @@ -13,7 +13,7 @@ exports[`AnchoredOverlay > should render consistently when open 1`] = ` aria-describedby=":rd:-loading-announcement" aria-expanded="true" aria-haspopup="true" - class="_ButtonBase_y24iw_2" + class="_ButtonBase_149hc_2" data-loading="false" data-no-visuals="true" data-size="medium" @@ -23,12 +23,12 @@ exports[`AnchoredOverlay > should render consistently when open 1`] = ` type="button" > Anchor Button