Separate typechecking and building type declarations (#1588)

* Separate typechecking and building type declarations

* Update .github/workflows/ci.yml

Co-authored-by: Cole Bemis <[email protected]>

Co-authored-by: Cole Bemis <[email protected]>

Author: jfuchs

.github/workflows/ci.yml

@@ -24,8 +24,11 @@ jobs:
       - name: Lint
         run: npm run lint
 
-      - name: Build
-        run: npm run build
+      - name: Type check
+        run: npm run typecheck
 
       - name: Test
         run: npm run test
+
+      - name: Build
+        run: npm run build

package.json

@@ -20,7 +20,8 @@
     "test": "jest",
     "test:update": "npm run test -- --updateSnapshot",
     "release": "npm run build && changeset publish",
-    "size": "size-limit"
+    "size": "size-limit",
+    "typecheck": "npx tsc --project tsconfig.json"
   },
   "repository": "primer/react",
   "keywords": [

script/build

@@ -14,7 +14,7 @@ npx cross-env NODE_ENV=production rollup -c
 npx cross-env BABEL_MODULE=commonjs babel src --out-dir lib --extensions ".js,.ts,.jsx,.tsx"
 npx babel src --out-dir lib-esm --extensions ".js,.ts,.jsx,.tsx"
 
-# Type check
+# Build type declarations
 npx tsc --project tsconfig.build.json
 
 # Copy type declarations

tsconfig.base.json

@@ -0,0 +1,20 @@
+{
+  "compilerOptions": {
+    "target": "esnext",
+    "module": "commonjs",
+    "allowJs": true,
+    "checkJs": false,
+    "jsx": "preserve",
+    "declaration": true,
+    "outDir": "./lib",
+    "emitDeclarationOnly": false,
+    "strict": true,
+    "moduleResolution": "node",
+    "rootDirs": ["src"],
+    "esModuleInterop": true,
+    "skipLibCheck": true,
+    "forceConsistentCasingInFileNames": true,
+    "typeRoots": ["./node_modules/@types", "./@types"]
+  },
+  "include": ["@types/**/*.ts", "src/**/*.js", "src/**/*.ts", "src/**/*.tsx"]
+}

tsconfig.build.json

@@ -1,7 +1,7 @@
 {
-  "extends": "./tsconfig.json",
+  "extends": "./tsconfig.base.json",
   // NOTE: We exclude Storybook stories — in part because we don't want their type definitions
   // included in our build, but also because _something_ in Storybook mucks with the type definitions
   // of Primer components. See also https://github.com/primer/react/issues/1163.
-  "exclude": ["**/*.stories.tsx"]
+  "exclude": ["**/*.stories.tsx"],
 }

tsconfig.json

@@ -1,20 +1,7 @@
 {
+  "extends": "./tsconfig.base.json",
   "compilerOptions": {
-    "target": "esnext",
-    "module": "commonjs",
-    "allowJs": true,
-    "checkJs": false,
-    "jsx": "preserve",
-    "declaration": true,
-    "outDir": "./lib",
-    "emitDeclarationOnly": true,
-    "strict": true,
-    "moduleResolution": "node",
-    "rootDirs": ["src"],
-    "esModuleInterop": true,
-    "skipLibCheck": true,
-    "forceConsistentCasingInFileNames": true,
-    "typeRoots": ["./node_modules/@types", "./@types"]
+    "noEmit": true,
+    "emitDeclarationOnly": false
   },
-  "include": ["@types/**/*.ts", "src/**/*.js", "src/**/*.ts", "src/**/*.tsx"]
-}
+}