add instrumentation.provider to newrelic default attrs (open-telemetry#2900)

* add instrumentation.provider to newrelic default attrs

* use string instead of variables for keys in test

Author: gunturaf

exporter/newrelicexporter/newrelic_test.go

@@ -213,9 +213,10 @@ func TestExportTraceDataMinimum(t *testing.T) {
 			ID:      "0000000000000001",
 			TraceID: "01010101010101010101010101010101",
 			Attributes: map[string]interface{}{
-				"collector.name":    name,
-				"collector.version": version,
-				"name":              "root",
+				"collector.name":           name,
+				"collector.version":        version,
+				"name":                     "root",
+				"instrumentation.provider": "opentelemetry",
 			},
 		},
 	}
@@ -260,35 +261,38 @@ func TestExportTraceDataFullTrace(t *testing.T) {
 			ID:      "0000000000000001",
 			TraceID: "01010101010101010101010101010101",
 			Attributes: map[string]interface{}{
-				"collector.name":    name,
-				"collector.version": version,
-				"name":              "root",
-				"resource":          "R1",
-				"service.name":      "test-service",
+				"collector.name":           name,
+				"collector.version":        version,
+				"name":                     "root",
+				"resource":                 "R1",
+				"service.name":             "test-service",
+				"instrumentation.provider": "opentelemetry",
 			},
 		},
 		{
 			ID:      "0000000000000002",
 			TraceID: "01010101010101010101010101010101",
 			Attributes: map[string]interface{}{
-				"collector.name":    name,
-				"collector.version": version,
-				"name":              "client",
-				"parent.id":         "0000000000000001",
-				"resource":          "R1",
-				"service.name":      "test-service",
+				"collector.name":           name,
+				"collector.version":        version,
+				"name":                     "client",
+				"parent.id":                "0000000000000001",
+				"resource":                 "R1",
+				"service.name":             "test-service",
+				"instrumentation.provider": "opentelemetry",
 			},
 		},
 		{
 			ID:      "0000000000000003",
 			TraceID: "01010101010101010101010101010101",
 			Attributes: map[string]interface{}{
-				"collector.name":    name,
-				"collector.version": version,
-				"name":              "server",
-				"parent.id":         "0000000000000002",
-				"resource":          "R1",
-				"service.name":      "test-service",
+				"collector.name":           name,
+				"collector.version":        version,
+				"name":                     "server",
+				"parent.id":                "0000000000000002",
+				"resource":                 "R1",
+				"service.name":             "test-service",
+				"instrumentation.provider": "opentelemetry",
 			},
 		},
 	}

exporter/newrelicexporter/transformer.go

@@ -31,16 +31,17 @@ import (
 )
 
 const (
-	unitAttrKey               = "unit"
-	descriptionAttrKey        = "description"
-	collectorNameKey          = "collector.name"
-	collectorVersionKey       = "collector.version"
-	instrumentationNameKey    = "instrumentation.name"
-	instrumentationVersionKey = "instrumentation.version"
-	statusCodeKey             = "otel.status_code"
-	statusDescriptionKey      = "otel.status_description"
-	spanKindKey               = "span.kind"
-	serviceNameKey            = "service.name"
+	unitAttrKey                    = "unit"
+	descriptionAttrKey             = "description"
+	collectorNameKey               = "collector.name"
+	collectorVersionKey            = "collector.version"
+	instrumentationNameKey         = "instrumentation.name"
+	instrumentationVersionKey      = "instrumentation.version"
+	instrumentationProviderAttrKey = "instrumentation.provider"
+	statusCodeKey                  = "otel.status_code"
+	statusDescriptionKey           = "otel.status_description"
+	spanKindKey                    = "span.kind"
+	serviceNameKey                 = "service.name"
 )
 
 // TODO (MrAlias): unify this with the traceTransformer when the metric data
@@ -148,6 +149,7 @@ func (t *traceTransformer) SpanAttributes(span pdata.Span) map[string]interface{
 	// (overrides any existing)
 	attrs[collectorNameKey] = name
 	attrs[collectorVersionKey] = version
+	attrs[instrumentationProviderAttrKey] = "opentelemetry"
 
 	return attrs
 }

exporter/newrelicexporter/transformer_test.go

@@ -49,6 +49,7 @@ func defaultAttrFunc(res map[string]interface{}) func(map[string]interface{}) ma
 		full := make(map[string]interface{}, 2+len(res)+len(add))
 		full[collectorNameKey] = name
 		full[collectorVersionKey] = version
+		full[instrumentationProviderAttrKey] = "opentelemetry"
 		for k, v := range res {
 			full[k] = v
 		}