-
Notifications
You must be signed in to change notification settings - Fork 465
Description
Valid Title
- I have updated the title to accurately reflect the bug description
Description
Due to invalid decision type mappings, a Call to a member function getDecision() on null
leaks to the UI as seen below.
Notice I've assigned the critical status because I guess invalid constants might be inserted into the database.

Steps to Reproduce
- Ensure you've got a submission with a decision type of
RESUBMIT_INTERNAL
(ID 21), available just in OMP - Navigate to submission list
- See the error
Expected Result
No message should be displayed, the submission should be displayed on the UI
Actual Result
An exception is raised
Environment Details
No response
Application Version
OMP 3.5
Logs
PHP message: Error: Call to a member function getDecision() on null in www/lib/pkp/classes/submission/maps/Schema.php:957
Stack trace:
#0 www/lib/pkp/classes/submission/maps/Schema.php(468): PKP\submission\maps\Schema->getPropertyStages()
#1 www/classes/submission/maps/Schema.php(69): PKP\submission\maps\Schema->mapByProperties()
#2 www/lib/pkp/classes/submission/maps/Schema.php(339): APP\submission\maps\Schema->mapByProperties()
#3 www/lib/pkp/classes/submission/maps/Schema.php(397): PKP\submission\maps\Schema->mapToSubmissionsList()
#4 www/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Collections/LazyCollection.p...
Additional Information
No response