Skip to content

[Submission list] | Unexpected error leaks to the UI due to missing decision type #11721

@jonasraoni

Description

@jonasraoni

Valid Title

  • I have updated the title to accurately reflect the bug description

Description

Due to invalid decision type mappings, a Call to a member function getDecision() on null leaks to the UI as seen below.
Notice I've assigned the critical status because I guess invalid constants might be inserted into the database.

Image

Steps to Reproduce

  1. Ensure you've got a submission with a decision type of RESUBMIT_INTERNAL (ID 21), available just in OMP
  2. Navigate to submission list
  3. See the error

Expected Result

No message should be displayed, the submission should be displayed on the UI

Actual Result

An exception is raised

Environment Details

No response

Application Version

OMP 3.5

Logs

PHP message: Error: Call to a member function getDecision() on null in www/lib/pkp/classes/submission/maps/Schema.php:957
Stack trace:
#0 www/lib/pkp/classes/submission/maps/Schema.php(468): PKP\submission\maps\Schema->getPropertyStages()
#1 www/classes/submission/maps/Schema.php(69): PKP\submission\maps\Schema->mapByProperties()
#2 www/lib/pkp/classes/submission/maps/Schema.php(339): APP\submission\maps\Schema->mapByProperties()
#3 www/lib/pkp/classes/submission/maps/Schema.php(397): PKP\submission\maps\Schema->mapToSubmissionsList()
#4 www/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Collections/LazyCollection.p...

Additional Information

No response

Metadata

Metadata

Assignees

Labels

Bug:3:CriticalA bug that prevents a substantial majority of users from using the software.

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions