Fix leak in Simulcast probing

Sean-Der · Sean-Der · commit c785f2524aba · 2023-09-13T12:19:30.000-04:00
If probing was still in flight closing the PeerConnection would not interupt it properly. cherry-pick of b549c95
diff --git a/peerconnection.go b/peerconnection.go
@@ -1660,17 +1660,17 @@ func (pc *PeerConnection) undeclaredRTPMediaProcessor() {
 			continue
 		}
 
+		pc.dtlsTransport.storeSimulcastStream(stream)
+
 		if atomic.AddUint64(&simulcastRoutineCount, 1) >= simulcastMaxProbeRoutines {
 			atomic.AddUint64(&simulcastRoutineCount, ^uint64(0))
 			pc.log.Warn(ErrSimulcastProbeOverflow.Error())
-			pc.dtlsTransport.storeSimulcastStream(stream)
 			continue
 		}
 
 		go func(rtpStream io.Reader, ssrc SSRC) {
 			if err := pc.handleIncomingSSRC(rtpStream, ssrc); err != nil {
 				pc.log.Errorf(incomingUnhandledRTPSsrc, ssrc, err)
-				pc.dtlsTransport.storeSimulcastStream(stream)
 			}
 			atomic.AddUint64(&simulcastRoutineCount, ^uint64(0))
 		}(stream, SSRC(ssrc))

Original file line number	Diff line number	Diff line change
`@@ -1660,17 +1660,17 @@ func (pc *PeerConnection) undeclaredRTPMediaProcessor() {`
`1660`	`1660`	`continue`
`1661`	`1661`	`}`
`1662`	`1662`
	`1663`	`+ pc.dtlsTransport.storeSimulcastStream(stream)`
	`1664`	`+`
`1663`	`1665`	`if atomic.AddUint64(&simulcastRoutineCount, 1) >= simulcastMaxProbeRoutines {`
`1664`	`1666`	`atomic.AddUint64(&simulcastRoutineCount, ^uint64(0))`
`1665`	`1667`	`pc.log.Warn(ErrSimulcastProbeOverflow.Error())`
`1666`		`- pc.dtlsTransport.storeSimulcastStream(stream)`
`1667`	`1668`	`continue`
`1668`	`1669`	`}`
`1669`	`1670`
`1670`	`1671`	`go func(rtpStream io.Reader, ssrc SSRC) {`
`1671`	`1672`	`if err := pc.handleIncomingSSRC(rtpStream, ssrc); err != nil {`
`1672`	`1673`	`pc.log.Errorf(incomingUnhandledRTPSsrc, ssrc, err)`
`1673`		`- pc.dtlsTransport.storeSimulcastStream(stream)`
`1674`	`1674`	`}`
`1675`	`1675`	`atomic.AddUint64(&simulcastRoutineCount, ^uint64(0))`
`1676`	`1676`	`}(stream, SSRC(ssrc))`