Include msid-semantic in Session Attributes

Sean-Der · Sean-Der · commit 92df4bf0ec6d · 2024-04-01T13:25:22.000-04:00
Chrome doesn't include the msid when responding to recvonly transceivers See crbug[0] for discussion [0] https://issues.chromium.org/u/1/issues/328522463
diff --git a/peerconnection.go b/peerconnection.go
@@ -2318,6 +2318,7 @@ func (pc *PeerConnection) generateUnmatchedSDP(transceivers []*RTPTransceiver, u
 	if err != nil {
 		return nil, err
 	}
+	d.Attributes = append(d.Attributes, sdp.Attribute{Key: sdp.AttrKeyMsidSemantic, Value: "WMS*"})
 
 	iceParams, err := pc.iceGatherer.GetLocalParameters()
 	if err != nil {
@@ -2390,6 +2391,7 @@ func (pc *PeerConnection) generateMatchedSDP(transceivers []*RTPTransceiver, use
 	if err != nil {
 		return nil, err
 	}
+	d.Attributes = append(d.Attributes, sdp.Attribute{Key: sdp.AttrKeyMsidSemantic, Value: "WMS*"})
 
 	iceParams, err := pc.iceGatherer.GetLocalParameters()
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -2318,6 +2318,7 @@ func (pc PeerConnection) generateUnmatchedSDP(transceivers []RTPTransceiver, u`
`2318`	`2318`	`if err != nil {`
`2319`	`2319`	`return nil, err`
`2320`	`2320`	`}`
	`2321`	`+ d.Attributes = append(d.Attributes, sdp.Attribute{Key: sdp.AttrKeyMsidSemantic, Value: "WMS*"})`
`2321`	`2322`
`2322`	`2323`	`iceParams, err := pc.iceGatherer.GetLocalParameters()`
`2323`	`2324`	`if err != nil {`
`@@ -2390,6 +2391,7 @@ func (pc PeerConnection) generateMatchedSDP(transceivers []RTPTransceiver, use`
`2390`	`2391`	`if err != nil {`
`2391`	`2392`	`return nil, err`
`2392`	`2393`	`}`
	`2394`	`+ d.Attributes = append(d.Attributes, sdp.Attribute{Key: sdp.AttrKeyMsidSemantic, Value: "WMS*"})`
`2393`	`2395`
`2394`	`2396`	`iceParams, err := pc.iceGatherer.GetLocalParameters()`
`2395`	`2397`	`if err != nil {`