Update lint rules, force testify/assert for tests

Use testify's assert package instead of the standard library's testing
package.

Author: JoeTurki

.golangci.yml

@@ -19,12 +19,16 @@ linters-settings:
             recommendations:
               - errors
   forbidigo:
+    analyze-types: true
     forbid:
       - ^fmt.Print(f|ln)?$
       - ^log.(Panic|Fatal|Print)(f|ln)?$
       - ^os.Exit$
       - ^panic$
       - ^print(ln)?$
+      - p: ^testing.T.(Error|Errorf|Fatal|Fatalf|Fail|FailNow)$
+        pkg: ^testing$
+        msg: "use testify/assert instead"
   varnamelen:
     max-distance: 12
     min-name-length: 2
@@ -127,9 +131,12 @@ issues:
   exclude-dirs-use-default: false
   exclude-rules:
     # Allow complex tests and examples, better to be self contained
-    - path: (examples|main\.go|_test\.go)
+    - path: (examples|main\.go)
       linters:
+        - gocognit
         - forbidigo
+    - path: _test\.go
+      linters:
         - gocognit
 
     # Allow forbidden identifiers in CLI commands

api_test.go

@@ -14,18 +14,9 @@ import (
 
 func TestNewAPI(t *testing.T) {
 	api := NewAPI()
-
-	if api.settingEngine == nil {
-		t.Error("Failed to init settings engine")
-	}
-
-	if api.mediaEngine == nil {
-		t.Error("Failed to init media engine")
-	}
-
-	if api.interceptorRegistry == nil {
-		t.Error("Failed to init interceptor registry")
-	}
+	assert.NotNil(t, api.settingEngine, "failed to init settings engine")
+	assert.NotNil(t, api.mediaEngine, "failed to init media engine")
+	assert.NotNil(t, api.interceptorRegistry, "failed to init interceptor registry")
 }
 
 func TestNewAPI_Options(t *testing.T) {
@@ -36,13 +27,9 @@ func TestNewAPI_Options(t *testing.T) {
 		WithSettingEngine(s),
 	)
 
-	if !api.settingEngine.detach.DataChannels {
-		t.Error("Failed to set settings engine")
-	}
-
-	if len(api.mediaEngine.audioCodecs) == 0 || len(api.mediaEngine.videoCodecs) == 0 {
-		t.Error("Failed to set media engine")
-	}
+	assert.True(t, api.settingEngine.detach.DataChannels, "failed to set settings engine")
+	assert.NotEmpty(t, api.mediaEngine.audioCodecs, "failed to set audio codecs")
+	assert.NotEmpty(t, api.mediaEngine.videoCodecs, "failed to set video codecs")
 }
 
 func TestNewAPI_OptionsDefaultize(t *testing.T) {