Include msid-semantic in Session Attributes

Sean-Der · Sean-Der · commit 4c25aa67f41b · 2024-04-01T13:21:10.000-04:00
Chrome doesn't include the msid when responding to recvonly transceivers See crbug[0] for discussion [0] https://issues.chromium.org/u/1/issues/328522463
diff --git a/peerconnection.go b/peerconnection.go
@@ -2298,6 +2298,7 @@ func (pc *PeerConnection) generateUnmatchedSDP(transceivers []*RTPTransceiver, u
 	if err != nil {
 		return nil, err
 	}
+	d.Attributes = append(d.Attributes, sdp.Attribute{Key: sdp.AttrKeyMsidSemantic, Value: "WMS*"})
 
 	iceParams, err := pc.iceGatherer.GetLocalParameters()
 	if err != nil {
@@ -2370,6 +2371,7 @@ func (pc *PeerConnection) generateMatchedSDP(transceivers []*RTPTransceiver, use
 	if err != nil {
 		return nil, err
 	}
+	d.Attributes = append(d.Attributes, sdp.Attribute{Key: sdp.AttrKeyMsidSemantic, Value: "WMS*"})
 
 	iceParams, err := pc.iceGatherer.GetLocalParameters()
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -2298,6 +2298,7 @@ func (pc PeerConnection) generateUnmatchedSDP(transceivers []RTPTransceiver, u`
`2298`	`2298`	`if err != nil {`
`2299`	`2299`	`return nil, err`
`2300`	`2300`	`}`
	`2301`	`+ d.Attributes = append(d.Attributes, sdp.Attribute{Key: sdp.AttrKeyMsidSemantic, Value: "WMS*"})`
`2301`	`2302`
`2302`	`2303`	`iceParams, err := pc.iceGatherer.GetLocalParameters()`
`2303`	`2304`	`if err != nil {`
`@@ -2370,6 +2371,7 @@ func (pc PeerConnection) generateMatchedSDP(transceivers []RTPTransceiver, use`
`2370`	`2371`	`if err != nil {`
`2371`	`2372`	`return nil, err`
`2372`	`2373`	`}`
	`2374`	`+ d.Attributes = append(d.Attributes, sdp.Attribute{Key: sdp.AttrKeyMsidSemantic, Value: "WMS*"})`
`2373`	`2375`
`2374`	`2376`	`iceParams, err := pc.iceGatherer.GetLocalParameters()`
`2375`	`2377`	`if err != nil {`