NewAPI: register default codecs and interceptors

Author: andrein

api.go

@@ -26,15 +26,12 @@ type API struct {
 
 // NewAPI Creates a new API object for keeping semi-global settings to WebRTC objects
 //
-// WARNING: No Codecs or Interceptors are enabled by default. Unless configured properly a
-// PeerConnection will not be able to transmit media. For an example of how to do that,
-// see the body of the webrtc.NewPeerConnection() function.
+// It uses the default Codecs and Interceptors unless you customize them
+// using WithMediaEngine and WithInterceptorRegistry respectively.
 func NewAPI(options ...func(*API)) *API {
 	a := &API{
-		interceptor:         &interceptor.NoOp{},
-		settingEngine:       &SettingEngine{},
-		mediaEngine:         &MediaEngine{},
-		interceptorRegistry: &interceptor.Registry{},
+		interceptor:   &interceptor.NoOp{},
+		settingEngine: &SettingEngine{},
 	}
 
 	for _, o := range options {
@@ -45,6 +42,24 @@ func NewAPI(options ...func(*API)) *API {
 		a.settingEngine.LoggerFactory = logging.NewDefaultLoggerFactory()
 	}
 
+	logger := a.settingEngine.LoggerFactory.NewLogger("api")
+
+	if a.mediaEngine == nil {
+		a.mediaEngine = &MediaEngine{}
+		err := a.mediaEngine.RegisterDefaultCodecs()
+		if err != nil {
+			logger.Errorf("Failed to register default codecs %s", err)
+		}
+	}
+
+	if a.interceptorRegistry == nil {
+		a.interceptorRegistry = &interceptor.Registry{}
+		err := RegisterDefaultInterceptors(a.mediaEngine, a.interceptorRegistry)
+		if err != nil {
+			logger.Errorf("Failed to register default interceptors %s", err)
+		}
+	}
+
 	return a
 }
 

track_local_static_test.go

@@ -33,7 +33,7 @@ func Test_TrackLocalStatic_NoCodecIntersection(t *testing.T) {
 		pc, err := NewPeerConnection(Configuration{})
 		assert.NoError(t, err)
 
-		noCodecPC, err := NewAPI().NewPeerConnection(Configuration{})
+		noCodecPC, err := NewAPI(WithMediaEngine(&MediaEngine{})).NewPeerConnection(Configuration{})
 		assert.NoError(t, err)
 
 		_, err = pc.AddTrack(track)

vnet_test.go

@@ -10,6 +10,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/pion/interceptor"
 	"github.com/pion/logging"
 	"github.com/pion/transport/v3/vnet"
 	"github.com/stretchr/testify/assert"
@@ -52,14 +53,12 @@ func createVNetPair(t *testing.T) (*PeerConnection, *PeerConnection, *vnet.Route
 	// Start the virtual network by calling Start() on the root router
 	assert.NoError(t, wan.Start())
 
-	offerMediaEngine := &MediaEngine{}
-	assert.NoError(t, offerMediaEngine.RegisterDefaultCodecs())
-	offerPeerConnection, err := NewAPI(WithSettingEngine(offerSettingEngine), WithMediaEngine(offerMediaEngine)).NewPeerConnection(Configuration{})
+	offerInterceptorRegistry := &interceptor.Registry{}
+	offerPeerConnection, err := NewAPI(WithSettingEngine(offerSettingEngine), WithInterceptorRegistry(offerInterceptorRegistry)).NewPeerConnection(Configuration{})
 	assert.NoError(t, err)
 
-	answerMediaEngine := &MediaEngine{}
-	assert.NoError(t, answerMediaEngine.RegisterDefaultCodecs())
-	answerPeerConnection, err := NewAPI(WithSettingEngine(answerSettingEngine), WithMediaEngine(answerMediaEngine)).NewPeerConnection(Configuration{})
+	answerInterceptorRegistry := &interceptor.Registry{}
+	answerPeerConnection, err := NewAPI(WithSettingEngine(answerSettingEngine), WithInterceptorRegistry(answerInterceptorRegistry)).NewPeerConnection(Configuration{})
 	assert.NoError(t, err)
 
 	return offerPeerConnection, answerPeerConnection, wan