Added a[disabled=disabled] selector to data-remote so if a link has that attribute, it won't send the request via ajax. Test added to validate implementation

Author: pier-oliviert

src/rails.js

@@ -47,6 +47,9 @@
     // Link onClick disable selector with possible reenable after remote submission
     linkDisableSelector: 'a[data-disable-with]',
 
+    // Link disabled should not be able to transmit ajax request
+    linkDisabledAttribute: 'a[disabled=disabled]',
+
     // Make sure that every Ajax request sends the CSRF token
     CSRFProtection: function(xhr) {
       var token = $('meta[name="csrf-token"]').attr('content');
@@ -293,7 +296,7 @@
 
     $(document).delegate(rails.linkClickSelector, 'click.rails', function(e) {
       var link = $(this), method = link.data('method'), data = link.data('params');
-      if (!rails.allowAction(link)) return rails.stopEverything(e);
+      if (!rails.allowAction(link) || link.is(rails.linkDisabledAttribute)) return rails.stopEverything(e);
 
       if (link.is(rails.linkDisableSelector)) rails.disableElement(link);
 

test/public/test/data-remote.js

@@ -12,6 +12,12 @@ module('data-remote', {
         'data-remote': 'true',
         method: 'post'
       }))
+      .append($('<a />', {
+        href: '/echo',
+        'data-remote': 'true',
+        disabled: 'disabled',
+        text: 'Disabed link'
+      }))
       .find('form').append($('<input type="text" name="user_name" value="john">'));
 
   }
@@ -66,7 +72,7 @@ asyncTest('ctrl-clicking on a link still fires ajax for non-GET links and for li
 });
 
 asyncTest('clicking on a link with data-remote attribute', 5, function() {
-  $('a[data-remote]')
+  $('a[data-remote]:not([disabled=disabled])')
     .bind('ajax:success', function(e, data, status, xhr) { 
       App.assert_callback_invoked('ajax:success');
       App.assert_request_path(data, '/echo');
@@ -78,6 +84,15 @@ asyncTest('clicking on a link with data-remote attribute', 5, function() {
     .trigger('click');
 });
 
+asyncTest('clicking on a link with disabled attribute', 0, function() {
+  $('a[disabled=disabled]')
+    .bind("ajax:before", function(e, data, status, xhr) {
+      ok(false, "should not send the request");
+    })
+    .trigger('click')
+  setTimeout(function(){ start(); }, 13);
+});
+
 asyncTest('changing a select option with data-remote attribute', 5, function() {
   $('form')
     .append(