ConditionalReturnTypeRuleHelper - increase type description verbosity

Author: ondrejmirtes

src/Rules/PhpDoc/ConditionalReturnTypeRuleHelper.php

@@ -61,9 +61,11 @@ public function check(ParametersAcceptor $acceptor): array
 				continue;
 			}
 
+			$verbosity = VerbosityLevel::getRecommendedLevelByType($subjectType, $targetType);
+
 			$errors[] = RuleErrorBuilder::message(sprintf(
 				'Condition "%s" in conditional return type is always %s.',
-				sprintf('%s %s %s', $subjectType->describe(VerbosityLevel::typeOnly()), $conditionalType->isNegated() ? 'is not' : 'is', $targetType->describe(VerbosityLevel::typeOnly())),
+				sprintf('%s %s %s', $subjectType->describe($verbosity), $conditionalType->isNegated() ? 'is not' : 'is', $targetType->describe($verbosity)),
 				$conditionalType->isNegated()
 					? ($isTargetSuperType->yes() ? 'false' : 'true')
 					: ($isTargetSuperType->yes() ? 'true' : 'false'),

tests/PHPStan/Rules/PhpDoc/MethodConditionalReturnTypeRuleTest.php

@@ -63,6 +63,10 @@ public function testRule(): void
 				'Condition "int is not string" in conditional return type is always true.',
 				142,
 			],
+			[
+				'Condition "array{foo: string} is array{foo: int}" in conditional return type is always false.',
+				156,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/PhpDoc/data/method-conditional-return-type.php

@@ -145,3 +145,17 @@ public function fill4(int $i): array
 	}
 
 }
+
+class MoreVerboseDescription
+{
+
+	/**
+	 * @param array{foo: string} $i
+	 * @return ($i is array{foo: int} ? non-empty-array : array)
+	 */
+	public function fill(array $i): array
+	{
+
+	}
+
+}