diff --git a/ext/readline/config.m4 b/ext/readline/config.m4 index 209f92b6e0a76..54cf52e090beb 100644 --- a/ext/readline/config.m4 +++ b/ext/readline/config.m4 @@ -75,6 +75,11 @@ if test "$PHP_READLINE" && test "$PHP_READLINE" != "no"; then -L$READLINE_DIR/$PHP_LIBDIR $PHP_READLINE_LIBS ]) + AC_CHECK_DECL([rl_erase_empty_line], + [AC_DEFINE([HAVE_ERASE_EMPTY_LINE], [1], + [Define to 1 if readline library has rl_erase_empty_line variable.])],, + [#include ]) + AC_DEFINE(HAVE_HISTORY_LIST, 1, [ ]) AC_DEFINE(HAVE_LIBREADLINE, 1, [ ]) @@ -133,6 +138,11 @@ elif test "$PHP_LIBEDIT" != "no"; then $READLINE_SHARED_LIBADD ]) + AC_CHECK_DECL([rl_erase_empty_line], + [AC_DEFINE([HAVE_ERASE_EMPTY_LINE], [1], + [Define to 1 if edit library has rl_erase_empty_line variable.])],, + [#include ]) + AC_DEFINE(HAVE_LIBEDIT, 1, [ ]) fi diff --git a/ext/readline/readline.c b/ext/readline/readline.c index 1bd5e2fd6059a..3db64149f656a 100644 --- a/ext/readline/readline.c +++ b/ext/readline/readline.c @@ -171,7 +171,7 @@ PHP_FUNCTION(readline_info) : ZSTR_CHAR(rl_completion_append_character)); add_assoc_bool(return_value,"completion_suppress_append",rl_completion_suppress_append); #endif -#if HAVE_ERASE_EMPTY_LINE +#ifdef HAVE_ERASE_EMPTY_LINE add_assoc_long(return_value,"erase_empty_line",rl_erase_empty_line); #endif #ifndef PHP_WIN32 @@ -235,7 +235,7 @@ PHP_FUNCTION(readline_info) RETVAL_INTERNED_STR( oldval == 0 ? ZSTR_EMPTY_ALLOC() : ZSTR_CHAR(oldval)); #endif -#if HAVE_ERASE_EMPTY_LINE +#ifdef HAVE_ERASE_EMPTY_LINE } else if (zend_string_equals_literal_ci(what, "erase_empty_line")) { oldval = rl_erase_empty_line; if (value) { diff --git a/ext/readline/tests/libedit_info_001.phpt b/ext/readline/tests/libedit_info_001.phpt index 284a646446575..cb1ac929829ba 100644 --- a/ext/readline/tests/libedit_info_001.phpt +++ b/ext/readline/tests/libedit_info_001.phpt @@ -24,13 +24,13 @@ var_dump(readline_info('attempted_completion_over')); ?> --EXPECTF-- -array(6) { +array(%d) { ["line_buffer"]=> string(0) "" ["point"]=> int(0) ["end"]=> - int(0) + int(0)%A ["library_version"]=> string(%d) "%s" ["readline_name"]=> diff --git a/ext/readline/tests/readline_info_001.phpt b/ext/readline/tests/readline_info_001.phpt index fa6ea70310226..0dcd24a05c19c 100644 --- a/ext/readline/tests/readline_info_001.phpt +++ b/ext/readline/tests/readline_info_001.phpt @@ -25,7 +25,7 @@ var_dump(readline_info('completion_suppress_append')); ?> --EXPECTF-- -array(13) { +array(%d) { ["line_buffer"]=> string(0) "" ["point"]=> @@ -45,7 +45,7 @@ array(13) { ["completion_append_character"]=> string(1) " " ["completion_suppress_append"]=> - bool(false) + bool(false)%A ["library_version"]=> string(%d) "%s" ["readline_name"]=>