Skip to content

tape recorder php-vcr style #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbu opened this issue Nov 8, 2015 · 9 comments
Closed

tape recorder php-vcr style #4

dbu opened this issue Nov 8, 2015 · 9 comments
Assignees

Comments

@dbu
Copy link
Contributor

dbu commented Nov 8, 2015

build a plugin to intercept and record / replay responses to requests. inspired by http://php-vcr.github.io/ which does this using a stream wrapper around guzzle calls.

@dbu dbu mentioned this issue Nov 8, 2015
14 tasks
@dbu
Copy link
Contributor Author

dbu commented Nov 8, 2015

@jeromegamez: i talked with @adri (one of the maintainers of php-vcr) about this a few weeks ago. he is not sure whether there is much code to share, as php-vcr looks at the raw curl request.

@adri: if you have any input, please comment here...

psr-7 middleware should allow a much more elegant approach to this than the stream wrappers. in my experience with php-vcr, the challenging part is how to organize data into cassettes (the storage units). organization wise, we maybe should do a separate php-psr7-vcr repository that only cares about psr 7, and a simple plugin in this repository to integrate that system with Httplug. the jobs of recording and restoring are probably too much for a single class - and they could be integrated with psr 7 implementations even when not using Httplug.

@jeromegamez
Copy link

I would like to have a dedicated repository for a php-psr7-vcr – if someone creates one and gives me access, I'll start right away 😇

@sagikazarmark
Copy link
Member

@jeromegamez note your role in the organization 😜

@dbu
Copy link
Contributor Author

dbu commented Nov 8, 2015

given the organisation is called php-http, i think psr7-vcr would be the right name, resulting in php-http/psr7-vcr.

@sagikazarmark
Copy link
Member

I think @jeromegamez already set the repo up.

@dbu
Copy link
Contributor Author

dbu commented Nov 8, 2015

he did. with the name i suggested. unless you changed the repository name right now :-)

@sagikazarmark
Copy link
Member

Nope. Actually we discussed the name in the private chat and we followed the same logic as you did. 😄

@sagikazarmark
Copy link
Member

Can we close this in favor of #3? I think we discussed what needed to be discussed, the rest is up to @jeromegamez 😛

@jeromegamez
Copy link

Of course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants