Skip to content

Commit a15bffa

Browse files
authored
Merge pull request #80 from passageidentity/PSG-4820
PSG-4820
2 parents ace50b0 + 67cf0b7 commit a15bffa

20 files changed

+96
-81
lines changed

.github/workflows/create-release.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,26 +134,32 @@ jobs:
134134
sed -i "s/versionCode .*/versionCode $new_version_code/" passage/build.gradle
135135
echo "Updated to patch version $new_version with version code $new_version_code"
136136
137-
- name: Update version in README - major release
137+
- name: Update version in README and PassageClientService - major release
138138
if: ${{ github.event.inputs.release-type == 'major' }}
139139
run: |
140140
new_version=${{ needs.determine-next-versions.outputs.next-major }}
141141
sed -i "s/implementation 'id\.passage\.android:passage:[0-9]*\.[0-9]*\.[0-9]*'/implementation 'id.passage.android:passage:$new_version'/" README.md
142142
echo "Updated README to version $new_version"
143+
sed -i "s/private const val PACKAGE_VERSION_NUMBER = \"[0-9]*\.[0-9]*\.[0-9]*\"/private const val PACKAGE_VERSION_NUMBER = \"$new_version\"/" passage/src/main/java/id/passage/android/services/PassageClientService.kt
144+
echo "Updated PassageClientService to version $new_version"
143145
144-
- name: Update version in README - minor release
146+
- name: Update version in README and PassageClientService - minor release
145147
if: ${{ github.event.inputs.release-type == 'minor' }}
146148
run: |
147149
new_version=${{ needs.determine-next-versions.outputs.next-minor }}
148150
sed -i "s/implementation 'id\.passage\.android:passage:[0-9]*\.[0-9]*\.[0-9]*'/implementation 'id.passage.android:passage:$new_version'/" README.md
149151
echo "Updated README to version $new_version"
152+
sed -i "s/private const val PACKAGE_VERSION_NUMBER = \"[0-9]*\.[0-9]*\.[0-9]*\"/private const val PACKAGE_VERSION_NUMBER = \"$new_version\"/" passage/src/main/java/id/passage/android/services/PassageClientService.kt
153+
echo "Updated PassageClientService to version $new_version"
150154
151-
- name: Update version in README - patch release
155+
- name: Update version in README and PassageClientService - patch release
152156
if: ${{ github.event.inputs.release-type == 'patch' }}
153157
run: |
154158
new_version=${{ needs.determine-next-versions.outputs.next-patch }}
155159
sed -i "s/implementation 'id\.passage\.android:passage:[0-9]*\.[0-9]*\.[0-9]*'/implementation 'id.passage.android:passage:$new_version'/" README.md
156160
echo "Updated README to version $new_version"
161+
sed -i "s/private const val PACKAGE_VERSION_NUMBER = \"[0-9]*\.[0-9]*\.[0-9]*\"/private const val PACKAGE_VERSION_NUMBER = \"$new_version\"/" passage/src/main/java/id/passage/android/services/PassageClientService.kt
162+
echo "Updated PassageClientService to version $new_version"
157163
158164
- name: Commit major version change
159165
uses: stefanzweifel/git-auto-commit-action@v4

passage/src/androidTest/java/id/passage/android/ChangeContactTests.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ internal class ChangeContactTests {
2525
activityRule?.scenario?.onActivity { activity ->
2626
activity?.let {
2727
passage = Passage(it, IntegrationTestConfig.APP_ID_OTP)
28-
passage.overrideBasePath(IntegrationTestConfig.API_BASE_URL)
2928
}
3029
}
3130
}

passage/src/androidTest/java/id/passage/android/IntegrationTestConfig.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ internal class IntegrationTestConfig {
1616
const val AUTH_TOEKN = BuildConfig.OTP_TEST_USER_AUTH_TOKEN
1717
val CURRENT_USER =
1818
PublicUserInfo(
19-
email = "authentigator+1724103897318@ncor7c1m.mailosaur.net",
19+
email = "authentigator+1727293832645@ncor7c1m.mailosaur.net",
2020
emailVerified = true,
21-
id = "vIfrBSgiQ8Ql6lEdzHyV3biS",
21+
id = "ZN2JTd6NqbTAvN45SbjUzqVn",
2222
phone = "",
2323
phoneVerified = false,
2424
status = UserStatus.active,

passage/src/androidTest/java/id/passage/android/PassageCurrentUserTests.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ internal class PassageCurrentUserTests {
2626
activityRule?.scenario?.onActivity { activity ->
2727
activity?.let {
2828
passage = Passage(it, IntegrationTestConfig.APP_ID_OTP)
29-
passage.overrideBasePath(IntegrationTestConfig.API_BASE_URL)
3029
}
3130
}
3231
}

passage/src/androidTest/java/id/passage/android/PassageHostedTests.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import androidx.test.ext.junit.runners.AndroidJUnit4
1212
import androidx.test.platform.app.InstrumentationRegistry
1313
import androidx.test.uiautomator.UiDevice
1414
import com.google.common.truth.Truth.assertThat
15-
import id.passage.android.IntegrationTestConfig.Companion.API_BASE_URL
1615
import id.passage.android.IntegrationTestConfig.Companion.APP_ID_OIDC
1716
import id.passage.android.exceptions.HostedAuthorizationError
1817
import junit.framework.TestCase.fail
@@ -35,7 +34,6 @@ internal class PassageHostedTests {
3534
activityRule?.scenario?.onActivity { activity ->
3635
activity?.let {
3736
passage = Passage(it, APP_ID_OIDC)
38-
passage.overrideBasePath(API_BASE_URL)
3937
}
4038
}
4139
}

passage/src/androidTest/java/id/passage/android/PassageMagicLinkTests.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import MailosaurAPIClient
44
import androidx.test.ext.junit.rules.ActivityScenarioRule
55
import androidx.test.ext.junit.runners.AndroidJUnit4
66
import com.google.common.truth.Truth.assertThat
7-
import id.passage.android.IntegrationTestConfig.Companion.API_BASE_URL
87
import id.passage.android.IntegrationTestConfig.Companion.APP_ID_MAGIC_LINK
98
import id.passage.android.IntegrationTestConfig.Companion.DEACTIVATED_USER_EMAIL_MAGIC_LINK
109
import id.passage.android.IntegrationTestConfig.Companion.EXISTING_USER_EMAIL_MAGIC_LINK
@@ -31,7 +30,6 @@ internal class PassageMagicLinkTests {
3130
activityRule?.scenario?.onActivity { activity ->
3231
activity?.let {
3332
passage = Passage(it, APP_ID_MAGIC_LINK)
34-
passage.overrideBasePath(API_BASE_URL)
3533
}
3634
}
3735
}

passage/src/androidTest/java/id/passage/android/PassageOneTimePasscodeTests.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import MailosaurAPIClient
44
import androidx.test.ext.junit.rules.ActivityScenarioRule
55
import androidx.test.ext.junit.runners.AndroidJUnit4
66
import com.google.common.truth.Truth.assertThat
7-
import id.passage.android.IntegrationTestConfig.Companion.API_BASE_URL
87
import id.passage.android.IntegrationTestConfig.Companion.APP_ID_OTP
98
import id.passage.android.IntegrationTestConfig.Companion.EXISTING_USER_EMAIL_OTP
109
import id.passage.android.IntegrationTestConfig.Companion.WAIT_TIME_MILLISECONDS
@@ -29,7 +28,6 @@ internal class PassageOneTimePasscodeTests {
2928
activityRule?.scenario?.onActivity { activity ->
3029
activity?.let {
3130
passage = Passage(it, APP_ID_OTP)
32-
passage.overrideBasePath(API_BASE_URL)
3331
}
3432
}
3533
}

passage/src/androidTest/java/id/passage/android/PassageSocialTests.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ internal class PassageSocialTests {
3636
activityRule?.scenario?.onActivity { activity ->
3737
activity?.let {
3838
passage = Passage(it, APP_ID_OTP)
39-
passage.overrideBasePath(API_BASE_URL)
4039
}
4140
}
4241
}

passage/src/androidTest/java/id/passage/android/TokenStoreTests.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import MailosaurAPIClient
44
import androidx.test.ext.junit.rules.ActivityScenarioRule
55
import androidx.test.ext.junit.runners.AndroidJUnit4
66
import com.google.common.truth.Truth.assertThat
7-
import id.passage.android.IntegrationTestConfig.Companion.API_BASE_URL
87
import id.passage.android.IntegrationTestConfig.Companion.APP_ID_OTP
98
import id.passage.android.IntegrationTestConfig.Companion.EXISTING_USER_EMAIL_OTP
109
import id.passage.android.IntegrationTestConfig.Companion.WAIT_TIME_MILLISECONDS
@@ -35,7 +34,6 @@ internal class TokenStoreTests {
3534
activityRule?.scenario?.onActivity { activity ->
3635
activity?.let {
3736
passage = Passage(it, APP_ID_OTP)
38-
passage.overrideBasePath(API_BASE_URL)
3937
}
4038
}
4139
// Log in user
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<resources>
2+
<string name="app_name">Test App</string>
3+
4+
<!-- Required Passage app settings -->
5+
<string name="passage_auth_origin">try-uat.passage.dev</string>
6+
<string name="clientApiBasePath">https://auth-uat.passage.dev/v1</string>
7+
<string name="asset_statements">
8+
[{
9+
\"include\": \"https://@string/passage_auth_origin/.well-known/assetlinks.json\"
10+
}]
11+
</string>
12+
13+
</resources>

0 commit comments

Comments
 (0)